public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: srinuvasan.a@siemens.com, isar-users@googlegroups.com,
	"Moessbauer, Felix (T CED SES-DE)" <felix.moessbauer@siemens.com>
Subject: Re: [PATCH] meta/classes/initramfs: remove unused variable
Date: Tue, 21 May 2024 10:32:31 +0200	[thread overview]
Message-ID: <d8e3548a-a524-4c90-98fc-92b60dfc6e3c@siemens.com> (raw)
In-Reply-To: <20240509105935.4691-1-srinuvasan.a@siemens.com>

On 09.05.24 12:59, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> The variable INITRAMFS_IMAGE_FILE is nowhere used across
> the repository, hence remove the unused variable.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/initramfs.bbclass | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
> index 5b5943f2..6886b95a 100644
> --- a/meta/classes/initramfs.bbclass
> +++ b/meta/classes/initramfs.bbclass
> @@ -14,7 +14,6 @@ INITRAMFS_INSTALL ?= ""
>  INITRAMFS_PREINSTALL ?= ""
>  INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
>  INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
> -INITRAMFS_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}"
>  
>  # Install proper kernel
>  INITRAMFS_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME")) if d.getVar("KERNEL_NAME") else ""}"

Looks good. Would look even better when pointing to the commit that
obsoleted it (4b3382a98f3a).

Jan

-- 
Siemens AG, Technology
Linux Expert Center


  parent reply	other threads:[~2024-05-21  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09 10:59 srinuvasan.a
2024-05-21  7:19 ` Srinuvasan Arjunan
2024-05-21  8:32 ` Jan Kiszka [this message]
2024-05-28  6:02 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8e3548a-a524-4c90-98fc-92b60dfc6e3c@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=srinuvasan.a@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox