From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7203018052316692480 X-Received: by 2002:ac2:560e:0:b0:4db:1999:67a4 with SMTP id v14-20020ac2560e000000b004db199967a4mr7288098lfd.5.1677494504586; Mon, 27 Feb 2023 02:41:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:e9f:b0:4db:51a5:d2e8 with SMTP id bi31-20020a0565120e9f00b004db51a5d2e8ls4254883lfb.2.-pod-prod-gmail; Mon, 27 Feb 2023 02:41:42 -0800 (PST) X-Google-Smtp-Source: AK7set+CrO5YitojFK/j3kC5HFdDsGIBD/laz51+S4WUlPTBj0gKnI7cWTo+7MvfhgEgbASkuS7q X-Received: by 2002:a19:c20c:0:b0:4e1:7d1c:85ce with SMTP id l12-20020a19c20c000000b004e17d1c85cemr187783lfc.27.1677494502806; Mon, 27 Feb 2023 02:41:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1677494502; cv=pass; d=google.com; s=arc-20160816; b=vBxnOtVt/dipPkW/jRG3BgnN9i3cQh4C+HaywxE6PZytSppT3mWBMNV7NSuAQLoD72 shn04sj3QZbZzwRnirzYYlCt17vQOzIFcohucjUCOTBj+qhpp8uyJHGlTdMuepILdcAU d6dwns7KJmELyiynqwO8tqBWP7o/wbP8U9bP0vwa2y5GCpxrgu3SDI38wyf1Yx9+4Uo1 Dfp3dU5kXFJ+WVvWwaqDHUJIyeEjNVy3GMr8wOG17pxB0oZGggJYMVlOaN8jvjbpMAtr C6eOh19BC2SDOXZmE1IYqKcsu/4Xpi8L0ArAZpS3AkPGxpppZZD3IlbKhAKyooSS9/E+ xaVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:references:cc:to :from:content-language:subject:user-agent:date:message-id :dkim-signature; bh=8eboa6YcqJkKRqlsPlnW/P1s9IUcRhl3S8uIfcv79xM=; b=IrAZVs8NQX9BeWvTtZ3nQhR+08r8MZqqiddiE5Oq1EQo7VoYM3mz266MEO7NKeUgIP 8TvYJNCNVIrkKA1bzFMpNN+/GplqR4MKPyNjv510t7M4ztkhjmb1wVNJrq6bcfYgvWb5 lNBsMMpWQNfAmXGqAAzu1spVZQDpuvbzKF29ofRkhB7tg+lwA/o7jvwMnLLt2NpjJ+C4 ol1oFxmVhXfey945BHKRQryM8h2ng8qGv6qbYZl8X3NPvElAuNSL9MDOarYB/9mBj6Gp fvKXbnZAr+2soEE9OXxphGJZU2i0hXVMKo7F0uCewZ/DJ7LoPRxBZYETN5UcgFNtjJuR PRpQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wKppXO1J; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::612 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0612.outbound.protection.outlook.com. [2a01:111:f400:fe0e::612]) by gmr-mx.google.com with ESMTPS id z1-20020a195041000000b004dc7d884e8fsi232715lfj.6.2023.02.27.02.41.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2023 02:41:42 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::612 as permitted sender) client-ip=2a01:111:f400:fe0e::612; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wKppXO1J; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::612 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8sy0+gj6Cp5OohM9uzMzoRzoK0UFfsWn2mIV8Hd40HVG6B5iTPLKeo6lgkgKFKiBuvhdxkeYRe7WLeQ5r6o0FCrTL0GspPa39v1hjLH8Z3HuKq7Z4kxCBG5sTi7bGkRxHdc+NFumF91z8uXBB72w/qxudatDc1ruVspQ+0W7EZtYUMMNsQi4LleE/O46PDi2CuOOxBMOlhEOLLHaOYQ0vvvmKxlRFTvzHOyGirMKUiCgMhqbg/fRyBOBUJAOf6YRrjT13ih4wYhavj0ihGU8ZD3METxQ1c1pJI/VmpZK8luWEdacxrlrfRyAUKpY+08vJAzh9/kagojNt15MmrmWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8eboa6YcqJkKRqlsPlnW/P1s9IUcRhl3S8uIfcv79xM=; b=MwRyO4RzuBd7TcSBQ8jKccpHUVZQIC1VfsCXZ9fxk3ostdgedDgMx0fML3uLZUpGEN2ivZrZ9sa6rwU58PIMD35UJF4cE8JRKFOb/hljTOi7BbJqP/fkUo3C6lg75oR4mm8WKV66pwFl3dm0c2v0yUn4hemK1uxPTqJ1C2tUeS3CVKJRQQ/I3ygecIfDH2FLEy9+XsXjwH6v1u28ZwwAAlWpYqdPTdXHBBoafmqcV0x0HaPlLiiUZaNLDOfyAdOFPDs1zK9i7xctRwrDQu8zb9PiGM6nVN1k4t4QJTemLQTmVT4t4A34bSp39IeDjCvozHXcLreMN0uRS1knaGKvUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8eboa6YcqJkKRqlsPlnW/P1s9IUcRhl3S8uIfcv79xM=; b=wKppXO1J/UehfPaeKI/pvAxGiykpSF0vbKZY+rhZe3S/cX7XW2jNEHTJFn1YlSZEZexUoDYlshpis3igf3SxM1VPeCORMGrxUB0NUGsR6OAVju/9FUQq1h6zPZ52jheKLiWucgSDFuQer+XxF0XD4NLT8JnGuK4QxVohUNkSaoC9dNlOmvUxZeJoHG2iYDy0IZNncR9/j8eVkMgOkmCvvyO/XFRlkwJ8HKiUOxWusbravXrrWRo0V5i6yycTZI3x8b/osLRo4dM4ChA1Oq4n8n+tZe1djhOnOZS77PDTqdrBc0iySpiOheRoYpVkfB1P9T9gN6cxJ32txfoQzehzqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AM7PR10MB3223.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:10a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 10:41:40 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5%9]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 10:41:39 +0000 Message-ID: Date: Mon, 27 Feb 2023 11:41:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] sdk: Avoid parsing errors when DISTRO_ARCH is not yet set Content-Language: en-US From: Jan Kiszka To: isar-users , Anton Mikanovich Cc: "Moessbauer, Felix (T CED SES-DE)" , "Hombourger, Cedric (DI SW MG EPT)" References: <4ac8a0a6-50ac-5a76-88c0-3eef5d2f96a9@siemens.com> In-Reply-To: <4ac8a0a6-50ac-5a76-88c0-3eef5d2f96a9@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::19) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AM7PR10MB3223:EE_ X-MS-Office365-Filtering-Correlation-Id: 134b7624-50e6-4437-8f9b-08db18af3557 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v2nftM4mcSW6IwauqyIMlcVjPuAOxPfdW0AC0xcsFxvM6cv8sa2CAMLCN+VvcKkFOm7YgNSm+fkztTpPyqwo5wAZmadHsS+Axz/MHSq0vnImN0rLcIR2yDLKr271znB8xIDs6L2ASc2SK1lrRHb7iIibuN19UicEzB6h3B6bBG0yaTL3oMu7TfVTS1nzrnvkhVDPiayA9BOw3ZBnRF8RBKaBVqhM9yn1eOEbzsGvzvI4DdylGLcgNFUQiztRsc5SrX2VPVEa+r1MxfbPeBU15so9pplx0QP6ZvPdp7QTgZqnkSKvoJlA7D7k519dPRutJ1qaOj9Y65blyq65tGAqxL1KfF4I/Wyrnk0HMWbU4pzcVGzfNMUuZ1iMUh7SsFnqK373sMqQa92+Q12/o5Qtwe/CvJcRzGW0vQGZs7yn4QVTMCSWMEBAD0EOTO5FZe6ISU8p8iG+/ne9oz7gpXQddCS2Jq/ooY1BtHMQ3T5UNSvB1jmp0JSWtbb8SNR99CyCIUzE/FffGAzIBcI4N7WQp5EraJpPqHOP9UfaXdxyE0A/gbn3yA/XvodRkHR7ToZ1bQkbpSn+ddUBa/WfkCst64bXkm7+f9wwcX1hom+Kpe4j126TSb4IvbLU1ghkG1/4Ym/mqWQxNPHfX7MxMlMXRUn0xMSb56kK0E7J/fhY7FeXxJgoIasLeH1XS+7zyThCrAvwwH/5bwBQrFqyDgXUaeRW3rLs9pAzrrC9soeY9Dk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199018)(8936002)(2906002)(5660300002)(31686004)(41300700001)(44832011)(66476007)(66556008)(66946007)(4326008)(8676002)(316002)(110136005)(54906003)(478600001)(6486002)(966005)(107886003)(26005)(6512007)(186003)(53546011)(6506007)(2616005)(86362001)(82960400001)(83380400001)(36756003)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGY4NE9WY2NvYis2MFZPS2dXeFNLdG8ycFdwdG42RVk1K3RESlU5NUtZLzBm?= =?utf-8?B?VDgwQ3BZMElJaHU1dGV5b2dONGZkZDZOVENiV1YzUzN6Ui9pVk9SMUtxU1F5?= =?utf-8?B?eWZ3RVc2YysyUWYxdXdzbUwvYnBlRmZ6bjJ0QVIxeWVKOXI1d0tNREtnNUQ4?= =?utf-8?B?TTFTZEdHQXM5TXNoT2lycDRIVG1WcXhmbDhGczFPUHdSRy9iSkM1NWpDT3Nr?= =?utf-8?B?K1dMOFhHTk5XVG5xeDlvazE2aGgvdTZKSjRwK2laZEM0emhZa29TRytBZTE0?= =?utf-8?B?Ykx4NkVTVkFwS0Qycy94TlNEdy9GK2pZRXpaa2xaKy84anBHT3UydFBXdjBI?= =?utf-8?B?S1hscEpoUHpRdTQ0TDlhTnVvekxsVGZYZ0VLR3pPNEd6UlQ5aEx0N3N3VHdB?= =?utf-8?B?L21YVTl6ZzdwZ1NMR3phM1hPaUNTdzd5NmZHYzQveW8zek8vb2ZMQnJEc1d1?= =?utf-8?B?aTZuNGx2QTlQaE5JVVlka1pxa0VkR1pqNkl6WTFMRXdNSHlxdjY2RFovWXJm?= =?utf-8?B?cTBJS3dEeTNRZk0rRU8zRzEybXdtUHQ4MFlWeERjdDA2SVBiRjN3WE12SDFt?= =?utf-8?B?Q1p2Tlg4VkdWaGVCYzNseWtJUFEzd3loTUZwSzBscUpyRzdob1hhcVJXMGl2?= =?utf-8?B?MHRJL29uUW11M2NyOHVOOHJtS3JUMExQTXdQY2pId0tsQXJUUXFobXhTZ09D?= =?utf-8?B?dmFIUFVDdDQ3OG5hVDl3Sk9sQS9YZXBSd2xqS2J4TW5XMVhJeWdoWWJIVnVT?= =?utf-8?B?Wkx0bTlmbjFRN3I2SXdjZ0Z6S3Y0QlBnMVhmNlh0Wm9IVUtYajBJUU0yOFlt?= =?utf-8?B?NFdoYWtxblB4V0tnU2pYZmhqb3FKcE1yMGtsWXBIbldqNjlSSDM0Q2RzcVFv?= =?utf-8?B?MHk4VlNZcjhFRjE5S2Vjb3J4M1NMazJkbVUvOVkwSTdDWTBlemY3RkFjOHNy?= =?utf-8?B?U3AxdG5rNUFzV1dXbmFQZ0ZWb3puc1Q2bFBCLzNUL2xoNUZvVUVicDVQZEE1?= =?utf-8?B?dkZJaVpsdVVTZjIyU2MzUlFKMk5ERk5Ha3V4K05GUzg4bExSU3o2Y0RlM1Rr?= =?utf-8?B?d2ZMSFFsMW41Q3lCY2o0UGg3MmdXWnY0YVZHVVB0YTZMQkNlSW0xL2R6TGJU?= =?utf-8?B?L3d1S3pWclJMaFFPanhzU2VxYUlabTMrSjhSaWpOdUc5eU4zM01Yb3UvZTFv?= =?utf-8?B?QjJCejlLV2xXTGhPbzl1OGFGWlYxUThPbUEybVcxK09ZSENiOEJzR0JxdHRJ?= =?utf-8?B?czYwNkdvNS9KK0xVaWh3aTM1c3NXeTV0dmMrZUpoblpKZzJhL3J2blRlcldw?= =?utf-8?B?VW40ckpuNGMyQ1BtQmlXL2Zyc0dHTEk0YVgvZVY2ZlA5VFBxdVpmdmRCRklt?= =?utf-8?B?WGFhTUtYZWpIVlhlRlNuM3dGenVHb3crSEYwQlFmWTRaM2JyRXgwR3JTUi84?= =?utf-8?B?Mk1LbkFvY1pzaGlTNktGRWFmclhVUm5oRUh2MGk3cWRoNFhEd0ptalNBWWxp?= =?utf-8?B?SkVnNlhXdzdvZVpFWjVoa05kN3dqWHNYQ3pkdjFnUW4wZ1dEckV5aTQ1WGhW?= =?utf-8?B?aEdubE92d2cxQUJ6MHFXd1F3QXdTZEF5Z0JQVzgrN3I3WWdaNGNqSHVORGlC?= =?utf-8?B?d3cvVFhCeFE4cmpOQVFadklTVUhLQVE4WkZSTDZISjhoTVdrWStSZG1zZVk2?= =?utf-8?B?bW43UmR1WEM5NjVKM2pTbTRjckM5OWk0UWNPZDZYSkkzbXo3dUFyZ2xUOVRn?= =?utf-8?B?RTltZVhKTzhGdnZsNlF2WDVIaVZjajI4dlFLMTVsNFlTTG9QLzZSajJVUGJ3?= =?utf-8?B?UG1zdDJTTjdGdFVXTCs0SFZTN2xqM2VQZDczTGczMUdLQ0F4TVIzaEVHV2NJ?= =?utf-8?B?c1NVaFhDV1h5eEN5YktjUHpkVWdma1F0RlRNRUQ1cUt5NFhxZFJpejFmY3NG?= =?utf-8?B?L2lxTjdXVEdYVXhhSlJtWUp6cms4R056elFtSlRKMk1SMzVBOXlMM04vUDFB?= =?utf-8?B?b1NXdS9PSkZVTkR0SWg5Mzc1angrRXdWQTR3cGQ0Vk4yOHpuOWU2Z1AzclBF?= =?utf-8?B?VTZPcjZJc3EwR2hoZzZMQWZXNEFoakFHTVJUY0s3eGNDZ3FDT0IvQ1U2WE0y?= =?utf-8?B?ZVlzbnFkYWc0VUhSU20rcEF4WXljcVkvdTdWWGplS1lGVi83OVR6WlRZb1U4?= =?utf-8?B?SVE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 134b7624-50e6-4437-8f9b-08db18af3557 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 10:41:39.7424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NAIBAywG0hAHykJoHCF5UhhSsUTgDL9vuhiRm+NzIlQjCJeZjI1t0UzzRNH/goKLHMcFM9Q1b9WfC9thn8hq4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3223 X-TUID: wUSduHKGtla0 On 22.02.23 17:28, Jan Kiszka wrote: > From: Jan Kiszka > > In multiconfig setups, it can happen during some parsing steps that a > machine and, thus, a concrete DISTRO_ARCH is not yet set, leading to > > The stack trace of python calls that resulted in this exception/failure was: > File: '', lineno: 4, function: > 0001:__anon_158__build____work_isar_meta_classes_base_bbclass(d) > 0002:__anon_162__build____work_isar_meta_classes_sstate_bbclass(d) > 0003:__anon_56__build____work_isar_meta_classes_image_bbclass(d) > *** 0004:__anon_56__build____work_isar_meta_classes_sdk_bbclass(d) > 0005:__anon_21__build____work_isar_meta_classes_buildchroot_bbclass(d) > 0006:__anon_84__build____work_isar_meta_classes_imagetypes_wic_bbclass(d) > 0007:__anon_24__build____work_isar_meta_classes_imagetypes_container_bbclass(d) > 0008:__anon_305__build____work_isar_meta_classes_image_bbclass(d) > File: '/build/../work/isar/meta/classes/sdk.bbclass', lineno: 52, function: __anon_56__build____work_isar_meta_classes_sdk_bbclass > 0048: distro_arch = d.getVar('DISTRO_ARCH') > 0049: if mode == "0" or d.getVar('HOST_ARCH') == distro_arch: > 0050: toolchain = "build-essential" > 0051: else: > *** 0052: toolchain = "crossbuild-essential-" + distro_arch > 0053: if d.getVar('ISAR_ENABLE_COMPAT_ARCH', True) == "1": > 0054: toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH') > 0055: d.setVar('TOOLCHAIN', toolchain) > 0056:} > Exception: TypeError: can only concatenate str (not "NoneType") to str > > Signed-off-by: Jan Kiszka > --- > > Found in mtda: https://github.com/siemens/mtda/pull/283 > > meta/classes/sdk.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass > index 0a98ea04..01eb3a67 100644 > --- a/meta/classes/sdk.bbclass > +++ b/meta/classes/sdk.bbclass > @@ -46,7 +46,7 @@ SDK_PREINSTALL += " \ > python __anonymous() { > mode = d.getVar('ISAR_CROSS_COMPILE', True) > distro_arch = d.getVar('DISTRO_ARCH') > - if mode == "0" or d.getVar('HOST_ARCH') == distro_arch: > + if mode == "0" or d.getVar('HOST_ARCH') == distro_arch or distro_arch == None: > toolchain = "build-essential" > else: > toolchain = "crossbuild-essential-" + distro_arch Hmm, I thought you have fast path for small fixes now? Jan -- Siemens AG, Technology Competence Center Embedded Linux