From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Quirin Gylstorff <quirin.gylstorff@siemens.com>,
"Heinisch,
Alexander (T CED SES-AT)" <alexander.heinisch@siemens.com>
Subject: [PATCH 2/2] Revert "expand-on-first-boot: Expand crypto_LUKS partition"
Date: Fri, 8 Nov 2024 12:27:17 +0100 [thread overview]
Message-ID: <d9255a29-23b3-44bf-a66f-e974a96af7fa@siemens.com> (raw)
In-Reply-To: <fdfafbd0-741c-4c39-85b1-4e0878fbf90a@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
This reverts commit c44c088cd224e44a401410c860bd625f28950ac3.
Same argument as for reverting 8b30a4f86cb3: This does not work when the
initramfs properly hides the encryption secret after using it.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
.../files/expand-last-partition.sh | 22 ++++---------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
index c66d7627..2c4326c1 100755
--- a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
+++ b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
@@ -78,28 +78,14 @@ fi
# some filesystems need to be mounted i.e. btrfs, but mounting also helps
# detect the filesystem type without having to wait for udev
# mount $LAST_PART out of tree, so we won't conflict with other mounts
-ret=0
-# Determine the filesystem type and perform the appropriate resize function
-FS_TYPE=$(blkid --output value --match-tag TYPE "${LAST_PART}" )
MOUNT_POINT=$(mktemp -d -p "" "$(basename "$0").XXXXXXXXXX")
-if [ "$FS_TYPE" = "crypto_LUKS" ]; then
- if [ ! -x /usr/sbin/cryptsetup ]; then
- echo "'cryptsetup' is missing cannot resize last partition as it is from type 'crypto_LUKS'"
- exit 1
- fi
- last_part_device_name=${LAST_PART#\/dev/}
+mount "${LAST_PART}" "${MOUNT_POINT}"
- mapping_name=$(cat /sys/class/block/"$last_part_device_name"/holders/*/dm/name)
- cryptsetup resize "$mapping_name"
- mount /dev/mapper/"$mapping_name" "${MOUNT_POINT}"
- FS_TYPE=$(findmnt -fno FSTYPE "${MOUNT_POINT}" )
- LAST_PART=/dev/mapper/"$mapping_name"
-else
- mount "${LAST_PART}" "${MOUNT_POINT}"
-fi
+ret=0
+# Determine the filesystem type and perform the appropriate resize function
+FS_TYPE=$(findmnt -fno FSTYPE "${MOUNT_POINT}" )
case ${FS_TYPE} in
ext*)
-
# Do not fail resize2fs if no mtab entry is found, e.g.,
# when using systemd mount units.
export EXT2FS_NO_MTAB_OK=1
--
2.43.0
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/d9255a29-23b3-44bf-a66f-e974a96af7fa%40siemens.com.
parent reply other threads:[~2024-11-08 11:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <fdfafbd0-741c-4c39-85b1-4e0878fbf90a@siemens.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9255a29-23b3-44bf-a66f-e974a96af7fa@siemens.com \
--to=isar-users@googlegroups.com \
--cc=alexander.heinisch@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=quirin.gylstorff@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox