From: Zhihang Wei <wzh@ilbers.de>
To: alexander.heinisch@siemens.com, isar-users@googlegroups.com
Cc: badrikesh.prusty@siemens.com
Subject: Re: [PATCH] image-postproc: Revert of gate systemd preset-all on masked unit state (321185dc)
Date: Tue, 11 Aug 2026 10:55:22 +0200 [thread overview]
Message-ID: <d94bec86-51c4-4e5a-98f6-0829bdfd36eb@ilbers.de> (raw)
In-Reply-To: <20260806123136.550407-1-alexander.heinisch@siemens.com>
Applied to next, thanks.
Zhihang
On 8/6/26 14:31, alexander.heinisch@siemens.com wrote:
> From: Alexander Heinisch <alexander.heinisch@siemens.com>
>
> Proposed fix in the previous patch 321185dc3ec8be8f2b3a547caf225cebdbd5edf9
> tried to resolve an issue caused by a conflict of a preset, explicitly enabling
> a masked target, but was fighting symptoms, instead of fixing the root cause.
>
> Proper solution in cases where units are masked is to explicitly disable those in
> the system-presets if they were explicitly enabled before. If a masked unit is not
> explicitly set to be enabled in the preset no action is needed.
>
> See discussion at: https://groups.google.com/g/isar-users/c/wojTiSSPfG4
>
> Signed-off-by: Alexander Heinisch <alexander.heinisch@siemens.com>
> ---
> meta/classes-recipe/rootfs.bbclass | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index bdb9ea7a..2f80ac07 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -605,8 +605,7 @@ image_postprocess_populate_systemd_preset() {
> SYSTEMD_INSTALLED=$(dpkg-query --showformat='${db:Status-Status}' --show systemd 2>/dev/null)
>
> if [ "${SYSTEMD_INSTALLED}" = "installed" ]; then
> - systemctl list-unit-files --state=masked --no-legend | grep -q '^' \
> - || systemctl preset-all --preset-mode="enable-only"
> + systemctl preset-all --preset-mode="enable-only"
> fi
> EOSH
> }
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/d94bec86-51c4-4e5a-98f6-0829bdfd36eb%40ilbers.de.
prev parent reply other threads:[~2026-08-11 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 12:31 alexander.heinisch via isar-users
2026-08-11 8:55 ` Zhihang Wei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d94bec86-51c4-4e5a-98f6-0829bdfd36eb@ilbers.de \
--to=wzh@ilbers.de \
--cc=alexander.heinisch@siemens.com \
--cc=badrikesh.prusty@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox