From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6683827867816558592 X-Received: by 2002:a7b:c3d7:: with SMTP id t23mr7233479wmj.62.1556279452422; Fri, 26 Apr 2019 04:50:52 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:ca0c:: with SMTP id a12ls1378572wmg.5.gmail; Fri, 26 Apr 2019 04:50:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqwcKxaTF2n/2t+r7rM2jXDNE7p0NhUv3qIk0wzTj4fwCN8Ta8Vh2KK1+fCYFfMEhuKCcaEc X-Received: by 2002:a1c:f901:: with SMTP id x1mr7714636wmh.136.1556279451875; Fri, 26 Apr 2019 04:50:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556279451; cv=none; d=google.com; s=arc-20160816; b=CvU0PkRKWFW2U+PHFMBxrTFXFa8MOL1eRRu1UFr0ZsnUu2Esy07GHk5KXxe4AF9aLI 3ZIDeAsqLiXdIAnAVsRx79p/IupcTqU+FHCGcEQ7uqPzvDwPOXHDFtJ/9+Xgt/3UUKnx 1Nu16iudOGVSWqENvAEdZVtYuD4A+0jTyRQBZTSkp7FXw3SEyUv1tK8SZxZiNec+X3i2 i8ksBykbKfAx/2Lv9jaG5fssjC6TbSn9B+yOfppheh+sEPn5qemOOq251Ey620/mcx87 TZ5RFJyLE7aqSfhdedgzIR3RQOR7DhA5CBp1SYePzYGvL6VLGZ2zJOKdZ4N4BfHfpEbY Ae8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=FCoU6gl5Etjod0qQlWToV8hvnluc/bV55P4PX898H+w=; b=R2M2z8qwwsJHUKiVzNgMaenplht8eOAEoylAJCpm674/uKo17SEuzgbZqGqaRRAOdl eCab3WLNIK0qFESNSMC14WSE6wypXtfnECCN+SzskHLLTbblVnSl6oVLXuba2/08coU6 WhG6Ya9Hwrnh3demRDwAMAi0QjdU7w46lVCJ2LEmmvcPlZLIrIKgi4SI+PMrZVBNT+Vv OXzu1indb9lRoeiJtzbwW5nE8stMm/mi02EcE4jUKkA2kpAVLm6KX7swub8J4uY1RB56 eC/1UWfFy1JJsNheAKpUdNtVgtSIXtj13H/n18hMp2mvFP5bnrKiVV1gWy2SSnkV8Qts EzuA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id d14si1419282wrj.3.2019.04.26.04.50.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 04:50:51 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x3QBopoW007599 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Apr 2019 13:50:51 +0200 Received: from [167.87.22.130] ([167.87.22.130]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x3QBooGY032429; Fri, 26 Apr 2019 13:50:50 +0200 Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage From: Jan Kiszka To: Claudius Heine , "Maxim Yu. Osipov" , claudius.heine.ext@siemens.com, isar-users@googlegroups.com References: <20190425134450.13443-1-claudius.heine.ext@siemens.com> <20190425134450.13443-2-claudius.heine.ext@siemens.com> <155626421155.10914.2537647574220599237@ardipi> Message-ID: Date: Fri, 26 Apr 2019 13:50:50 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: x8zb0o/FJGb6 On 26.04.19 13:31, [ext] Jan Kiszka wrote: > On 26.04.19 09:36, Claudius Heine wrote: >> Hi Maxim, >> >> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59) >>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote: >>>> From: Claudius Heine >>>> >>>> isar-bootstrap-host only supports bootstrapping Debian root file >>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other >>>> distributions. >>>> >>>> Signed-off-by: Claudius Heine >>>> --- >>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++ >>>>    1 file changed, 2 insertions(+) >>>> >>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>>> index 08b068f..3e96281 100644 >>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = >>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}" >>>>    ISAR_BOOTSTRAP_LOCK = >>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock" >>>>    require isar-bootstrap.inc >>>> +# We only build debian host buildchroot environments >>>> +DISTRO_APT_KEYS = "" >>> >>>   From the first glance this modification limits functionality. >>> It looks like a hack and I would suggest to avoid this modification. >> >> Well it is a fix and that limited functionality was already present but >> just implicit, hidden behind some bug and the cleanup just made it >> appear. >> >>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to >>> avoid confusion between target and host apt keys. >> >> Good idea. But that would be a new feature/improvement. >> > > If that is just about adding and documenting another variable, let's not discuss > about when and who because just doing that will already be faster, even if it's > a "drive-by" improvement /wrt this patchset. > OTOH, I don't get the problem yet from just reading the commit message: Wasn't DISTRO_APT_KEYS designed to be a superset of all needed keys? We are appending raspbian to it when using that distro. So, we are at least missing the reasoning here why that model didn't work and cannot be made working for the host/target case. And then we can refer to that when introducing split key sets. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux