public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Claudius Heine <claudius.heine.ext@siemens.com>,
	isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe
Date: Thu, 25 Apr 2019 08:50:57 +0300	[thread overview]
Message-ID: <da09c7a2-9983-e059-8bfd-a401a42e21f2@ilbers.de> (raw)
In-Reply-To: <fbfa8476-dd60-e159-135b-741ce644544b@siemens.com>

On 4/24/19 10:48 AM, Claudius Heine wrote:
> ping
> 
> On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> In machines that have not set those variables, it is still possible that
>> those classes are parsed. The parsing itself should not fail in that
>> case, instead those recipes should just be skipped.

Rebased and applied to the 'next'.


Maxim.

>> Signed-off-by: Claudius Heine <ch@denx.de>
>> ---
>>   meta/classes/ubi-img.bbclass   | 2 +-
>>   meta/classes/ubifs-img.bbclass | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
>> index f61a940..777b8c4 100644
>> --- a/meta/classes/ubi-img.bbclass
>> +++ b/meta/classes/ubi-img.bbclass
>> @@ -5,7 +5,7 @@
>>   python() {
>>       if not d.getVar("UBINIZE_ARGS"):
>> -        bb.fatal("UBINIZE_ARGS must be set")
>> +        raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
>>   }
>>   UBINIZE_CFG ??= "ubinize.cfg"
>> diff --git a/meta/classes/ubifs-img.bbclass 
>> b/meta/classes/ubifs-img.bbclass
>> index ed37357..881d2bb 100644
>> --- a/meta/classes/ubifs-img.bbclass
>> +++ b/meta/classes/ubifs-img.bbclass
>> @@ -5,7 +5,7 @@
>>   python() {
>>       if not d.getVar("MKUBIFS_ARGS"):
>> -        bb.fatal("MKUBIFS_ARGS must be set")
>> +        raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
>>   }
>>   inherit image
>>
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

  reply	other threads:[~2019-04-25  5:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 15:41 [PATCH] " claudius.heine.ext
2019-03-27 15:45 ` Maxim Yu. Osipov
2019-03-27 17:10   ` Henning Schild
2019-03-27 17:12     ` Maxim Yu. Osipov
2019-03-28  7:50 ` [PATCH v2] " claudius.heine.ext
2019-04-24  8:48   ` Claudius Heine
2019-04-25  5:50     ` Maxim Yu. Osipov [this message]
2019-07-23 15:29       ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da09c7a2-9983-e059-8bfd-a401a42e21f2@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=ch@denx.de \
    --cc=claudius.heine.ext@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox