From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6673096226406137856 X-Received: by 2002:a1c:6a11:: with SMTP id f17mr800335wmc.38.1556171470183; Wed, 24 Apr 2019 22:51:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7e86:: with SMTP id z128ls2509679wmc.4.canary-gmail; Wed, 24 Apr 2019 22:51:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqxrjU2YQCwaxKAc6z1MqWDkBO2gdYLzkdeC4xD7NYxoyr/B/MwI5JvtwgtnkbLKjVcwtkjv X-Received: by 2002:a05:600c:2198:: with SMTP id e24mr2034035wme.16.1556171469727; Wed, 24 Apr 2019 22:51:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556171469; cv=none; d=google.com; s=arc-20160816; b=m8JxHZeGLpjH4mSsHsiVNobcqSMEakW8zmlEADoRTKPrU7SQxZOj45gs6ouyWkGkoo QcepIdn2kOhFlRiHipxg78WkSDm1D+I8zodu7jbHLz1hUOhskprQc1wkPFcx6hi8d3Cp dR9JYUq7qWTBWQtBOf/l4w6dPp8ce0nOefyyODqqblqS3hBQxT+Z18604zAd4iMzG8kr S95zdFeZcnk2lKHGP+zC6h8ydCHbrpZ6wZasUa4VrrA7yRpikA3KSaFwLSUV/DHhvsUo CQubaC9QT9TH1bO/aaeD9yzElEbmIWR13AY5y6gn3qDa1qzTK/A1+6qGEsz9WXJTEEAg 7xYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=p2bfn0PC7ViuG7KiW+1tpimP8ydEsUtQUgvOhLG3hgs=; b=aphaJOvOu4IAyVEXuyx5d8CKStPCYGym1QuZvoUvRxr1WDNwaQljXf/J7jyxe2zmIg 3cx6s4iAgZErNXZXh0ElcLjVhPhR433M33QJMD26focrR2fkdSD8qN3R6a1bQaILmdux fdkKTvo+8SvzgcC1BuBp/nokgzw0QsStZ8u1LInEirb107tjBch7lzt1IUZYNp9z42J7 0fjs0O6N0d6G/MvKoA5qKZ3On3aZ0bdzkSOnPzHadR8Q7kNk8jR9D/r4acBO6Tw9t4OO N/Qggr/eQzOOIirdIO3MBZQZ6WeAbaIGgblwi4ErkqpshEga6qja+bLt3IUs0vl615Px IsrA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id t17si1167925wri.5.2019.04.24.22.51.09 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 22:51:09 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x3P5p3BQ008264 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2019 07:51:05 +0200 Subject: Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe To: Claudius Heine , isar-users@googlegroups.com Cc: Claudius Heine References: <20190327154124.14663-1-claudius.heine.ext@siemens.com> <20190328075022.29511-1-claudius.heine.ext@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Thu, 25 Apr 2019 08:50:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: LSqfhCsDo2gm On 4/24/19 10:48 AM, Claudius Heine wrote: > ping > > On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote: >> From: Claudius Heine >> >> In machines that have not set those variables, it is still possible that >> those classes are parsed. The parsing itself should not fail in that >> case, instead those recipes should just be skipped. Rebased and applied to the 'next'. Maxim. >> Signed-off-by: Claudius Heine >> --- >>   meta/classes/ubi-img.bbclass   | 2 +- >>   meta/classes/ubifs-img.bbclass | 2 +- >>   2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass >> index f61a940..777b8c4 100644 >> --- a/meta/classes/ubi-img.bbclass >> +++ b/meta/classes/ubi-img.bbclass >> @@ -5,7 +5,7 @@ >>   python() { >>       if not d.getVar("UBINIZE_ARGS"): >> -        bb.fatal("UBINIZE_ARGS must be set") >> +        raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set") >>   } >>   UBINIZE_CFG ??= "ubinize.cfg" >> diff --git a/meta/classes/ubifs-img.bbclass >> b/meta/classes/ubifs-img.bbclass >> index ed37357..881d2bb 100644 >> --- a/meta/classes/ubifs-img.bbclass >> +++ b/meta/classes/ubifs-img.bbclass >> @@ -5,7 +5,7 @@ >>   python() { >>       if not d.getVar("MKUBIFS_ARGS"): >> -        bb.fatal("MKUBIFS_ARGS must be set") >> +        raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set") >>   } >>   inherit image >> > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov