From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6779570958446362624 X-Received: by 2002:a05:6512:4c6:: with SMTP id w6mr8788877lfq.157.1578906149025; Mon, 13 Jan 2020 01:02:29 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:1051:: with SMTP id x17ls1443819ljm.8.gmail; Mon, 13 Jan 2020 01:02:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzmUA/m2ua6kJz4yku7aUm3st22pMMjmnwefYIOxiBOugzMPFJ2czOSlfO7LKelM/LCU1Dp X-Received: by 2002:a2e:8e85:: with SMTP id z5mr10168360ljk.212.1578906148461; Mon, 13 Jan 2020 01:02:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578906148; cv=none; d=google.com; s=arc-20160816; b=DEgpTpY6HoBYdb78MRvBqs4fzpGmKGuv28KSKCap+xQvvnin9pWOFRozscifbXZ3jf tFIlsnuLz+ClzVIAgzd79ff/HMvIGxtvj7zdmr2AbzHNbQ9C/0RBO0dRsZeRtft7pyVI OCTKAT1i9aPj/aPzxGHyvkT8mJTi3JVDK8QtVNkksPolhMvSJethoqOWZ5b0dX7Ix9AW q91lelXCHF6Kh0kXMbwkx7VShMCZgKWW7JOExV7r9mIGoqzq8WQx2LtsdMn7Be7fxYpN HWRF6nn/7sZZNjPMkz9lkxXMoZgV14d82SIXVapNLxF72xetorfek/JyMVIfS6A/9c+3 sExw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=CwKhWOpawrRw9bHVR1KkrULJF2vX8MaP6LVOKdrFAT4=; b=yGIHq99VtCP5HPWhkNgHLJB47WuVZ2fEUjRGc2mavrFB7IocBVgzecT4NbC8cfYzh+ 2k4XRj/FusGk59N53TfJujLNBk1mXNiv3O7kyWfVQ1uQRXIMTJpr7WYTZFR6QUMTUEkf 05Tp1QP7/f20qEJNk4ywUndzOR80ZHnUv5kUkqEWq+tRkgF1YWWUT4Ngb2BI7ePVXzf3 s934oDtTpaNk3imfqMEuhxOfxe2b5NqgXWO7tdFtGtHPgT8JbMGwm8Q6PPsFnGFfdJWG 6ByW0MGDxpu8iz1p0/pHpbvUMeUAvqW3/rtyQupqxjE7lP0Fv5QjaWXEPOlXz8UO1IrX lwgQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id a4si314131lfg.1.2020.01.13.01.02.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jan 2020 01:02:28 -0800 (PST) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 00D92Rjt015678 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 13 Jan 2020 10:02:27 +0100 Received: from [139.25.69.120] ([139.25.69.120]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 00D92RD4027238; Mon, 13 Jan 2020 10:02:27 +0100 Subject: Re: [PATCH] linux-custom: add path to image for arm* kernels < 4.12 To: Jan Kiszka , isar-users@googlegroups.com References: <20200108135706.25834-1-Quirin.Gylstorff@siemens.com> <61f46f4a-0100-0ae1-f855-f3fdbffaf112@siemens.com> From: Gylstorff Quirin Message-ID: Date: Mon, 13 Jan 2020 10:01:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <61f46f4a-0100-0ae1-f855-f3fdbffaf112@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: u4FEOOMigY44 On 1/10/20 7:49 PM, Jan Kiszka wrote: > On 08.01.20 14:57, [ext] Q. Gylstorff wrote: >> From: Quirin Gylstorff >> >> ARM/ARM64 Kernel with a version < 4.12 do not contain the path to >> the kernel image in image_name. This was added with commits: >> 152e6744ebfc8fa6cc9fff4ba36271f5f1ba2821 for arm and >> 06995804b5762f016c7a80503406da853a8f3785 for arm64. >> >> Signed-off-by: Quirin Gylstorff >> --- >>   meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 7 ++++++- >>   1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> index 67b7ce3..ac347aa 100644 >> --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> @@ -56,7 +56,12 @@ EOF >>   install_image() { >>       install -m 755 -d ${deb_img_dir}/$(dirname ${kimage_path}) >> -    cp ${O}/${kimage} ${deb_img_dir}/${kimage_path} >> +    # ARM/ARM64 kernels < 4.12 do not include the path to the kernel >> +    if [ -e ${O}/${kimage} ]; then >> +        cp ${O}/${kimage} ${deb_img_dir}/${kimage_path} >> +    else >> +        cp ${O}/arch/$ARCH/boot/${kimage} ${deb_img_dir}/${kimage_path} >> +    fi > > Maybe better expand (i.e. redefine) kimage when ${O}/${kimage} doesn't > exist, rather than duplicating the copy operation. I tried to stay near the 4.11 implementation of linux/scripts/package/builddeb[0] line 145. But I will change it to a redefinition. > > Jan > >>       # Make sure arm64 kernels are decompressed >>       if [ "${ARCH}" = "arm64" ]; then >> > [0]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/scripts/package/builddeb?id=152b695d74376bfe55cd2a6265ccc75b0d39dd19 Quirin