From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6950664923339816960 X-Received: by 2002:a1c:3c05:: with SMTP id j5mr720107wma.61.1618329930900; Tue, 13 Apr 2021 09:05:30 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6c6a:: with SMTP id r10ls4348584wrz.0.gmail; Tue, 13 Apr 2021 09:05:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvDe9Auj/5+mzW9uEyhvFS0Abe5sp31h38EvEQo2HuaDv/YMazCC2EDHChQbG5mODRx/TJ X-Received: by 2002:adf:bbd2:: with SMTP id z18mr13563016wrg.274.1618329928916; Tue, 13 Apr 2021 09:05:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618329928; cv=none; d=google.com; s=arc-20160816; b=RuWAgPwFyah3Rq6HM+rWSemBoh0Hw+uchrdOAcACOcElCNTkL00exNR7zwNalvjm2J 7+Sa/g5W9uQpu5voWPeeZOyQwKSt0mZvyOJzgG9gYTQpHwYKhxRDRBxiNejpx4NaUUje Ax8gtW2fOL55KrjaIZJOFszftgrU1CcKulU2a8oAAzA2/cp0C7TYmjgttZAS19QteNi8 8R73bb6mmofNT+YOTuxpKEFGFpvC0EOIhy6hRqXfWYQPkwX4MMotBsUVX50c8Ihm34ay RxoyLA1Uo3rzJDvY9vQDjZ7MBkkWE9+4IqZvC9rTsoqR+qaq+Gn1Ch0lmerF0UqTg8cG EoYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=1r9UhrL1n6apMyM017BJItqhAoFcXK5kRcgZieyIsCg=; b=RTPFnrBkAnN1WG2yJIdScaDCBrXF4j2OUAIXTe4iVl00jMIAcyPqs8iWroSel5lEM+ kU05EudxNGzrXGO61wGfw4QDDgpOG2jYR7rAWC/XhKMXia7Gz3zAnbj79NiQ0Vcl4mE+ E+L9a2HmWM10gwOh+sB/jcG90mPaLIH62S7EdA6ADHv6kiTHfgsxz9Exe1Dcsys41szV j/SB6BudDSpp056Gt4WUcwyVRRVrGtHGuZGcoVcG2IiEC8OS9ti0jHUSfX2R3mkt12k/ E23WkZseW5NNJU9+/qAOE0exmi1mfpK5z3usJdc0Bieg5mLiFqMz2NgDGnfZxCMb08Lk 4SYw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id x16si156273wmi.1.2021.04.13.09.05.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Apr 2021 09:05:28 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 13DG5S4f022184 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 13 Apr 2021 18:05:28 +0200 Received: from [167.87.46.221] ([167.87.46.221]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 13DG1okJ022179; Tue, 13 Apr 2021 18:01:51 +0200 Subject: Re: [PATCH] fix: remove unneeded unconditional recipes To: "[ext] Silvano Cirujano Cuesta" , isar-users@googlegroups.com References: <20210413152607.201401-1-silvano.cirujano-cuesta@siemens.com> From: Jan Kiszka Message-ID: Date: Tue, 13 Apr 2021 18:01:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210413152607.201401-1-silvano.cirujano-cuesta@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: lrGQubGB6udC On 13.04.21 17:26, [ext] Silvano Cirujano Cuesta wrote: > Commit 9c3499adf91 introduced the unconditional inclusion of the recipes > isar-exclude-docs and isar-disable-apt-cache, but they are only needed > for container images. > In fact, are those packages truly needed or just desirable, reasonable defaults? In any case, it might be worth documenting those defaults as well. They can be overwritten (IMAGE_INSTALL_remove), but the users should be made aware of them. Jan > Signed-off-by: Silvano Cirujano Cuesta > --- > meta/classes/container-img.bbclass | 2 ++ > meta/classes/image-container-extension.bbclass | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/container-img.bbclass b/meta/classes/container-img.bbclass > index 79ef3e8..887d49e 100644 > --- a/meta/classes/container-img.bbclass > +++ b/meta/classes/container-img.bbclass > @@ -6,6 +6,8 @@ > # This class provides the task 'containerize_rootfs' > # to create container images containing the target rootfs. > > +IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache" > + > do_container_image[stamp-extra-info] = "${DISTRO}-${MACHINE}" > do_container_image[vardeps] += "CONTAINER_FORMATS" > do_container_image(){ > diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass > index f693627..e26604a 100644 > --- a/meta/classes/image-container-extension.bbclass > +++ b/meta/classes/image-container-extension.bbclass > @@ -6,7 +6,6 @@ > # This class extends the image.bbclass for containerizing the root filesystem. > > CONTAINER_FORMATS ?= "docker-archive" > -IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache" > > containerize_rootfs() { > local cmd="/bin/dash" > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux