public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: Re: [PATCH] classes/sdk.bbclass: remove additional "/" in new_target finding
Date: Tue, 11 Jul 2023 09:40:00 +0300	[thread overview]
Message-ID: <daee0c8eb1974dd5c0a960d610b34f030ef20496.camel@ilbers.de> (raw)
In-Reply-To: <20230704102416.2646313-1-srinuvasan_a@mentor.com>

On Tue, 2023-07-04 at 15:54 +0530, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> We observed that one additional / present in finding the new_target,
> here target already start with /, hence no need to append the
> additional
> /.
> 
> In functionality wise there is no change.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/sdk.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index c6dc689..3d650a1 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -98,9 +98,10 @@ sdkchroot_finalize() {
>      for link in $(find ${ROOTFSDIR}/ -type l); do
>          target=$(readlink $link)
>  
> +        # Enter into if condition if target has a leading /
>          if [ "${target#/}" != "${target}" ]; then
>              basedir=$(dirname $link)
> -            new_target=$(realpath --no-symlinks -m --relative-
> to=$basedir ${ROOTFSDIR}/${target})
> +            new_target=$(realpath --no-symlinks -m --relative-
> to=$basedir ${ROOTFSDIR}${target})
>  
>              # remove first to allow rewriting directory links
>              sudo rm $link
> -- 
> 2.34.1
> 

Applied to next, thanks.

  reply	other threads:[~2023-07-11  6:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 10:24 Srinuvasan Arjunan
2023-07-11  6:40 ` Uladzimir Bely [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-28  5:19 Srinuvasan Arjunan
2023-06-28  7:12 ` Jan Kiszka
2023-07-03  7:07   ` Srinuvasan Arjunan
2023-07-03 10:59     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daee0c8eb1974dd5c0a960d610b34f030ef20496.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox