Re: [PATCH 01/16] meta: ext4-img: copy and keep attributes, always copy with sudo

[Alexander Smirnov <asmirnov@ilbers.de>]

On 10/19/2017 09:04 PM, Henning Schild wrote:
> I just wasted another hour on that guy ... again. Now i found an easy
> way to reproduce the issue
> 
> on amd64
> IMAGE_PREINSTALL += "dropbear"
> 
> Probably something in the package hooks, update-initramfs ... But who
> cares, that could have been fixed months ago.

Which file this does this problem affect: kernel or initrd?

>  > Since my original patch touches code that Alex is currently moving

The information you've provided above is very important, so I'd like to 
apply this as separate patch with respective commit message. Could do 
this tomorrow's morning.

> around i hope he will fix the issue that has been ignored for too long.
> 

According to the last our agreement in Aug, each issue should have 
usecase, so you've provided it only now.

Alex

> Henning
> 
> On Tue, 1 Aug 2017 12:17:19 +0200
> Henning Schild <henning.schild@siemens.com> wrote:
> 
>> Some security enhancing packages can cause our initrd to be not
>> readable by a normal user. So we need to copy with sudo.
>> Also regular cp would destroy ownership and other attributes of files,
>> possibly creating problems in the future.
>>
>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>> ---
>>   meta/classes/ext4-img.bbclass | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/classes/ext4-img.bbclass
>> b/meta/classes/ext4-img.bbclass index 65d4c11..6dc2039 100644
>> --- a/meta/classes/ext4-img.bbclass
>> +++ b/meta/classes/ext4-img.bbclass
>> @@ -21,16 +21,16 @@ do_ext4_image() {
>>   
>>       mkdir -p ${WORKDIR}/mnt
>>       sudo mount -o loop ${EXT4_IMAGE_FILE} ${WORKDIR}/mnt
>> -    sudo cp -r ${S}/* ${WORKDIR}/mnt
>> +    sudo cp -a ${S}/* ${WORKDIR}/mnt
>>       sudo umount ${WORKDIR}/mnt
>>       rm -r ${WORKDIR}/mnt
>>   
>>       if [ -n "${KERNEL_IMAGE}" ]; then
>> -        cp ${S}/boot/${KERNEL_IMAGE} ${DEPLOY_DIR_IMAGE}
>> +        sudo cp -a ${S}/boot/${KERNEL_IMAGE} ${DEPLOY_DIR_IMAGE}
>>       fi
>>   
>>       if [ -n "${INITRD_IMAGE}" ]; then
>> -        cp ${S}/boot/${INITRD_IMAGE} ${DEPLOY_DIR_IMAGE}
>> +        sudo cp -a ${S}/boot/${INITRD_IMAGE} ${DEPLOY_DIR_IMAGE}
>>       fi
>>   }
>>   
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov