From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:adf:e286:: with SMTP id v6mr8171519wri.340.1559678967859; Tue, 04 Jun 2019 13:09:27 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:f505:: with SMTP id t5ls32688wmh.0.canary-gmail; Tue, 04 Jun 2019 13:09:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzzC9gVWOCe7v9z6UJuEJWjhqleHTmUjVfD2FCirj2dnZdy8WvkTJ3SjDplEyjjz2c+Gle X-Received: by 2002:a1c:23c4:: with SMTP id j187mr19902749wmj.176.1559678967544; Tue, 04 Jun 2019 13:09:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559678967; cv=none; d=google.com; s=arc-20160816; b=Tdx6Dwb3U48stG4ToTJCkEtTHGPVPm4qHNPmog/U2MO9LquIf1WudFLNEwtpBK93x6 +w12JdMg3JRxcsbqAsuHL7ggNG2bZeDzGri+JXd6js7lEB8tPHPd8CoqMMFNgbLowiKq 8X3a64NtizZfKsKhATTcphFFpHmb9cGBTCGUBUyQtjbrOEVuSPpPMHatIG0quRCaLE33 c2yumQFdfkFQAvpU6H7SnPOaIbtgWVTmPDIlD6YoSJX2GXrpvw2GK3EfT5+niWfLl+Mm 6LB4pz1YK1YBj63UvAL1lice1lvtJxIU7P0vw61X1bp0KPNPqkSuelprawzySJw2q4Ca dL7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=HFLKayReTAdBglhGJS8W/Lhw2obWug6Qn9uVV1uLwrA=; b=M1lSBo7OZrR+v+sY4EwU6FWTGuypzOaw20i/vo3lO0NEQ9angz7qYDexdclBtK+8UR Q/py+MXVXCZVEFJxUbay4iTcSaV5/Lv1KSYV5XMfXridykX4b9fUmTWFTM6e0zndZsjW Uai/LzaUQwDS46hTQ/5EsWgRSe3sQNuHnBXpY3Sv1vEOnNTqKS1XCpJHCjrCOiN0RXu5 1iF++I5ULrv2nRF8pyOWnQpWNl/FAg+7v3RJxw/AcYYXxoeM2WEl/faZ+8OdD0TwCZ5H jjM8k2vugYQU3yR9KD1QrTjWgiVvn9Yli/N2Dw2uaYK4p8r3huaq9Vgxn1MlVBfEs6JY 5Y0Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@isar-build.org designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@isar-build.org Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id x3si184020wmh.4.2019.06.04.13.09.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jun 2019 13:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@isar-build.org designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@isar-build.org designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@isar-build.org Received: from [192.168.1.29] (195.165-131-109.adsl-dyn.isp.belgacom.be [109.131.165.195] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x54K9ItT029945 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 4 Jun 2019 22:09:20 +0200 Subject: Re: [PATCH 0/3] Filesystem mounting and machine-id fix To: claudius.heine.ext@siemens.com, isar-users@googlegroups.com Cc: Claudius Heine References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> From: "Maxim Yu. Osipov" Message-ID: Date: Tue, 4 Jun 2019 22:09:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190528085814.12967-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 7e43nKsVL480 Hi Claudius, Regarding machine-id patch - I may apply it (with adding Reported-by: Matthias Lüscher ). As for the two first ones - could you please provide a feedback on the last email from Henning in this thread (see below): Regards, Maxim. -------- Forwarded Message -------- Subject: Re: [PATCH 2/3] image.bbclass: remove fstab generation Date: Wed, 29 May 2019 13:11:59 +0200 From: Henning Schild To: Claudius Heine CC: isar-users@googlegroups.com, Claudius Heine Am Wed, 29 May 2019 08:47:39 +0200 schrieb Claudius Heine : > On 28/05/2019 19.34, Henning Schild wrote: > > Systemd might be default, but is not guaranteed to be installed on a > > working and officially supported debian. > > > > Yes we do kind of need it at the moment (for very few features where > > other inits can be enabled as needed). But we would at least see a > > conflict. I.e ssh-key-regen is pulling systemd while someone else is > > pulling sysvinit. > > > > With this patch we might create non-bootable images, which is not > > OK. > > I would like to support any init system that debian supports as well, > but I currently don't have any project that does not use systemd with > isar, so for me there is currently no use case. > > But if you would implement a test case for SysV in meta-isar, then I > could try to find a solution that works with SysV as well as systemd > or any other init system we have a test case for (if the workload is > at a manageable level). As is currently stands though we only test > systemd and therefor officially only support that in isar. You are saying it is ok to break a feature because we currently have no testcase that would detect the problem? The testcase is really simple, but including it into Isar will grow or CI even further. For a corner-case. So i would not add a test-case to keep CI clean of such a corner-case. The compromise is to manually test the corner-case when introducing patches that potentially break it. And the test is pretty easy IMAGE_PREINSTALL += "sysvinit-core" and make sure nothing pulls in systemd to replace that guy again. Henning On 5/28/19 10:58 AM, claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Hi, > > here is a small patchset that removes the fstab and the machine-id file. > > The fstab generation is much to inflexible and in its current form unnecessary. > If it comes back in the future, then we should think about a good user API. > > As a result of the removal, I added a few 'rw' kernel arguments to the meta-isar > wks files. I haven't touched the wks files from `scripts` yet, because I don't > really know how/if those scripts are used downstream and would like an input > from the community about this. When I use wic, I tend to write custom wks files. > > The machine-id removal is pretty simple and systemd will recreate it on first > boot, but that requires a rw /etc directory. (Some exceptions possible, see > systemd-machine-id-commit.service(8).) > > The machine-id patch can be applied without the first two patches. > > regards, > Claudius > > Claudius Heine (3): > wks: added 'rw' to kernel arguments > image.bbclass: remove fstab generation > image-postproc-extension: add removal of machine-id > > .../scripts/lib/wic/canned-wks/bananapi.wks | 2 +- > .../lib/wic/canned-wks/directdisk-isar.wks | 2 +- > .../scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +- > meta/classes/image-postproc-extension.bbclass | 11 +++++++++-- > meta/classes/image.bbclass | 16 ---------------- > 5 files changed, 12 insertions(+), 21 deletions(-) >