public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Florian Bezdeka <florian.bezdeka@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH 2/2] Revert "events: Do not warn on left mounts by default"
Date: Thu, 3 Oct 2024 09:25:16 +0200	[thread overview]
Message-ID: <dc07e5ec-bc42-4b94-918c-dee3dc4b984f@siemens.com> (raw)
In-Reply-To: <20241002203156.149572-3-florian.bezdeka@siemens.com>

On 02.10.24 22:31, 'Florian Bezdeka' via isar-users wrote:
> This reverts commit 72ec986d9cd3a3913e8592554456d5968d6b659a.
> 

This needs reasoning why the original motivation for this change no
longer applies or was wrong.

Jan

> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
>  meta/classes/isar-events.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
> index f5061a8b..77dfecee 100644
> --- a/meta/classes/isar-events.bbclass
> +++ b/meta/classes/isar-events.bbclass
> @@ -53,7 +53,7 @@ python build_completed() {
>      with open('/proc/mounts') as f:
>          for line in f.readlines():
>              if basepath in line:
> -                bb.debug(1, '%s left mounted, unmounting...' % line.split()[1])
> +                bb.warn('%s left mounted, unmounting...' % line.split()[1])
>                  subprocess.call(
>                      ["sudo", "umount", line.split()[1]],
>                      stdout=subprocess.DEVNULL,

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/dc07e5ec-bc42-4b94-918c-dee3dc4b984f%40siemens.com.

  reply	other threads:[~2024-10-03  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 20:31 [PATCH 0/2] Fix leftover mounts in rootfs.bbclass 'Florian Bezdeka' via isar-users
2024-10-02 20:31 ` [PATCH 1/2] rootfs: Add missing umounts in rootfs_postprocess() and rootfs_install() 'Florian Bezdeka' via isar-users
2024-10-02 20:31 ` [PATCH 2/2] Revert "events: Do not warn on left mounts by default" 'Florian Bezdeka' via isar-users
2024-10-03  7:25   ` 'Jan Kiszka' via isar-users [this message]
2024-10-03  7:42     ` Anton Mikanovich
2024-10-10  4:33       ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc07e5ec-bc42-4b94-918c-dee3dc4b984f@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox