Re: [PATCH 3/4] sbuild-chroot: Pre-install cross-compiler and libc6-dev

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

On Mon, 2023-01-09 at 06:32 +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This saves build setup time by pre-installing not only build-
> essential
> but - for cross and compat-arch cases - also the cross-compiler as
> well
> as libc6-dev.
> 
> The latter is coming via build-essential in the native case, it's not
> installed by crossbuild-essential but sbuild is pulling it. We can
> install libc6-dev:${DISTRO_ARCH} unconditionally as this becomes a
> not
> in the native case.
> 
> Things brings sbuild on eye-level with buildchroot regarding the
> initial
> build environment, even goes beyond as buildchroot used to install
> only
> libc6:<target-arch>.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  .../sbuild-chroot/sbuild-chroot-host.bb               | 11
> +++++++++++
>  .../sbuild-chroot/sbuild-chroot-target.bb             |  4 ++++
>  meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc | 10 ++++++---
> -
>  3 files changed, 21 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-
> host.bb b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> index a37e49b7..c0015721 100644
> --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> @@ -12,3 +12,14 @@ require sbuild-chroot.inc
>  ROOTFS_ARCH = "${HOST_ARCH}"
>  ROOTFS_DISTRO = "${HOST_DISTRO}"
>  ROOTFS_BASE_DISTRO = "${HOST_BASE_DISTRO}"
> +
> +SBUILD_CHROOT_PREINSTALL ?= " \
> +    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
> +    crossbuild-essential-${DISTRO_ARCH} \

I proposed this a couple of month ago in
"[PATCH] install crossbuild-essential into base schroot"

In the end, it was rejected after having some build failures in risc64.

Citing Anton:

[...]

> I've just checked mc:qemuriscv64-sid-ports:isar-image-base target
manually and it fails with:
> | E: Unable to locate package crossbuild-essential-riscv64
> on do_rootfs_install task of sbuild-chroot-host recipe, which was
predictable.
> It was not failed on CI because of KFAIL on Sid-Ports targets (they
are not stable enough).
> Overall preinstalling is good idea and will improve building speed,
but we should implement it in the right way.

In case this is solved by your series, I really appreciate to have it
integrated.

Felix


> +    "
> +
> +SBUILD_CHROOT_PREINSTALL_riscv64 ?= " \
> +    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
> +    gcc-riscv64-linux-gnu \
> +    g++-riscv64-linux-gnu \
> +    dpkg-cross"
> diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-
> target.bb b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-
> target.bb
> index d75d783b..8f2da720 100644
> --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-target.bb
> +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-target.bb
> @@ -8,3 +8,7 @@ DESCRIPTION = "Isar sbuild/schroot filesystem for
> target"
>  SBUILD_VARIANT = "target"
>  
>  require sbuild-chroot.inc
> +
> +SBUILD_CHROOT_PREINSTALL ?= " \
> +    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
> +    "
> diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> index fa4a295c..08a2d55d 100644
> --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> @@ -10,7 +10,13 @@ PV = "1.0"
>  
>  inherit rootfs
>  
> +SBUILD_CHROOT_COMPAT_PREINSTALL_compat-arch = " \
> +    libc6-dev:${COMPAT_DISTRO_ARCH} \
> +    crossbuild-essential-${COMPAT_DISTRO_ARCH}"
> +
>  SBUILD_CHROOT_PREINSTALL_COMMON = " \
> +    ${SBUILD_CHROOT_COMPAT_PREINSTALL} \
> +    libc6-dev:${DISTRO_ARCH} \
>      fakeroot \
>      build-essential \
>      debhelper \
> @@ -19,10 +25,6 @@ SBUILD_CHROOT_PREINSTALL_COMMON = " \
>      equivs \
>  "
>  
> -SBUILD_CHROOT_PREINSTALL ?= " \
> -    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
> -"
> -
>  SBUILD_CHROOT_DIR = "${WORKDIR}/rootfs"
>  ROOTFSDIR = "${SBUILD_CHROOT_DIR}"
>  ROOTFS_PACKAGES = "${SBUILD_CHROOT_PREINSTALL}"
> -- 
> 2.35.3
>