From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6517147827419742208 X-Received: by 10.36.53.14 with SMTP id k14mr23529915ita.14.1517397165147; Wed, 31 Jan 2018 03:12:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.169.156 with SMTP id f28ls1192646ioj.19.gmail; Wed, 31 Jan 2018 03:12:44 -0800 (PST) X-Google-Smtp-Source: AH8x227lvaIsN0QZ3iSUIblNwstK27OQc2d4aiGuwVgO++sNIvYKRXzah6PsdzFB9C5TQtIJDSJ9 X-Received: by 10.107.198.3 with SMTP id w3mr22046578iof.49.1517397164713; Wed, 31 Jan 2018 03:12:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517397164; cv=none; d=google.com; s=arc-20160816; b=OkjxS2rvLLvkZEfNCZHmjDjwyN3MeyRjqNOAFfB615oDRIIOTHnKuADBtKLocpisVL vIvzGHNaYG2qV+T1oVvCjn3o0N8xO0DYvIXYx8q2nTtY1WTghzrtE0zOMMs5ltfTt6qr 5uy8sGDVVjHNokc3kf/BmJAHqZDy1SVoc7LCeXpXVbHmrRkjQy2Qgtz35Rsn1UEJP864 3vFOZvFvQiLv7SQHikOtmo76y/gOObF5ZgrdJBT1KNtu0WDI68ERJ4hBvMGrFAtEeyTx 6NAAU5ukVZarI8dilrzMYxYCH5zhVnbpPd/oNlMtsD7CS3sSG0eOd+nRrzUeXO+SSkwl ivEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=vMLq+IwByBNDZ7c5lE/3ZFjoStv2hUJ+mjm2KfCR7cU=; b=LYBEHDv3NWmbFXfcjvTjDE0B+RbkwP19e3/2vAQ2Iqgl4gaP782ab3sbtRlnZKs0Ap p5w0tGYDfdtIjuxizITCOGf76Y93XnlkAxZp6GwvNjSyx9ZecPlcH0pUmZZ7VCMIUN9y hvdhHqpjUWe+At6qvu4OIuhWd6mYjXDJkCfJlS2XTNRBHKYtsLLh5EBjqFl6wLZNKQKF gj0B74jvXQiJG0AGYxKFIIWhkDsiRfJdaGWhsnWJqXIohRCko4OGc/OoIhu+JBPkTBjE NnjqR/eHqqgoG8k8MqXsuAAM0UarmzNwFnkp0C9lAV7vxrbr4TrU/UpvHPWwwgUMUwDd 38EA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id e185si1211845itb.1.2018.01.31.03.12.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 03:12:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w0VBBXBC008038 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 31 Jan 2018 12:11:35 +0100 Subject: Re: [PATCH 9/9] wic: now truly go for the wic version we claim to have To: Jan Kiszka , isar-users@googlegroups.com References: <540bb04ce24f67c121c83801288a3aea6f4cedac.1517390790.git.henning.schild@siemens.com> <9882db52-7c2e-d135-2ca5-13c5b9a722a7@siemens.com> From: Alexander Smirnov Message-ID: Date: Wed, 31 Jan 2018 14:11:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <9882db52-7c2e-d135-2ca5-13c5b9a722a7@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: IRjv6lCUqEf5 On 01/31/2018 01:55 PM, Jan Kiszka wrote: > On 2018-01-31 11:11, Alexander Smirnov wrote: >> On 01/31/2018 12:42 PM, Henning Schild wrote: >>> 2b164b18fd639c9 claims to introduce wic hash 131629ca6238ea05 >>> This commit really carries that version of wic. >>> >>> Issue: >>>   - the wic version in Isar was modified >>>   - that causes: >>>    - confusion, maintainability and updateability issues >>>    - potential quality issues >>> >>> Impact: >>>   This patch and the previous reverts get wic back to a state where all >>>   these Issues are solved. We could now just update our wic without >>> having >>>   to worry about local patches. In case of a wic-update Isar and layers >>>   on top would still have to review their plugins. >> >> Does upstream wic script rely on the content from lib/plugins? >> >> For example some recent commit updates both: >> >> https://github.com/openembedded/openembedded-core/commit/00420ec42140c1b752132bda190dede85756d157#diff-df4a70bc146d3159891d7a410f2521a1 >> >> >> So due to customized plugins below we should worry and keep this in mind. > > Sure, we have to keep an eye on wic<->plugin API changes when updating > wic to the next upstream version. Nothing new, though, when you write > plugins for wic (like we do for firmware update mechanisms, also over > Yocto). This patch claims that the wic maintenance becomes easier. What is the idea of this claim? Wic is based on both: 'scripts/wic' and 'lib/wic', they don't work without each other. Whole this series performs migration of changes from 'scripts/wic' to 'lib/wic', so eventually there is no unmodified upstream wic support, the only script stays unmodified while plugins are patched. So I'm a bit confused, what is the core difference with existing approach, and how this approach fixes maintainability and updateability issues? Alex