Re: [PATCH 1/3] mount: Add unmount requirement to API changelog

[Jan Kiszka <jan.kiszka@siemens.com>]

On 30.06.21 13:35, Anton Mikanovich wrote:
> After the latest mount rebuild any usage of mount functions should be
> ended with the following unmount call.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  RECIPE-API-CHANGELOG.md | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index 806c291..546d91c 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -292,3 +292,24 @@ Migrate your patches so they can be applied with "git am", or
>  
>  Kernel image name for arm64 platforms is vmlinux now. Image format was
>  not changed (uncompressed executable) but now it is named correctly.
> +
> +### Make unmounting mandatory
> +
> +There were mount API to provide some path inside chroots:
> +```
> +dpkg_do_mounts
> +buildchroot_do_mounts
> +image_do_mounts
> +rootfs_do_mounts
> +```
> +
> +From now those calls should be always followed by unmount actions:
> +
> +```
> +dpkg_undo_mounts
> +buildchroot_undo_mounts
> +image_undo_mounts
> +rootfs_undo_mounts
> +```
> +
> +It case any unmounted paths left at the end of build warnings will be thrown.
> 

That's only one part of the story:

dpkg_do_mounts, e.g., used to be a shell function. Now it's a python
function. So,

do_my_task() {
    dpkg_do_mounts
    sudo chroot ...
    dpkg_undo_mounts
}

like in [1] no longer works and requires to factor the shell part and
rewrite the main task in python.

BTW, [1] already followed that pattern, so it's not really a new thing.

Jan

[1] https://github.com/siemens/meta-iot2050/blob/master/classes/npm.bbclass

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux