From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 25 Mar 2025 17:57:59 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-il1-f183.google.com (mail-il1-f183.google.com [209.85.166.183]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 52PGvvxw028600 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Mar 2025 17:57:58 +0100 Received: by mail-il1-f183.google.com with SMTP id e9e14a558f8ab-3d2a40e470fsf45253225ab.3 for ; Tue, 25 Mar 2025 09:57:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1742921872; cv=pass; d=google.com; s=arc-20240605; b=lMvsTJMBdvdrzWP8zDJ+hg1iU9v1Pi8jL1RNISuDbdrGIkZW1LjBso9/D089gBTuBn FCv5euvQ7hikpAK1ZFjIPXB2cyqSw9IfH59T7zJPJ4XkluM2FNGrlCs9FABuEQtugJEj s30ABWqtrlCG+ZefA0i7Zzh5IHJkVP1wFT/c96etw9nMOrsI7dMIo3rlKSl02HMsDuZj wOpfvdd96j8syKQHcipr0UIzLvDfHWsstL9gMe7jb6cJ6DIvaxfaAS1cwd4aGAHO/DC0 ShISuRouQ1QW/ZBEDdj3NrwW/zqPOEWSjta6YOSasL398OKQ27j83D+AsQwrUv1604V4 Yw/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:autocrypt:references:in-reply-to:date:to :from:subject:message-id:sender:dkim-signature; bh=nsPpGyBF8oRUZRuY+ZZjEsVvfr/cCeiWiQ7k4ttgC6U=; fh=MK0LZtR+P04uqbcZiuXFFJGqCqDFlJq5GEmNJBQTj0M=; b=MiMnysQURvHU4Hr2DJ47S/5tKABECVFaQamab77k3NGHX4cqP/NMZgI41e954KF6pj sqsMw1NxpbnxRcRqAG++Z7FNgueWzQKr9D80sMpLvaRzAqsV5ZzCqMNrZWzggmHwZ480 N6JopkUxdO7M7NCXwWClFRhzg0kSUaywAW7GatnQi7cJuJMwCReM+DarhwysrZCik880 /aT6nVkHvzN3Z3rKs0+BIONvpKEJoPe+gATPZ/BF18orwN2vQNTyNKm4EYLfS5n3zG4G eCkwz5Q2XOfCyop/m/RYPkYjoP5vTjacdcksVcEYbWRwguklv1vY9/rN1vClaNvpTtdq hseQ==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1742921872; x=1743526672; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :autocrypt:references:in-reply-to:date:to:from:subject:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=nsPpGyBF8oRUZRuY+ZZjEsVvfr/cCeiWiQ7k4ttgC6U=; b=SBXCDukDGOc4KSYhySrLVthsDiHGF4UhXqeU4OCTjrKSsBEOlG5yPdvXQvcqeQFUUx o5ysPsHLGGTE5gkPv7wrQO+wWpdOcpkQG7qevgB9JxkO7d5wZOCYNgyTocRjdvSTx9a8 Kel4agBaudb3QFWjucSNd9E4qEU/+xVkhwGwVWC1HlRpyZdlfkl9HC+owwfF382TiQIw l/9Ia+zEIBOCUPDjshcFYvC9tPx7Jc5PHLz3m/aaTP7Rttx+343Zs+7HQhiyJDgmAbE0 TMZAKEHRgSmAKrKgM7vsjEWI+GoHoEr9yp6rw/NoqjqTlozTIUHuFaC8BoYgPKJ8Yup4 HW8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742921872; x=1743526672; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:to:from:subject:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=nsPpGyBF8oRUZRuY+ZZjEsVvfr/cCeiWiQ7k4ttgC6U=; b=l/GMMF30nwWhYVutbMbQ+rJo4Of3I7ODKxSsgAIBqGURL9P9LGGO1afHW/o91O8rMO SFasGR5tRwpjV5CAThylw60mbkXihy6/aokb2fp4hWE1fyIUi43wW7Fv8ecHDwRrVRkg DxdKYTefv2OrF2xSvpQxvwfiHsrxHIMXrdXahD8J2AK37PufE7c4GEdbW434St8474ZY GUG/lniv0t60H4SVZzPRwv9lRjgU7KevG8XBpKetp4Xs/m6yCj8gbLYghSdNrOOsFJ5p hOvI3uliWjwYxk6EQiv/9xBv9JhRZLpILxhrVFZu6ylgFaqHdEnobc57IdxCJMLU/vhM jAGg== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCXKhrAezW1M/QHzf3lm1kgSX4Bl/74WFWcsUsPwj58IYD7BkLX8a2JNbQdwd6whRBmwW4Dt@ilbers.de X-Gm-Message-State: AOJu0Yz6uG7AZlaZ/MfgaXVU7ZD3ZSyP0nPhry2NgU953YbKckFwAqmq pFfKgmWfDgzZ59Yty4lFreKRKZ9nisNm2ZbPj5zSO8uLGS/idU6L X-Google-Smtp-Source: AGHT+IEZ/K7ahjzy9fOeKK582E061wbCsPBbesaRjdETYJ+ODlarKHLRmRxBe/00g+PIotwOzvdS8w== X-Received: by 2002:a05:6e02:1c26:b0:3d4:6f37:3724 with SMTP id e9e14a558f8ab-3d59616b924mr197835115ab.18.1742921871844; Tue, 25 Mar 2025 09:57:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=ARLLPALBmBkTygyi/Dv2ZpbJxB+SOZb/i7NgD7VtfQvQYAfrVg== Received: by 2002:a05:6e02:2190:b0:3d4:5121:3550 with SMTP id e9e14a558f8ab-3d594f0e617ls3722435ab.1.-pod-prod-07-us; Tue, 25 Mar 2025 09:57:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVyPVfel9Qf5hI6gk74duHBgW2LyoykVOstQeuDcDtXBkF1uBqN/IZOVcSedi4cmjIg9uOGW/d883wG@googlegroups.com X-Received: by 2002:a05:6e02:3b46:b0:3d5:817d:6462 with SMTP id e9e14a558f8ab-3d5960d112cmr175673435ab.5.1742921870823; Tue, 25 Mar 2025 09:57:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742921870; cv=none; d=google.com; s=arc-20240605; b=QHPWHW/rUaPUc0/mmCUBkMam0PA0j8GKjGXdMRAf30wXBchMAwK4JkWcjeb8lWe2JV J4SPIWRJX+z5z3bJG8SSJzLV9TQkny0FMXjWyQ0xhYh0cP6Z3Juw7mfo8yudOCYTgcsE YhqCroVm9vvUxSB/VSdq1/FNuTwHJphnDw8W7rXnrJIYoAQq6vbRW8IpxwtUEijYZZC3 NA9lySNbH1TlutQbpuMbSS54gBWp4JaGXCbH/J3ZGqRfQrn2muuBLHGk5yaWKWUk0351 5jsyPsvYOdLWLVGXmBrsghd3dElY5u153j21aFH+GWflbda53FUWO4OnLVBiFebAlmZl ErDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id; bh=MS0dD1lz1jjIqHMvu4m3zWNAwDzl9PUQ4alyst2hql4=; fh=1x/T85rXr8yhgzXWAa7zssXnuyt2jGlhJYPIGFWr6UE=; b=Qvqm0TFJio7hL0Zsj+zkrhzS/Rw0M+OQTjZ3NxO5NdnHSU3Dg5VGrJiLx41QezP2yP 1nyFzPsbJnaOhqaMvaedn0WigBcr6WfEn2ef1aPpjn2M25SPdlEvfWmMICV0xpF/3Q6m nBWH7gpAxMA6fG+WAYRfZc3eWw08t9bb2DloOFM548sDhBKlW2pe/5LOmDdEa+wWJUh4 flcm8UIJn5U9wqVhqbmALAg8TCFJMTqR3+U4QzMI0mRCmrsP8rtoqR9Rdq4HmVR/+5WC zgsnpMOXCvMmJQD4/miomOPbMjYgoxilPOD06v/NQnWMiIFbxk6iayT/tZJAAKnPvtET dqEQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 8926c6da1cb9f-4f2cbda7c2bsi516753173.1.2025.03.25.09.57.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Mar 2025 09:57:50 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 52PGvlWV028586 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Mar 2025 17:57:48 +0100 Message-ID: Subject: Re: [PATCH] bootstrap: use only valid pairs in get_apt_source_mirror() From: Uladzimir Bely To: Cedric Hombourger , isar-users@googlegroups.com Date: Tue, 25 Mar 2025 19:57:47 +0300 In-Reply-To: <20250319064937.68881-1-cedric.hombourger@siemens.com> References: <20250319064937.68881-1-cedric.hombourger@siemens.com> Autocrypt: addr=ubely@ilbers.de; prefer-encrypt=mutual; keydata=mQENBGO2eUkBCACtT+T3OrPVSExBmqfgXT3lp9XcdxRzjYp26wezkgYjjBXaf36bxtaAf S471VoQtpar0RVeFfW7WDDdfX9ZclSj36zBQe+RVSJzoNoNQfjOXWuSHb5Z+cpAFtqBY4muxK4+ia IlLJd6CN3ejOsLHATtCeHHq8wi0z2T+KdLQO+wQRgo2hjj0Lp9pGTrKJry50HP/o7Vbdu14dOx2xq r8+wPc6SQbBIrcqaa4MqCQC00vQG7eXvo+k2MOw59FDdpMH0KR9mHgp3u/s4I+4YRBArukt9G9xz/ rsEFmxAIBC6N/a6Hzwg4puc91n7ABDsPg8Vp+X3MDraujN0dvR6OKVNtABEBAAG0IFVsYWR6aW1pc iBCZWx5IDx1YmVseUBpbGJlcnMuZGU+iQFOBBMBCAA4FiEEJqPNVhVGyk12Eh+PAUQYBM/2FkoFAm O2eUkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQAUQYBM/2FkprlAgAmuna8Hm9EyoEtTl DBGDg6Zm4ZLp5ffvZBE946h92jepDrteoxsJ7pSzJVC2HmDLa4iZUao7lLLbDsUj5x45/iLJcqBZK k3YnAxP2r6a+kI+1VVQY1pxdG1nlJAbdNzoojm/qmezNPSrqni61KVMQKsXBCWhIjSXDSM9CsBj21 a+9qaVqfxovJGTn9lgrZO+xzKQNMKZeOouJlscVuFj21P0ww3/YENiU/nMeTSuYypO76mDtAd08Jo nc3yuHa9MJGei5ixN3wT+IrGR2aL2hdw2M6NgH7sYbL2Zi4ugD6RXHJai1Bh2yvFSVqSQ+M6QOInT 4ud7wslm1XRB065dXtA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: xF3z9jgf4SFg On Wed, 2025-03-19 at 07:49 +0100, 'Cedric Hombourger' via isar-users wrote: > The following construct may generate [] entries: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0 mirror_list =3D [entry.split() > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for entry in premirrors.split('\\n') > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if any(entry)] >=20 > A valid pre-mirror entry is a regex and replacement URL > tupple. This causes an unpack error when evaluating: >=20 > =C2=A0=C2=A0=C2=A0 for regex, replace in mirror_list >=20 > if the entry is e.g. " ". >=20 > For instance " re1 u1 \n re2 u2\n=C2=A0=C2=A0 " would be translated to > mirorr_list =3D [['re1','u1'],['re2','u2'],[]]: only the first > two entries have two values, the latter has none. >=20 > It should be noted that split() will do just fine when multiple > spaces are found between components of a valid entry (leading > and trailing spaces within an entry will not cause issues). >=20 > After checking if entry is iterable ("if any(entry)"), only > process entries with exactly two components (silently ignore > others) so we do not die with an uggly unpack error exception. >=20 > Signed-off-by: Cedric Hombourger > --- > =C2=A0meta/classes/bootstrap.bbclass | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/meta/classes/bootstrap.bbclass > b/meta/classes/bootstrap.bbclass > index c0644acb..64702d5d 100644 > --- a/meta/classes/bootstrap.bbclass > +++ b/meta/classes/bootstrap.bbclass > @@ -123,7 +123,7 @@ def get_apt_source_mirror(d, > aptsources_entry_list): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 premirrors =3D d.getVar(= 'DISTRO_APT_PREMIRRORS') or "" > =C2=A0=C2=A0=C2=A0=C2=A0 mirror_list =3D [entry.split() > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for entry in premirrors.split('\\n') > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if any(entry)] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if any(entry) and len(entry.split()) =3D=3D = 2] > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 for regex, replace in mirror_list: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 match =3D re.search(rege= x, aptsources_entry_list[2]) > --=20 > 2.39.5 Applied to next, thanks. --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= dce619d11d79c672049fa499da608c1dabd77df1.camel%40ilbers.de.