public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] Henning Schild" <henning.schild@siemens.com>,
	"[ext] Adler, Michael" <michael.adler@siemens.com>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"claudius.heine.ext@siemens.com" <claudius.heine.ext@siemens.com>,
	Claudius Heine <ch@denx.de>
Subject: Re: [PATCH] added 'isar-cfg-userpw' package
Date: Tue, 26 Feb 2019 20:47:25 +0100	[thread overview]
Message-ID: <dd31fc66-076b-c9b2-ec0d-e8437c2bd49b@siemens.com> (raw)
In-Reply-To: <1577ed53-0452-9b44-d107-ad13f7240e37@siemens.com>

On 26.02.19 20:36, [ext] Jan Kiszka wrote:
> On 25.02.19 11:34, [ext] Henning Schild wrote:
>> Hi,
>>
>> this is not related to the package. But to any package that goes
>> through common.sh and checks the ids.
>>
>> https://groups.google.com/forum/#!searchin/isar-users/Align$20UID$20and$20GID$20%7Csort:date/isar-users/S5W8D3X4Lkg/n7HbASWnAwAJ 
>>
>>
>> The result of this discussion was that we probably need to align the
>> ids and hope we never get in trouble with the host. In this case we do!
>>
>> The alignment should be changed. If the group does exist (100) join the
>> user and do not try and create a group. The check should be changed to
>> make sure the gid is the main group gid, instead of 1000.
> 
> FWIW, just ran into the same issue after purging my build folder and retrying a 
> clean "kas-docker --isar build". I'm not seeing it with jailhouse-images where 
> we do not use kas-docker yet and also do not create the build folder outside of 
> the container, thus with host IDs.
> 
> So, this needs to be fixed in our kas-isar container, I suppose...

No, the bug is really in common.sh, the container is fine:

That script checks for group names, which is probably pointless. In this case, 
we are in the right group, that group just has an alias called "builder", but 
was originally called "users".

Why the heck should we check the group?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2019-02-26 19:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 16:21 claudius.heine.ext
2019-02-18 16:58 ` Henning Schild
2019-02-19  9:19   ` Henning Schild
2019-02-23 10:42 ` Jan Kiszka
2019-02-25  8:07   ` Jan Kiszka
2019-02-25  8:44     ` Claudius Heine
2019-02-25  8:48       ` Jan Kiszka
2019-02-25  9:32         ` Henning Schild
2019-02-25 11:15           ` Jan Kiszka
2019-02-25 11:44             ` Claudius Heine
2019-03-04 10:15               ` Claudius Heine
2019-02-25 11:18         ` Claudius Heine
2019-02-25 10:18 ` Adler, Michael
2019-02-25 10:34   ` Henning Schild
2019-02-25 11:38     ` Henning Schild
2019-02-26 19:36     ` Jan Kiszka
2019-02-26 19:47       ` Jan Kiszka [this message]
2019-02-27  8:46         ` Henning Schild
2019-02-27 10:20           ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd31fc66-076b-c9b2-ec0d-e8437c2bd49b@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=ch@denx.de \
    --cc=claudius.heine.ext@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=michael.adler@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox