From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7091532167862288384 X-Received: by 2002:a05:600c:240a:b0:394:18b:d722 with SMTP id 10-20020a05600c240a00b00394018bd722mr6762799wmp.177.1651650672012; Wed, 04 May 2022 00:51:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6d84:0:b0:20c:7b09:42a4 with SMTP id l4-20020a5d6d84000000b0020c7b0942a4ls1719813wrs.2.gmail; Wed, 04 May 2022 00:51:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFJhT/6LZ+zw4PyT05WPN7104TUCQYIOGLZcKL3iQ8wnKKjGtQFqO/qquYcDmMJmeGU/Pp X-Received: by 2002:a05:6000:1543:b0:20c:583d:e8ec with SMTP id 3-20020a056000154300b0020c583de8ecmr13579502wry.460.1651650671113; Wed, 04 May 2022 00:51:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651650671; cv=none; d=google.com; s=arc-20160816; b=DIZ2UwS8rkZXax44v6xFRv8cKi+sq0OESblRAZe6btKRTEZ9/yfjS75kf7chuBQcpn oMH+gHJAEKNKvzOD7IXykUbbWqzzBJcF+2b//AJHreJ7/bf6PnDCOU1hApbPt8lWTL1W 4QQa59nG7TVmtRyMdahFXQ6OuA1tpsdXzKBqkcO8CeJyl3YjKzj8IQbumPjKrcQDtU4z V2y1bACMVnuQgHNtoZ4pbNhRjU+5uJNxSTMcZzjS5heMkFB6nPTo75BmxV2mpFY2p8g0 3k5XICvhld9uMtCFAs4nWpp9PNZDAtZQAqwRMQX1m/W+jiuiD9AJ2djtW+kz8Gq/v2mR si5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id; bh=jdT8z/+dZRjs3sN2lznCGpOXQ0xexxNVE4fThILKZKI=; b=e0IbkyTaMvtJmvgRnG78MLW/F+KPCa7+U6Zhlk1g08sGykeXMnp36Zq2d5WoJDKgpk 1idQaUulM9V19EALN7FMTLds5dbBJIqtS2iz2EmNMpRfYxKN/EH+v62XK9AohGVrWi6E U3Ji9VS5htWuyrwCyKqexkUiV8rZGQjfSGh0ATdhPz62UPF2rVbyOgyBzwKhxP1fOMY5 4EYcRM0LUQo2oBUA9iXfP2FRqtXUFZHPFUpBPeHethAIzL7xcHYV2sgCmLkfNrVZb6Se NN/MtDOzHJDYc6cnOv2eh0j9BabqhkSJ+INX6V57Z9oCO3BtsbU3W6kkPwyl8UyxQroa zM+w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id a14-20020a056000188e00b0020c788b9364si128495wri.4.2022.05.04.00.51.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 May 2022 00:51:11 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 2447p8VN031620 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 May 2022 09:51:10 +0200 Message-ID: Date: Wed, 4 May 2022 10:51:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 0/8] imagetypes Content-Language: en-US To: Adriaan Schmidt , isar-users@googlegroups.com References: <20220428060615.986332-1-adriaan.schmidt@siemens.com> From: Anton Mikanovich In-Reply-To: <20220428060615.986332-1-adriaan.schmidt@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: gq4tf2GNiDSX 28.04.2022 09:06, Adriaan Schmidt wrote: > This series introduces image types and conversions as known from OE. > The main motivation is to provide a more flexible way of generating > and processing images, without the need to insert custom tasks (e.g., > currently we have custom classes adding tasks for things like bz2 or xz > compression of images in several downstream layers). > > These patches have been tested on some of our layers, and also > work with some more "challenging" use cases like image-in-image recipes > and custom image types brought by layers. > > This only has a bare minimum of conversions (gz, xz), so there should > probably be follow-ups for additional compressions, or things > like checksums, which can also be nicely done with this. > > - p1 prepares by removing image-type-suffix from image build directories, > which enables sharing of the completed rootfs across image types > - p2 refactors the SDK, and makes it an image feature instead of > a separate recipe (has been discussed here a while ago) > - p3 does the actual work, but keeps all original files > - p4 moves code to different files > - p5 adapts meta-isar > - p6 removes IMAGE_FSTYPES as a dimension in multiconfig. Now that > we can build multiple types from one rootfs, multconfig is > just the wrong way of doing this (also been discussed here). > - p7 documents > - p8 adapts start_vm tests > > changes since v3: > - better handling of xz compression options (taken from OE) > - fix IMAGE_FSTYPES append in qemuamd64-bullseye.conf > - add patch to adapt start_vm to new image type and file names > > changes since v2: > - fix bug where construction of IMAGE_BASETYPES was not recursive > - add comment explaining IMAGE_BASETYPES > - fix ISAR_CROSS_COMPILE exception for ubifs+armhf > - use "IMAGE_CLASSES +=" instead of "INHERIT +=" in machine configs > - fix whitespace errors in documentation > > changes since v1: > - rebase > - fixed naming issue in wic.bmap files > - more reasonable default settings for xz > - add documentation to user manual > > Adriaan Schmidt (7): > image: remove IMAGE_SUFFIX > image: refactor SDK > meta: introduce IMAGE_CMD_* > imagetypes: restructure files > imagetypes: switch meta-isar to the new scheme > meta-isar: remove IMAGE_FSTYPES from multiconfig definitions > docs: add new imagetypes to user manual > > Anton Mikanovich (1): > start_vm: update image types checking > > doc/user_manual.md | 86 ++++--- > meta-isar/classes/rpi-sdimg.bbclass | 2 +- > meta-isar/classes/ubi-ubifs-img.bbclass | 11 +- > meta-isar/conf/local.conf.sample | 4 - > meta-isar/conf/machine/bananapi.conf | 2 +- > meta-isar/conf/machine/container-amd64.conf | 2 +- > meta-isar/conf/machine/de0-nano-soc.conf | 2 +- > meta-isar/conf/machine/hikey.conf | 2 +- > meta-isar/conf/machine/imx6-sabrelite.conf | 3 +- > meta-isar/conf/machine/nanopi-neo.conf | 2 +- > meta-isar/conf/machine/phyboard-mira.conf | 3 +- > meta-isar/conf/machine/qemuamd64.conf | 2 +- > meta-isar/conf/machine/qemuarm.conf | 2 +- > meta-isar/conf/machine/qemuarm64.conf | 2 +- > meta-isar/conf/machine/qemui386.conf | 2 +- > meta-isar/conf/machine/qemumipsel.conf | 2 +- > meta-isar/conf/machine/qemuriscv64.conf | 2 +- > meta-isar/conf/machine/rpi-common.conf | 2 +- > meta-isar/conf/machine/rpi.conf | 2 +- > meta-isar/conf/machine/sifive-fu540.conf | 2 +- > meta-isar/conf/machine/stm32mp15x.conf | 2 +- > meta-isar/conf/machine/virtualbox.conf | 2 +- > meta-isar/conf/machine/vmware.conf | 2 +- > .../qemuamd64-bullseye-cpiogz.conf | 7 - > .../multiconfig/qemuamd64-bullseye-tgz.conf | 7 - > .../conf/multiconfig/qemuamd64-bullseye.conf | 2 + > .../multiconfig/qemuamd64-buster-cpiogz.conf | 9 - > .../multiconfig/qemuamd64-buster-tgz.conf | 9 - > .../conf/multiconfig/qemuamd64-buster.conf | 2 +- > .../recipes-core/images/isar-image-ubi.bb | 4 +- > meta/classes/container-img.bbclass | 17 -- > meta/classes/cpiogz-img.bbclass | 22 -- > meta/classes/ext4-img.bbclass | 24 -- > meta/classes/fit-img.bbclass | 29 --- > .../classes/image-container-extension.bbclass | 83 ------- > meta/classes/image-sdk-extension.bbclass | 87 ------- > meta/classes/image.bbclass | 212 ++++++++++++++++-- > meta/classes/imagetypes.bbclass | 93 ++++++++ > meta/classes/imagetypes_container.bbclass | 95 ++++++++ > .../{vm-img.bbclass => imagetypes_vm.bbclass} | 24 +- > ...wic-img.bbclass => imagetypes_wic.bbclass} | 45 ++-- > meta/classes/rootfs.bbclass | 1 + > meta/classes/sdk.bbclass | 137 +++++++++++ > meta/classes/targz-img.bbclass | 15 -- > meta/classes/ubi-img.bbclass | 32 --- > meta/classes/ubifs-img.bbclass | 32 --- > .../{sdkchroot => sdk-files}/files/README.sdk | 0 > .../files/configscript.sh | 0 > .../files/gcc-sysroot-wrapper.sh | 0 > .../files/relocate-sdk.sh | 0 > meta/recipes-devtools/sdk-files/sdk-files.bb | 26 +++ > meta/recipes-devtools/sdkchroot/sdkchroot.bb | 78 ------- > scripts/start_vm | 8 +- > testsuite/cibase.py | 4 +- > testsuite/citest.py | 2 - > testsuite/start_vm.py | 8 +- > 56 files changed, 673 insertions(+), 584 deletions(-) > delete mode 100644 meta-isar/conf/multiconfig/qemuamd64-bullseye-cpiogz.conf > delete mode 100644 meta-isar/conf/multiconfig/qemuamd64-bullseye-tgz.conf > delete mode 100644 meta-isar/conf/multiconfig/qemuamd64-buster-cpiogz.conf > delete mode 100644 meta-isar/conf/multiconfig/qemuamd64-buster-tgz.conf > delete mode 100644 meta/classes/container-img.bbclass > delete mode 100644 meta/classes/cpiogz-img.bbclass > delete mode 100644 meta/classes/ext4-img.bbclass > delete mode 100644 meta/classes/fit-img.bbclass > delete mode 100644 meta/classes/image-container-extension.bbclass > delete mode 100644 meta/classes/image-sdk-extension.bbclass > create mode 100644 meta/classes/imagetypes.bbclass > create mode 100644 meta/classes/imagetypes_container.bbclass > rename meta/classes/{vm-img.bbclass => imagetypes_vm.bbclass} (89%) > rename meta/classes/{wic-img.bbclass => imagetypes_wic.bbclass} (86%) > create mode 100644 meta/classes/sdk.bbclass > delete mode 100644 meta/classes/targz-img.bbclass > delete mode 100644 meta/classes/ubi-img.bbclass > delete mode 100644 meta/classes/ubifs-img.bbclass > rename meta/recipes-devtools/{sdkchroot => sdk-files}/files/README.sdk (100%) > rename meta/recipes-devtools/{sdkchroot => sdk-files}/files/configscript.sh (100%) > rename meta/recipes-devtools/{sdkchroot => sdk-files}/files/gcc-sysroot-wrapper.sh (100%) > rename meta/recipes-devtools/{sdkchroot => sdk-files}/files/relocate-sdk.sh (100%) > create mode 100644 meta/recipes-devtools/sdk-files/sdk-files.bb > delete mode 100644 meta/recipes-devtools/sdkchroot/sdkchroot.bb > Applied to next, thanks.