From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6633025437179052032 X-Received: by 2002:a50:b568:: with SMTP id z37mr1583496edd.7.1544371581473; Sun, 09 Dec 2018 08:06:21 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:9507:: with SMTP id u7-v6ls1335887ejx.4.gmail; Sun, 09 Dec 2018 08:06:21 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vr8RadWmDyVOMx4mUIJiAlf4ZibyfCDGGmHf7FiXkZwS6kxTIIcYtzo2Z6yudVOA3vO84Y X-Received: by 2002:a17:906:404f:: with SMTP id y15-v6mr1242654ejj.5.1544371581039; Sun, 09 Dec 2018 08:06:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544371581; cv=none; d=google.com; s=arc-20160816; b=YRhtJ3yFKxJ4K/ypSiW+OWCd1DeeYJmk8udnm+gArGkgTQ3sEiPpxQpEmapHPo4/+J TMZSa8QltPL+z9P+ADCnBWDdBz/opMxH0sa29fSm1OIxTNcZpwZsk5DaYduuE9t88Ion b/kI3QiiF8P1082Zd4G/3N4ulNzACwTUbjs3jU9EzFB/m/t2m/ETKo5Yh0N1S9yLWajP EpHMrQkl8vOwIX5KkGbE4u5QYkAJF909CLbMIN1DqjJbTjZx+NwS3hUMYo279U0KG/GH FZK8qr+LsnIYJVw/MKFzXRIgJzP10Ka5WUXQCZtM/6ZIQep7Cf1y5ObL7+8fc8l2YLrF I0Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:mime-version:user-agent :date:message-id:subject:from:to; bh=Lz6fiZj1C2R181WXRqc6MiewIrwazqNwLERkk6a0yF0=; b=XM90vLX3pT5yuiYpbQARgyKKHkZcbP1JXY8MpR3mYT38U9FbzVE9rW8CnPpZIQ88B9 Q4qq48UWBTvSG1QbCx5dPrgCjwrJmx7r63xGI0KA5fAu0NvbH2Wp+t3XM+eerO8ZiWz9 j4iFYo+555U03mcErrN2D8JaSLCpsEEcdhsGKfQwQWvdFGNYEQz8mYkoitqLFab8Gt4W v9Qe+GztREk/wY29GOc+ajtpRvtvvtARn/hDlAe0J+v5ILKFBPKGfuvheL8b1RrvSf8g jRuRk/rMZEvy33QqR8cV9BvzbKd3KayGxXgv6umUqQ90blpw5DLr6/PQRjqCqQVrknA1 RpCA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.4]) by gmr-mx.google.com with ESMTPS id h28si410551edh.4.2018.12.09.08.06.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Dec 2018 08:06:21 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) client-ip=212.227.15.4; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MbMg8-1gmaVc25HY-00IpNI for ; Sun, 09 Dec 2018 17:06:20 +0100 To: isar-users From: Jan Kiszka Subject: [PATCH] isar-events: Fix processing of /proc/mounts Message-ID: Date: Sun, 9 Dec 2018 17:06:19 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:wzggisqN+Jk1qIjxxq/rwv0swTDh0hRRALM2ef5P3OLbHetw+8T m0bVdxMpErrYc2Onw/4q4s1cIRvMnYLb+eUFP68pnwpJ6QuH80Jf+6rL7oFb3VAqbehSjkZ QWV4LquVvyxOt3kI6B5CIFF8fm8BXAUrfLccyiu85k+oZADXRyOyy/EIBkIU6sQaW2d5Ta3 6t6rqahehR9TXptQTqnnQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ZUgYrYPMjS8=:eHkpCpCsNdSFgchR5QQjiM x9DGkhEhBTy7xmMePjGE0CoZkizIRJH07bYJQow/scPUtBMWcYOk2QZTG05gpTsEWCZnXTDjh AwCPlvLWdmWKkzVNc7AlRXLZnG6hsfY5w144zA8CC89EXfbF/IcphvdBHcbMNo6bHSmnxZxNE ePrW4lPfQtHjfuVEmvyDdSwL+ePO2OmySoUZZNL9kk2CjsjjIZNU2uSNkUpZgGxFRH/mcgSAv qtrhS6K2kkltK+a3pOgdJfh3SJWTyiaIriOXl6KyIvsK4C8rf4QM8cDeHuqpkadvzi53xSr2y w9gH3Yr4gPFEbOADdIxq792b9JSlABr9m8pEF8pib6gXOGpjAQhf64LGB7bnC5OZOOEDZjrbJ Va2XM6jPtSe8SSfo6cc3YL11wF0ASyLjTtMg1s4gNiSew+qgI68SNF8DhDg5GBuAr60EfRTTR o2yIEFHVauhwO88aw8By3KUxZH0aFo6pTKhBiPIxnmyaPflR3DPFu8qIi/sX1bL0AeRgVbjTM Ymizrf/MjEvo670GcVl77CCKoK2rLfir5u8q4UjOq6lmERzwFGcnjXGXoT75jVnQDfLAL/aef fd8uYxpWVg5oMqsormQX2nl04eEisFuuXuu3Fyb0DKWcDKy+Yu6PW37JuMBh5gXchls7emgQd 46kdNJw+3xDli0wcsfzHCqeDa6YNlxnH/pV6m7xUnjSvOSmVkbWN8YkrAh9xAOprwL5h3GgvQ FtskqSI0/l405je4QtPb63HxDOTB6dCFjYUXy8HxUV5sio+5tGL14/gm1n8HZ1wsVzYp5I2ph a3OX3DmVwieC5xeP9NWStnY/ziobGBL9AUJtHhqnBMBVrEq805cmASdb20TudSaOD6u8IamSB bdoyadNUpd2eCRuCrUDbdJEZBPxD4jIS9eoOqcS4KBW4GzcqZW53V988/7nJU8 X-TUID: IBcwuQAnUiML From: Jan Kiszka We have to read /proc/mounts completely before starting to umount. That virtual file will change after each umount, and that could make us miss some mount points. Fixes: 05d0fc43e9e9 ("isar-events: Improve umount handler") Signed-off-by: Jan Kiszka --- meta/classes/isar-events.bbclass | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass index 05b27e5..c4a6149 100644 --- a/meta/classes/isar-events.bbclass +++ b/meta/classes/isar-events.bbclass @@ -18,10 +18,11 @@ python isar_handler() { with open(os.devnull, 'w') as devnull: with open('/proc/mounts', 'rU') as f: - for line in f: - if basepath in line: - subprocess.call('sudo umount -l ' + line.split()[1], - stdout=devnull, stderr=devnull, shell=True) + lines = f.readlines() + for line in lines: + if basepath in line: + subprocess.call('sudo umount -l ' + line.split()[1], + stdout=devnull, stderr=devnull, shell=True) } isar_handler[eventmask] = "bb.runqueue.runQueueExitWait bb.event.BuildCompleted" -- 2.16.4