From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6989998000320806912 X-Received: by 2002:a17:90a:ccc:: with SMTP id 12mr17084141pjt.57.1627907168595; Mon, 02 Aug 2021 05:26:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:8410:: with SMTP id j16ls5391731pjn.2.canary-gmail; Mon, 02 Aug 2021 05:26:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvhEOEjHZE/N2o4xiEvXYFZEyuNg96qhAUaTTgMXti5x9cLHXOTRSyX+E3hAmxVrg+room X-Received: by 2002:a17:902:b093:b029:12c:843:b55a with SMTP id p19-20020a170902b093b029012c0843b55amr14204178plr.83.1627907167902; Mon, 02 Aug 2021 05:26:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1627907167; cv=pass; d=google.com; s=arc-20160816; b=jsbCWISc4D6F+DtCwC9ad+mcy3Z0bqw4xgq4ttE20K1TQMESUjTkagvjXK2+SX8202 GJyvxdOfdAGwn6p8GaId/x2L89IfQonrHBpSgHJS2GY0DvZ1ydkSCk3o3W1pdmvToUzK ZBHvozViMlNw43DYXKJmAeb1xk7lTvxt55O2CWYqnYjMxxX2PIIYAjrEhnEexRzxFLSw xGkNTTK6djAeMC8QKl4B8SUeEBXHop3gEdhYhLx7lr4ez8PIm0VhNqDM3ruU3SiYR1DC yVPxfLBDTHiJGmnNMWLsS9Xnrq1/knxKw8nuGxlv911G/u/4/wU4Rn5ZgPCV+Nl/XZgS h0uw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-language:in-reply-to :user-agent:date:message-id:from:references:to:subject :dkim-signature; bh=MAHpZtexz0t93tAdvm/urKywttJDnxiCScSVN51vShQ=; b=TS5aOjX4sGJo3/NzK4SfAmu99FPdtk/WV7c2ZUgHC5BD9yAgzTUjP83PWIdX57nCPL bXB4mMKu6EvMBuwuevmfB28QKS2+K6pIP/tTgEZzONkvoeeNNc9V8VD3nYrUNSFhVs+e CKvd2FhalLCu9G0r3eEueCMvykIuhToacpa4O7cfPGsLNeM6hjIvITsR0LsiaXdgBfVA kogf+q7UL1mSOC4lKttkqva+M99JHI8DIVqQReh9A91tRd//yGVcu5nW+xxLk443RiCC yJ6xzTNohFYILgm62pZBmjDlsHK84D1Sl+lL2eHFZaF7RxABG9vtTppf7fi84bLwXkya My2A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=SBjLktcr; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.0.46 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00046.outbound.protection.outlook.com. [40.107.0.46]) by gmr-mx.google.com with ESMTPS id e1si590094pgk.0.2021.08.02.05.26.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Aug 2021 05:26:07 -0700 (PDT) Received-SPF: pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.0.46 as permitted sender) client-ip=40.107.0.46; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=SBjLktcr; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.0.46 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYadCg0grrhEVrcRaglzNn77PSXl5r6B4QuAVx7udgc5h9LNfw6bSM4DhhZsAHx+kmfa47Iv+W6pxFKhXrd2yh/GnmXdAhGRw1mUMgRzbVsLkk6umoFYYU16PWyw6kwBFzgHUCCfEJvVxNM0s0jZdzMlMQXt47Fg3FMugxgCZNCtU6wuQtTaDP2l2vHt6j3R1MawGj1wHET+CaGZ6cvNp2cxgqZ6v+096nrnFwngJO32RmMPsaiWmvLefhxxElKP4e+tSzhNNBNxqnE1BZpAxfv+oINNkloswZX9Q2cYzXoz6WqfWEXDAYORXi7Cn92STaim58OyHLBYGjYJWUqJOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAHpZtexz0t93tAdvm/urKywttJDnxiCScSVN51vShQ=; b=KrGK9oS6nmlKnZhtqaq8WC4pGDDVNsyiq1bGsjNfHhvnog223vUCetQ05MVA+D0OOBMrRaZUJkWfZUSpZ3Sod0rrcZmr1I4daypxDQsyMVqLsZHZGs2QgLymuTkJjAKeDqxqWtN8QWC+9NPkFL+c4jd73yEqYb/pZjRR/aLdZfKHjdN8Ac3NwI1rt0s5VYoha+VG2HIXe4FQQpdaQ5NYpXDHOzjCLVQjp9MnO19GzzkK670omhH6033GlyGMPlrVo9YCMlJGaLtjptOzn3x/NSkqEX4Fj3+i/er5j27gVNBzZmUbQyermVOY30j86YZXgs/J3wU1C3O/4YU5lXbRJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAHpZtexz0t93tAdvm/urKywttJDnxiCScSVN51vShQ=; b=SBjLktcrs0oxQbVGwqxetF1HxgiCzQKWCCatppr65F9f5QObK/KIyK7ydtxzf4SjY+10SzgL3AlabhFyWmadvPqhGkNlMb3TNZ9Hb+kqTMeTEW7ZPgJ7gFbs/Sib0xSUiVvSf4N591YMwyn478L0P0QdnbgB+GvhlocDAKyqgXc= Authentication-Results: googlegroups.com; dkim=none (message not signed) header.d=none;googlegroups.com; dmarc=none action=none header.from=siemens.com; Received: from PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:ab::7) by PR3PR10MB4093.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:a3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17; Mon, 2 Aug 2021 12:26:04 +0000 Received: from PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d6e:ae99:c95c:83bd]) by PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d6e:ae99:c95c:83bd%9]) with mapi id 15.20.4373.026; Mon, 2 Aug 2021 12:26:04 +0000 Subject: Re: [PATCH v3 3/4] classes: allow more control over container image name and tag To: Henning Schild , isar-users@googlegroups.com References: <20210802115404.22707-1-henning.schild@siemens.com> <20210802115404.22707-4-henning.schild@siemens.com> From: Silvano Cirujano Cuesta Message-ID: Date: Mon, 2 Aug 2021 14:26:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: <20210802115404.22707-4-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::7) To PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:ab::7) Return-Path: silvano.cirujano-cuesta@siemens.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:a61:3b25:cf02:6bfa:48c3:3d22:d916] (2001:a61:3b25:cf02:6bfa:48c3:3d22:d916) by FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.12 via Frontend Transport; Mon, 2 Aug 2021 12:26:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39fbd0db-2e12-4674-e9b5-08d955b0b273 X-MS-TrafficTypeDiagnostic: PR3PR10MB4093: X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3C7uVTyE4gbgTg0KEyVa/ZNoif82t5xN2w594hbxZoBjF2DRUGgm2k4Osr7TUSiYK8E6w+EcdR2mTnGLiFDzYsBhihmZR/QESpt90h6C8R7yThQe8jUQVfortdwoLU28Ybg4K8rsE4HUxwlyQut74K6JPkwHH5c/btmnZGjWEpKmBY2TpSdNbyoGtSfPl80oO13AbGJPZkW2hntYhu5esTYQ5OST+Hv7j/85POBgQ3fdAbXwZ/l1oXdy8SvxOfZVSunR/542DX9YeSHsRmfEiV/yYZ6V35pjOK4xJfRs250F9hJHMuN8YrFRpnHNqrNtO5eQQZ70wZWGDBns/nmGQ5Y9cPbNaeQQdc3EJVNrWN+VPNrE4/Szuk04zyhASFsHm/TcJfylT/1eQ0ssFkfSP/MMxFIxstP35PnmbrNXNcDPfy/voiu2l6qOSgPLz9ocw7Tn6ibfm3+9bx5SepYtroJ9Dfcf2M2Caa7/26wpu4R5xgOOsYHYdbTLQi5oqWgjUd/FUPLa7m5g/WxOhJTs+5Wn1RPMTonwh8IpQcJ8yJ6NCsK3zk7yITpt+UUJQ8ZoLpuTCmdmXpF0MC4TKXDavlT+1tkttAWy9wYS9wd3QslU/aHJ46Po8fogFuyOa61DOpeBVJ7JAM1PYeXyq2AeEm/HMdixEEDr7xTQEk8CSImORJFmhKbJOpcZSHRUBGb/OB1sqfwurvXwFcXJWuJqKbPOyEpedp5ocloNafD1sxQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(31686004)(2616005)(316002)(8676002)(186003)(6486002)(8936002)(53546011)(2906002)(31696002)(66476007)(66556008)(83380400001)(66946007)(508600001)(86362001)(36756003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0Z6bXNyVW9wQnJzeXFWcUtiNlkyUEdUM1Q5MFV1ZHRMcUVGdFBNZHY2ZXoz?= =?utf-8?B?Slo5RFhldEUxRFE1a0drOHk4QTFvTVBXS2lDMXZoZUFKMmNJTWc0MHloWjhj?= =?utf-8?B?TFRYaUtCNUw0M1lGcWxKV0hGWW5hcWFRV1BVeGs2RjIxNGp6eWozVGUvVy9V?= =?utf-8?B?aDlXU2VUVWRjaEZDZ1RHRStxclNwNUZydjAzNEdHS2pzSm1oMXFhTis3bm9q?= =?utf-8?B?UWdjWHBVUHlDdldza3YxL1RGN1NDOHl4TXVnRTBoeFVWS2NJMFhHRlkxUjVo?= =?utf-8?B?UExVL3Y1c3pXazVONGg4dHRMWHJMSVlNSEQvc0JhYWVhb2hpb2JsSGRUUWJs?= =?utf-8?B?VVRCZHdiNkhITklHYWlLOGlPOUg0L2NBYkJRdmJLME1TYk9nVXFJdUhULzJH?= =?utf-8?B?SDBaOGs1NlFCVmp4MEhrL3RvOUp0QmJFL1dMNzR3UTl5eU1mc2FmU29xblEr?= =?utf-8?B?d2VYYzd5QyswbHRwd0VNdzZ3MzZDK3B4QytQNkw2NnZ2czIvVTduR2x2TUlh?= =?utf-8?B?RndGVXJVckJFWTFpYm5HelhobFBMY2NGVXU2NnF0MVY2T29hOFlDbWZmOWpT?= =?utf-8?B?NU9tNWJicGg1dzc0dUJEYkNtbk1USC9UQTdSMVZJdWVtUitabE9hUjdBVmpv?= =?utf-8?B?c2hGRVM1ZmZGbjlQcmtLd3ZmaFFMbWRWQjc2LzQ4YkVsb2IvaURBUTkvTlZz?= =?utf-8?B?NGxIUUxFcmdVZ0M4dGR2QklKcjVFdU5HOHJuUGNJSGpjUFovVDQzZXRZUXpi?= =?utf-8?B?azF5Vk9DTWt4SUJ3Z1lKVGpzZ3BRaE5rQldHSU8rSTMrRGk2azBEVDU4RXJ3?= =?utf-8?B?ajVreVJ1YTNGRlFIczhwTGhhUmFFU1c1TldRMTlzM1lwMHg1emxucW5EblEv?= =?utf-8?B?V1dmTkJITmNIbSsvdEpxdUthR1pzNEtrcHV2UWptN2EwWFBSeHFzUHg5eHRS?= =?utf-8?B?NVZyWGxUaTJ4Y0JXN1VOd1o1eFZpejBVNEk3N3ZlY2dWZEpxMzlBaEZLbk9j?= =?utf-8?B?N0lXa21STzVoeDVWbDg0Zmw5ZVVEQVViWDlreVU3SkdjUWlXelVSMEk2QzhT?= =?utf-8?B?UnpwUW1VYTd0YUs0SDB3SlFUWjdmTmJKTG0vT1pSc3RxWlhIY2E4MjE1TkVs?= =?utf-8?B?UENBM2xSYjRyc2V1QjcyZXIycWcxaDh6NzcrL3JzSlVQVVdEOW5tZUpjakJt?= =?utf-8?B?OGNaeEpDV2thQTVlL2NKNTJyZXJWOE9qM3VUalRFUGlZeWJ3RUkrWWdRRGVS?= =?utf-8?B?QXVNN21sVG5ZdkhDNElXTFBBcDlpRzdGQldwYUVYdnNrVzhVSGR0N3QrS3dX?= =?utf-8?B?Qk5mVlJXallwNXkrdSsvcmNwTWpYRkEzenlRZGVWUnExZHVNaEtPVmZ5T2Y0?= =?utf-8?B?czFISkdEUUFoQ2lBcTlXcEZ6TXMrQUR5WkorT1pSZmowck5ONFh5UWtxWUhm?= =?utf-8?B?T3g3akJRQ3RNaGUxL3I3L2xGVVJNeGdOSDZVYUVGaHNHTkdGeFZOc0VOdnNs?= =?utf-8?B?OVNOVkFmaDFaYXJ0QytGaW5VMWRBaXhIQk9tdzl1bEkxdUVWMkxJOFlabnYr?= =?utf-8?B?OEJXRS82cHZEcjg1ZlY4SGFGVS80aDN6bXZMSVNuUXo5VnJTSlFmOGc0SDB2?= =?utf-8?B?SEtCc0xYOFV3NCtuTlVRVGNLNndUejFVc3l1bVBRdTdOYW9DckZmcWx4S1hW?= =?utf-8?B?Q1cwY0ZtejVFVHN5d0lJMndSdHpvY1g4LzQ0NHBZWUlFMlVoQ1RBSXpNTEpQ?= =?utf-8?B?QXRGZDRXcGwwTTh3aXBIcTB3ME5vQ1BHak5OQTVaanpZUmVicjQ0bXRtZEkw?= =?utf-8?B?VmNYMGdFWXl6aUl5STVsMWJSbkx3eFN4cThpaFVOZHMzZ0ZadHRQdXN3TjRu?= =?utf-8?Q?sFM2xIDA/nA3+?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39fbd0db-2e12-4674-e9b5-08d955b0b273 X-MS-Exchange-CrossTenant-AuthSource: PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2021 12:26:04.7655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hhgGcN1hA/L5yO/tFT+o1OlcN7uetVF2N+Jc6CvDqTLUEY6Fu8dlPVcFYQEIemEpzWfs2iNCTQ3vzzL6vuHtoqP5J5ak1rViIaweAm5SKaUR63DsvwlM8I+w4HVUVS7q X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB4093 X-TUID: 5DUt7U7wD83x On 02/08/2021 13:54, Henning Schild wrote: > This patch allows more fine-grained control over how the resulting > container will be tagged. Where the default name will be PN together > with DISTRO and ARCH, and tag will be derived from PV and PR > > Signed-off-by: Henning Schild > --- > RECIPE-API-CHANGELOG.md | 4 ++++ > doc/user_manual.md | 8 ++++---- > meta/classes/container-img.bbclass | 4 +--- > meta/classes/image-container-extension.bbclass | 11 ++++++----- > meta/classes/image-sdk-extension.bbclass | 2 +- > 5 files changed, 16 insertions(+), 13 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 806c2914f13f..d12d30e192a8 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -292,3 +292,7 @@ Migrate your patches so they can be applied with "git am", or > > Kernel image name for arm64 platforms is vmlinux now. Image format was > not changed (uncompressed executable) but now it is named correctly. > + > +### Change default "TARGET_NAME:TAG" when building container images > + > +The "TARGET_NAME" used to be rather static and the TAG was always "latest", now the values are derived from recipe variables PN, PV, PR. > diff --git a/doc/user_manual.md b/doc/user_manual.md > index cf7dc2fee35e..e5c07bd41fc5 100644 > --- a/doc/user_manual.md > +++ b/doc/user_manual.md > @@ -300,14 +300,14 @@ bitbake mc:qemuarm-buster:isar-image-base > - Load the container image into the Docker Daemon > > ``` > -docker load -i build/tmp/deploy/images/qemuarm/debian-buster-armhf-docker-archive.tar.xz > +docker load -i build/tmp/deploy/images/qemuarm/isar-image-base-debian-buster-armhf-1.0-r0-docker-archive.tar.xz > ``` > > - Run a container using the container image (following commands starting with > `#~:` are to be run in the container) > > ``` > -docker run --rm -ti --volume "$(pwd):/build" isar-buster-armhf:latest > +docker run --rm -ti --volume "$(pwd):/build" isar-image-base-debian-buster-armhf:1.0-r0 > ``` > > --- > @@ -1070,14 +1070,14 @@ bitbake -c do_populate_sdk mc:qemuarm-buster:isar-image-base > - Load the SDK container image into the Docker Daemon > > ``` > -docker load -i build/tmp/deploy/images/qemuarm/sdk-debian-buster-armhf-docker-archive.tar.xz > +docker load -i build/tmp/deploy/images/qemuarm/isar-image-base-debian-buster-armhf-1.0-r0-docker-archive.tar.xz > ``` > > - Run a container using the SDK container image (following commands starting > with `#~:` are to be run in the container) > > ``` > -docker run --rm -ti --volume "$(pwd):/build" isar-sdk-buster-armhf:latest > +docker run --rm -ti --volume "$(pwd):/build" isar-image-base-debian-buster-armhf:1.0-r0 > ``` > > - Check that cross toolchains are installed > diff --git a/meta/classes/container-img.bbclass b/meta/classes/container-img.bbclass > index 79ef3e8d756b..9928a58ef53d 100644 > --- a/meta/classes/container-img.bbclass > +++ b/meta/classes/container-img.bbclass > @@ -9,10 +9,8 @@ > do_container_image[stamp-extra-info] = "${DISTRO}-${MACHINE}" > do_container_image[vardeps] += "CONTAINER_FORMATS" > do_container_image(){ > - rootfs_id="${DISTRO}-${DISTRO_ARCH}" > - > bbdebug 1 "Generate container image in these formats: ${CONTAINER_FORMATS}" > - containerize_rootfs "${IMAGE_ROOTFS}" "${rootfs_id}" "${CONTAINER_FORMATS}" > + containerize_rootfs "${IMAGE_ROOTFS}" "${CONTAINER_FORMATS}" > } > > addtask container_image before do_image after do_image_tools > diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass > index 0e70ba9c1405..4f93d30219f9 100644 > --- a/meta/classes/image-container-extension.bbclass > +++ b/meta/classes/image-container-extension.bbclass > @@ -6,15 +6,16 @@ > # This class extends the image.bbclass for containerizing the root filesystem. > > CONTAINER_FORMATS ?= "docker-archive" > +CONTAINER_TARGET_NAME ?= "${PN}-${DISTRO}-${DISTRO_ARCH}" In a comment to patch v2 you mentioned your plan to call it "CONTAINER_TARGET_IMAGE". Have you changed your mind or is it just an error? > +CONTAINER_TAG ?= "${PV}-${PR}" Although only container images can have tags and not containers, I still find this name misleading for container newbies (and some ISAR maintainers will probably be). Your argument that "docker tag" only uses "TAG" doesn't convince me ;-) In general I'd say that both "CONTAINER_TARGET_NAME" and "CONTAINER_TAG" should start with the prefix "CONTAINER_IMAGE_". Both the name and the tag are attributes of a container image. Therefore I'd rather use "CONTAINER_IMAGE_NAME" and "CONTAINER_IMAGE_TAG". But since I'm neither a power user nor a power contributor, my opinion might not be that important. Silvano > > containerize_rootfs() { > local cmd="/bin/dash" > local empty_tag="empty" > - local tag="latest" > + local tag="${CONTAINER_TAG}" > local oci_img_dir="${WORKDIR}/oci-image" > local rootfs="$1" > - local rootfs_id="$2" > - local container_formats="$3" > + local container_formats="$2" > > # prepare OCI container image skeleton > bbdebug 1 "prepare OCI container image skeleton" > @@ -42,9 +43,9 @@ containerize_rootfs() { > sudo chown --recursive $(id -u):$(id -g) "${oci_img_dir}" > > # convert the OCI container image to the desired format > - image_name="isar-${rootfs_id}" > + image_name="${CONTAINER_TARGET_NAME}" > for image_type in ${CONTAINER_FORMATS} ; do > - image_archive="${DEPLOY_DIR_IMAGE}/${rootfs_id}-${image_type}.tar" > + image_archive="${DEPLOY_DIR_IMAGE}/${image_name}-${tag}-${image_type}.tar" > bbdebug 1 "Creating container image type: ${image_type}" > case "${image_type}" in > "docker-archive" | "oci-archive") > diff --git a/meta/classes/image-sdk-extension.bbclass b/meta/classes/image-sdk-extension.bbclass > index 426b92595554..fa15b588068c 100644 > --- a/meta/classes/image-sdk-extension.bbclass > +++ b/meta/classes/image-sdk-extension.bbclass > @@ -80,7 +80,7 @@ do_populate_sdk() { > # generate the SDK in all the desired container formats > if [ -n "${sdk_container_formats}" ] ; then > bbnote "Generating SDK container in ${sdk_container_formats} format" > - containerize_rootfs "${SDKCHROOT_DIR}" "sdk-${DISTRO}-${DISTRO_ARCH}" "${sdk_container_formats}" > + containerize_rootfs "${SDKCHROOT_DIR}" "${sdk_container_formats}" > fi > } > > -- Silvano Cirujano Cuesta -- Siemens AG, T RDA IOT SES-DE Corporate Competence Center Embedded Linux