Re: [PATCH 2/8] isar-events: Wait for failing umounts

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-19 11:03, Alexander Smirnov wrote:
> On 02/19/2018 12:48 PM, Jan Kiszka wrote:
>> On 2018-02-19 10:45, Alexander Smirnov wrote:
>>> On 02/16/2018 11:52 AM, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> The BuildCompleted event may come prior to all running build processes
>>>> being terminated. In that case, some mount might be busy, and we will
>>>> leave them dangling behind. Wait in that case.
>>>
>>> How long we should wait?
>>
>> Until it's done.
>>
>>> For example there was a bug with apt-get which
>>> results as hanging of 'http' process. So in this case Isar never returns
>>> to command prompt until second ^C pressed.
>>
>> In that case, you need to run around killing processes anyway.
>>
> 
> Yes, for sure. Just thinking in voice, how this could affect CI. You
> send kill signal to Isar build, but it could stay running forever... So
> pipeline will be blocked until you notice this.

That's why

a) you set a completion timeout for build jobs
b) you clean up the environment of a build afterwards

If you aren't using a VM or at last a container for b) yet, you are
already in troubles. ;)

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux