From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6523072403514327040 X-Received: by 10.28.21.79 with SMTP id 76mr326179wmv.26.1519038602711; Mon, 19 Feb 2018 03:10:02 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.11.2 with SMTP id 2ls125205wml.1.experimental-gmail; Mon, 19 Feb 2018 03:10:02 -0800 (PST) X-Google-Smtp-Source: AH8x227TSNK3BTryG2JoHRThtLNHWOJgq9RcTW5ixOxYdOUfvxDhrhyIgyNAdUjjBOccq7/43kiK X-Received: by 10.28.136.67 with SMTP id k64mr1958527wmd.27.1519038602063; Mon, 19 Feb 2018 03:10:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519038602; cv=none; d=google.com; s=arc-20160816; b=CYUIOcoOMdz/DgSgn1CU8lVikp6071Zx6yWZmtEwZTnyiRjet2KwE8KqbpBHI4H0ha kMCKBAbdLY6elRzeFMZG+Rh2ZeugQudFD9igmy8sJjyylrnAz82oF3pUxoJFPvfr0wXx /sL3X6RDkKIQ6viEvDRf4CkJWfo3ZPPytiHxetwXcv+OBYb2/64y+aimlaPnY+uJB6TI avEBivBCaAdmfUBb+1uQ566ItxS6+QxDh1/VMsCWCBlSPu9JJM5eobzLR+6drMKAZbJ3 0wgi84Hnfshzh0LeZw0ox814T6iQZ/+t6lpsueBULyzCalh4zOgG3TOsIZoVJvZcZ0aF PyrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=g9GcbrGQNQ7uLwqIn6QFwfraipf26y27x2y7lDM6TO0=; b=Lf0XJxr1/afR3o0FYSNn2K1zUx8xJklHAtiyTIgZlDWsf6D0XXx+JWwXgF4gDKgq+R eJ8fsWl63k3pKlJ5RALeJhZPMrnM7wigG1fQeYGXvo/z5GyDzuvAJWz0YRrFYcLznpBP 8JEsiNiBYgfrhtRIK/R8NoE7LLSr2NgczC4qA0OUp1Kwt56aM5vVg8BBsYSuR0xHt1+j Ci5atwXrG9qVjkS1Yog7rslzULymSVzL4rOYrlIWcum/YYlbr81wxOCmxVhFu61QTvEQ 7ueWgnx5DE9LtkMbqC09RP9UR6WMsEwMI9/gWMmAfAbc+WmHoBJAmbjbQkrzOH66S3WZ 7g8g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id c11si365269wrb.0.2018.02.19.03.10.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 03:10:02 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w1JBA1vO018119 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2018 12:10:01 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w1JBA1v7026192; Mon, 19 Feb 2018 12:10:01 +0100 Subject: Re: [PATCH 2/8] isar-events: Wait for failing umounts To: Alexander Smirnov , isar-users References: <3db8db617fb01db824b962b979de745fa0f4bc9a.1518771143.git.jan.kiszka@siemens.com> <70af17d0-be54-60c6-a11f-0a5047abea33@siemens.com> <1dac58ff-2be2-9cd9-2eb4-4686343cce65@ilbers.de> From: Jan Kiszka Message-ID: Date: Mon, 19 Feb 2018 12:10:00 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1dac58ff-2be2-9cd9-2eb4-4686343cce65@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: O44TdvVgnAVH On 2018-02-19 11:03, Alexander Smirnov wrote: > On 02/19/2018 12:48 PM, Jan Kiszka wrote: >> On 2018-02-19 10:45, Alexander Smirnov wrote: >>> On 02/16/2018 11:52 AM, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> The BuildCompleted event may come prior to all running build processes >>>> being terminated. In that case, some mount might be busy, and we will >>>> leave them dangling behind. Wait in that case. >>> >>> How long we should wait? >> >> Until it's done. >> >>> For example there was a bug with apt-get which >>> results as hanging of 'http' process. So in this case Isar never returns >>> to command prompt until second ^C pressed. >> >> In that case, you need to run around killing processes anyway. >> > > Yes, for sure. Just thinking in voice, how this could affect CI. You > send kill signal to Isar build, but it could stay running forever... So > pipeline will be blocked until you notice this. That's why a) you set a completion timeout for build jobs b) you clean up the environment of a build afterwards If you aren't using a VM or at last a container for b) yet, you are already in troubles. ;) Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux