From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6703379430489718784 X-Received: by 2002:a19:6e4d:: with SMTP id q13mr21247497lfk.6.1562243957299; Thu, 04 Jul 2019 05:39:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:553:: with SMTP id 80ls735919ljf.4.gmail; Thu, 04 Jul 2019 05:39:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqxe/h61x2c+wWP6qZXwMYc5IH7GRUiiadR5dFDkD9uwfnO0bGFdZO/xMgAH6jhvaT5OjS/d X-Received: by 2002:a2e:5c88:: with SMTP id q130mr10586099ljb.176.1562243956868; Thu, 04 Jul 2019 05:39:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562243956; cv=none; d=google.com; s=arc-20160816; b=Zb11wru36K8blFpddlLpRNUdklvw8HCJ0zc9V21hY5DEkTJyn+4+VcfjClC2oaXhgz HwH6KBk+orbkJpOoL3m0CQIpV6kVLBUBV2qg/UqxStywg7gkDJtGIXeeBG8ox2/KxU0A LxQD7VQnjLvkZ82zARjMo5BM3lKeQ+EsY5wRaPUTj63cqPm3AD5JcQQgB/JDBR7r+/qB yiSVD1V3687cKcHJUhkm9TGzNG3amVYrGtdTTFEeMAuUYty05kkZnZ5MJZW9zAeQp/eH s9XjsIezylEBegEX3nJN/prvfwDBMYaO1zskQJTunMhO5SrpNJ+QWaSTHhgTBFbTXDO3 UbSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=p3ZpbMQDELZw7zOUl2Oj+QszjVej6EZYQgyF5Z+Z6Ls=; b=0EDqcaCk0afR/oOj3q8jN0aSrGf/zbIPAVAv0dN9pwryUQCUcO5zNx2d/7zk8I2E9y OmyAnYzGBLj2hI5eRGBfbhM/IQQH7XWUMK0QHu73OlBUXZN2DkbtLPmw0MIwIXZEHj6J 0ppGMHfoV3cX3d8DCHmJUXt6HH7wGL0Sr6hIXydYAwB8grfLc9TaUPQMphRw02kaN5MI 8GHXhqJ0dtkT2Ahb/BxjlC+c6fQDFZRCrUoL1LL7iK8CpMX8lYuxJr/iNkEMvSUlDrHv Q1nbp4oq57eaY2ah01mrrrSXPW3TS9jqu+FEdxZ3wrYPVB5WndV/ihGpQVCqH2i0rrqf My4Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com Return-Path: Received: from relay1.mentorg.com (relay1.mentorg.com. [192.94.38.131]) by gmr-mx.google.com with ESMTPS id q11si358667ljg.2.2019.07.04.05.39.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2019 05:39:16 -0700 (PDT) Received-SPF: pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) client-ip=192.94.38.131; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-02.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hj116-0005xc-CT from Cedric_Hombourger@mentor.com ; Thu, 04 Jul 2019 05:39:12 -0700 Received: from [172.30.65.44] (137.202.0.90) by svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 4 Jul 2019 13:39:05 +0100 Subject: Re: [PATCH] builddeb: generate multi-arch friendly linux-libc-dev package To: Masahiro Yamada CC: , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Ben Hutchings , Riku Voipio References: <1560752096-1323-1-git-send-email-Cedric_Hombourger@mentor.com> From: Cedric Hombourger Message-ID: Date: Thu, 4 Jul 2019 14:39:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) X-TUID: 5RFY/6+ULd3F Hello Yamada-san Thanks for your review of this patch. Answers below On 7/4/2019 2:43 AM, Masahiro Yamada wrote: > CCed a couple of people. > > On Mon, Jun 17, 2019 at 3:15 PM Cedric Hombourger > wrote: >> Debian-based distributions place libc header files in a machine >> specific directory (/usr/include/) instead of >> /usr/include/asm to support installation of the linux-libc-dev >> package from multiple architectures. Move headers installed by >> "make headers_install" accordingly. >> >> Signed-off-by: Cedric Hombourger >> Reviewed-by: Henning Schild >> --- >> scripts/package/builddeb | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/scripts/package/builddeb b/scripts/package/builddeb >> index b03dd56a4782..8f7afb3a84e9 100755 >> --- a/scripts/package/builddeb >> +++ b/scripts/package/builddeb >> @@ -132,6 +132,11 @@ fi >> if [ "$ARCH" != "um" ]; then >> $MAKE -f $srctree/Makefile headers_check >> $MAKE -f $srctree/Makefile headers_install INSTALL_HDR_PATH="$libc_headers_dir/usr" >> + # move asm headers to /usr/include//asm to match the structure >> + # used by Debian-based distros (to support multi-arch) >> + libc_mach=$($CC -dumpmachine) >> + mkdir $libc_headers_dir/usr/include/$libc_mach >> + mv $libc_headers_dir/usr/include/asm $libc_headers_dir/usr/include/$libc_mach/ >> fi >> >> # Install the maintainer scripts > > I am not sure but, > I just worried about the backward compatibility... this patch is actually addressing a compatibility problem with multi-arch capable distros (all the major Debian-based distros that I know of are) where the currently generated libc headers packages is placing arch specific headers where all arch compilers installed on the system would find them > Was this previously broken? yes (as noted above) but would only be seen on systems with multi-arch packages / development tools installed > I guess debian is using own control file > instead of the one in upstream kernel. > So, this is almost a matter for developers, I think. Correct. Debian and some others use their own. We (Mentor and Siemens) as well as other folks from the embedded community build embedded platforms using Debian as a base and recent kernels (so we can run Debian on e.g. recent Arm64 hardware designs). This is achieved by using Isar (https://github.com/ilbers/isar). The custom kernel recipe it provides uses builddeb since that feature is mainline. It also allows us to use custom kernels regardless of the Debian-based distro we use (Raspbian, Ubuntu, Debian, etc.) > How did debian-base distros managed this before, > and will this introduce no breakage? We would expect desktop distros to continue using their own debian/{control,rules} files but would recommend to have the .deb produce by the kernel be better aligned with Debian so we can swap their "old" kernels with recent LTS or recent HEAD kernels. Hope I was able to shed some light on our use-case / motivation. > Ben, > Could you comment on this? > >