public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: chombourger@gmail.com, isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 05/10] u-boot-script: Switch to wks-file class for WKS_FILE search
Date: Sat, 13 Oct 2018 15:53:50 +0200	[thread overview]
Message-ID: <e038c6ee-bea6-fb84-286f-a2f900dc99f5@siemens.com> (raw)
In-Reply-To: <c4aa145c-b200-4378-bedf-e54a188fe36b@googlegroups.com>

Hi Cedric,

On 13.10.18 08:05, chombourger@gmail.com wrote:
> Hi Jan,
> 
> It may be worth noting that the wks-file class will throw an exception when bitbake goes through available layers to parse recipes that it finds.
> This may be an issue in environments / configurations where no WKS_FILE is set even if this particular recipe isn't use. Are we mandating the use of wic now even for users only wanting ISAR to produce eg a plain ext4 image?

Does your environment incorrectly sets IMAGE_TYPE to wic-img? There is test at 
the beginning of get_wks_full_path that filters out non-wic images based on this 
condition. It shouldn't make sense to set IMAGE_TYPE this way and then not 
defining a proper WKS_FILE.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2018-10-13 13:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 11:01 [PATCH 00/10] Pending queue: various fixes, improve rebuilds on dependency changes Jan Kiszka
2018-10-08 11:01 ` [PATCH 01/10] u-boot-custom: Fix parallel build Jan Kiszka
2018-10-08 11:01 ` [PATCH 02/10] u-boot-custom: Fix comment Jan Kiszka
2018-10-08 11:01 ` [PATCH 03/10] u-boot-custom: Allow to extend or replace U-Boot build dependencies Jan Kiszka
2018-10-08 11:01 ` [PATCH 04/10] meta: Add bbclass to retrieve selected WKS file Jan Kiszka
2018-10-08 11:01 ` [PATCH 05/10] u-boot-script: Switch to wks-file class for WKS_FILE search Jan Kiszka
2018-10-13  6:05   ` chombourger
2018-10-13 13:53     ` Jan Kiszka [this message]
2018-10-13 14:49       ` Cedric Hombourger
2018-10-08 11:01 ` [PATCH 06/10] wic-img: Use wks-file class for WKS_FILE lookup Jan Kiszka
2018-10-08 11:01 ` [PATCH 07/10] wic-img: Add WKS_FILE to wic_image task checksum Jan Kiszka
2018-10-08 11:01 ` [PATCH 08/10] base: Improve detection of dependency changes Jan Kiszka
2018-10-08 11:01 ` [PATCH 09/10] linux-custom: Fix typo in KERNEL_NAME_PROVIDED variable Jan Kiszka
2018-10-08 11:01 ` [PATCH 10/10] wic-img: Fix image copy-out in do_wic_image Jan Kiszka
2018-10-10 13:27 ` [PATCH 00/10] Pending queue: various fixes, improve rebuilds on dependency changes Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e038c6ee-bea6-fb84-286f-a2f900dc99f5@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=chombourger@gmail.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox