From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6609939533494484992 X-Received: by 2002:a1c:9902:: with SMTP id b2-v6mr955468wme.4.1539438834025; Sat, 13 Oct 2018 06:53:54 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:85d5:: with SMTP id h204-v6ls2081711wmd.19.canary-gmail; Sat, 13 Oct 2018 06:53:53 -0700 (PDT) X-Google-Smtp-Source: ACcGV60KAQHknnQqUsJVdwSGpMv0M+sS4/AYwoR0yHAQ8t9d+AoLZRIylt2YGuGD/MpEx7FDRLhi X-Received: by 2002:a1c:b5c9:: with SMTP id e192-v6mr1006731wmf.22.1539438833519; Sat, 13 Oct 2018 06:53:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539438833; cv=none; d=google.com; s=arc-20160816; b=WATi0YjAmvbp3qxpjH+HuQoAnbT6NDuGxgflNm1iAWBtPTzHY9ADaSpjST9pcKznZd L1EP/WW5GCpkF2bYRbVPsYPyvX5lp7lMdKISgWogBbpKd8C2vOu/YWv8G+wth6/aaDDi O5f6bWfyP6Xr1TH4wM9RVXDNs74+S/Jvm/bv+YoqS5VxzqhxL0T+Ez/vmeZrPzfcDOoK V/Ak5RTTcw2eMFcvmpmEtswLTUHnEmg0S5tACHcjJ1hDAkIIKs9fAUGVdQHYP+dZoQnO jlNDpQ6luNrwZFEB4gnz2/3jVxmOhsRunmxbCKyxkhGkTIVZ+oM8wHtV5xAX+Ft1raZH 8myw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=ShqkTJMP2BwQOZZNZPkHny7Imsz+BTV8bB06TXODlrU=; b=I/MP8yT7rUU7wv19Q5xMLZZe4Pq7Q++9TntilAV8kRkTAlrOpmA7J9gg+PMF3RMW2L qaNQSb69tdjB8BR7VqqLDUw5h1aSWXVCy0TSfzKwjUGMYW0ufufYX/SoeKOm/SOFElmz nNTwM+hPgLVI/P0u/IO73ac0XPlQc3fshr11PFV0b4W0YDIX6NKNNi1d4AYw1WRqUkVN fVGn/cYxod59Jl5rcQBDA6vZq6dquu2nQljg/hFvhW98P6liaHvxSd2H1EHnKAx7FRwx PoH1hyJcD46aF9cByOATfHUFXVkEarrNkzn2xv0NolJnoTFTsgHZpHPaf7bJ8zztssgA V7+A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id o9-v6si134845wmh.2.2018.10.13.06.53.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Oct 2018 06:53:53 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id w9DDrqks020499 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Oct 2018 15:53:52 +0200 Received: from [167.87.3.233] ([167.87.3.233]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w9DDrpx0020221; Sat, 13 Oct 2018 15:53:52 +0200 Subject: Re: [PATCH 05/10] u-boot-script: Switch to wks-file class for WKS_FILE search To: chombourger@gmail.com, isar-users References: From: Jan Kiszka Message-ID: Date: Sat, 13 Oct 2018 15:53:50 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: FcrZetBNEumB Hi Cedric, On 13.10.18 08:05, chombourger@gmail.com wrote: > Hi Jan, > > It may be worth noting that the wks-file class will throw an exception when bitbake goes through available layers to parse recipes that it finds. > This may be an issue in environments / configurations where no WKS_FILE is set even if this particular recipe isn't use. Are we mandating the use of wic now even for users only wanting ISAR to produce eg a plain ext4 image? Does your environment incorrectly sets IMAGE_TYPE to wic-img? There is test at the beginning of get_wks_full_path that filters out non-wic images based on this condition. It shouldn't make sense to set IMAGE_TYPE this way and then not defining a proper WKS_FILE. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux