From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6525492966897745920 X-Received: by 10.28.112.6 with SMTP id l6mr443625wmc.8.1520234433931; Sun, 04 Mar 2018 23:20:33 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.52.133 with SMTP id b127ls703199wma.6.canary-gmail; Sun, 04 Mar 2018 23:20:33 -0800 (PST) X-Google-Smtp-Source: AG47ELuRczN31u54iESzDZtCM8LjnBvAKMpWbm8ckDK6zDdtwxlotGi18EXbdnkKblCHRVkjpWeR X-Received: by 10.28.190.24 with SMTP id o24mr1020956wmf.10.1520234433343; Sun, 04 Mar 2018 23:20:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520234433; cv=none; d=google.com; s=arc-20160816; b=f8h3VZe5u9tbTE+/tdVwFX2B5uYgVGzxgw/a5S0BcWkK2PekAOLTOt9z4VHSAKnFHI T0k9ZwPrFvaBns5uHLEXP3m51dBqsezFH6rVlE5g8Q+kF9Aye6OCCCNuHU7U+DZmdmOH 3d6cUKQyeU/62H+T0gcyi4RkWmTN4xo6P81BbNKN1NMW6Wy6t4hXJe/hisP2tagdVDKk ag0bsGZiculkIiIueHgxusYO60qsIuih1njpc7X4BWK9qX7Bh0n5jqiLX7qfDEq1VQdf muyqIkFoJ3sBZUzHMp4oh4ecEt+i59Ka6N+ki6SoQYzwGsG5niVZUNKUsnM32twlFwyM ulmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=IDRcrE5aaqGlsV3r3cRPatGLp6p9qFBIecFYkxOq67Q=; b=0s8ZRSUcBTD7UcOIDMbg64sX7iB29N+9Ol9ZEWYRc/xvriqF8DzsUxXI/SJZSYaBe+ UH3QrNewBXEURk9x6rcsq8IaXB/vR5nTWZ/Edh7brZIKgTorpogyMRKlDMgx+xLS+CKV thtu9qHdJyRbof3sWiBTVmIgOCpM5PPdxtjUXkquFCPV8GwRYtT4aNlhrAoM2mwZLg4o 5ljkfaGuigvDP/lUMJuTrt52sYWiXSxt5WD6m1wshoVAL78o+G2JZj0QY2Xdf1IOHTjb OPWwJ++Y5gqslYBydViGJeCNgJbVnvty5T7TRvcXuy+ROWwbEClBha60G2l+hxVAekxe 396Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id s81si301937wmd.2.2018.03.04.23.20.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Mar 2018 23:20:33 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w257KWDP014757 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Mar 2018 08:20:33 +0100 Received: from [167.87.84.81] ([167.87.84.81]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w257KWFb018711; Mon, 5 Mar 2018 08:20:32 +0100 Subject: Re: [PATCH] linux-custom: Add lock to dependency installation To: Alexander Smirnov , isar-users References: <561e3ebb-f877-596c-fde6-0f3bba770958@siemens.com> <4e09e77e-07b7-c48a-894d-1c8f156c23f6@ilbers.de> From: Jan Kiszka Message-ID: Date: Mon, 5 Mar 2018 08:20:32 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <4e09e77e-07b7-c48a-894d-1c8f156c23f6@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: MzLPQDV1b0Ct On 2018-03-05 08:16, Alexander Smirnov wrote: > > > On 02/23/2018 12:25 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> The build script of linux-custom requires the same lock protection as >> build.sh of the dpkg builder class. Otherwise, we see the infamous build >> failures again due to contention on the dpkg database lock. >> >> Signed-off-by: Jan Kiszka >> --- >>   meta/recipes-kernel/linux/files/build-kernel.sh | 6 ++++-- >>   1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh >> b/meta/recipes-kernel/linux/files/build-kernel.sh >> index 94897ec..42c8ff6 100644 >> --- a/meta/recipes-kernel/linux/files/build-kernel.sh >> +++ b/meta/recipes-kernel/linux/files/build-kernel.sh >> @@ -13,8 +13,10 @@ REPACK_DIR="$1/../repack" >>   REPACK_LINUX_IMAGE_DIR="${REPACK_DIR}/linux-image" >>   REPACK_LINUX_HEADERS_DIR="${REPACK_DIR}/linux-headers" >>   -apt-get install -y -o Debug::pkgProblemResolver=yes >> --no-install-recommends \ >> -    ${KBUILD_DEPENDS} >> +# Lock-protected because apt and dpkg do not wait in case of contention >> +flock /dpkg.lock \ >> +    apt-get install -y -o Debug::pkgProblemResolver=yes \ >> +        --no-install-recommends ${KBUILD_DEPENDS} > > The same stuff as in "meta/recipes-devtools/buildchroot/files/build.sh", > but different style. Can we keep things similar as much as possible? > > Why not > > ( >    ... > ) 42>/dpkg.lock > > ? This is if (x) y; vs. if (x) { y; z; } See also the man page of flock. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux