From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6519112020741062656 X-Received: by 10.80.243.144 with SMTP id g16mr7866edm.11.1517851928773; Mon, 05 Feb 2018 09:32:08 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.171.6 with SMTP id s6ls4426767edc.2.gmail; Mon, 05 Feb 2018 09:32:08 -0800 (PST) X-Google-Smtp-Source: AH8x226AQy5C2Oq8bwDpvfWvIJisK5Hymc2ifAuQWEqFurc/w0GiroNldHlG3tg5Sj+A8vD7jzAt X-Received: by 10.80.243.144 with SMTP id g16mr7862edm.11.1517851928079; Mon, 05 Feb 2018 09:32:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517851928; cv=none; d=google.com; s=arc-20160816; b=atg8JZyEXA25P5W0oxIVT5UiiKB/FfjbBqfR+fV+gsEK8eI3k8RUwxxnt6pDD8fgun ep/L1qwjtFNK9JF0/T9WFSl3ODu3aE5voseWB4WJw0SMUc8TTzaK1wRSajrA4XpLDssz tpPc87JNr/zvMbYdSb/3kFGmb0GQD+iWlQzMG5/fHS4/BNoKPYITBmyWgOoyy3A2bhpU 4Gs9oGPjxyTI0g9XCG9rcrBCx0S5XkhYZMbOYNLA/G0xaMdnUT8X4/7PMsvT6b0NxREM 0vXI1AcZDTG0kwLNhEWfz1GmwOP3LNrmWH3V0g+NrzCpY8neexEm6E6CcWS9aZzezp6f NsKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject :arc-authentication-results; bh=axLzk1xkZET9eA+1mKARdJdSfIPeZHuW7CXS7j7LXUI=; b=WDl55reFjCgI7XMnIz38jxqCsw9U7XrodbcyoABRRYxtraA9uHwdUwavcE6vJMOVAJ 0t+N+5MAwOIGGbs/TEvEZA1bzbK8BQ+yAwVL33IMxBmIwfHMvBDKLi4TmucjMw/I9kxf F1VubQMFSyLtapAJ35lIPWYn++vj5bhC6z4Cplp0PKOhA9Ul35+ljmuMU2o5iq4eYkra dTuDpiTCZGEy7yY019A2aiKHiva4TpNHe8PQU/RO61vgMb0eS9lDgMNOC31JfjghNYpE lcdydEi5Ejr5bfEfe2vZip1zOsJspK3XqLXBxMR1TuulcoEnrdgJKdW5COZgPXvGh8jY pVQQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id z17si745399edz.1.2018.02.05.09.32.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 09:32:08 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w15HW7Zs023970 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Feb 2018 18:32:07 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w15HW7ml005734; Mon, 5 Feb 2018 18:32:07 +0100 Subject: Re: [PATCH 2/2] buildchroot: Permanently mount '/dev', '/sys' and '/proc' From: Jan Kiszka To: Alexander Smirnov , isar-users@googlegroups.com References: <20180205164347.28375-1-asmirnov@ilbers.de> <20180205164347.28375-3-asmirnov@ilbers.de> <604637ca-63f4-524a-0484-34f38f706919@siemens.com> Message-ID: Date: Mon, 5 Feb 2018 18:32:07 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: p5rt4/rllcNI On 2018-02-05 18:30, [ext] Jan Kiszka wrote: > On 2018-02-05 18:16, Alexander Smirnov wrote: >> On 02/05/2018 07:53 PM, Jan Kiszka wrote: >>> On 2018-02-05 17:43, Alexander Smirnov wrote: >>>> Mount these folders permanently before creating buildchroot. Mounts are >>>> performed in dedicated task do_prepare, so it will also work if you run >>>> build with already existing buildchroot. >>>> >>>> BuildCompleted event is used for clean up, so we should not take care >>>> about this manually. >>>> >>>> Signed-off-by: Alexander Smirnov >>>> --- >>>>   meta/classes/isar-events.bbclass                    |  3 +++ >>>>   meta/recipes-devtools/buildchroot/buildchroot.bb    | 21 >>>> +++++++-------------- >>>>   .../buildchroot/files/configscript.sh               |  4 ---- >>>>   .../buildchroot/files/download_dev-random           | 13 ------------- >>>>   4 files changed, 10 insertions(+), 31 deletions(-) >>>>   delete mode 100644 >>>> meta/recipes-devtools/buildchroot/files/download_dev-random >>>> >>>> diff --git a/meta/classes/isar-events.bbclass >>>> b/meta/classes/isar-events.bbclass >>>> index 55fc106..9f581a6 100644 >>>> --- a/meta/classes/isar-events.bbclass >>>> +++ b/meta/classes/isar-events.bbclass >>>> @@ -15,6 +15,9 @@ python isar_handler () { >>>>             # Clean up buildchroot >>>>           subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + >>>> '/isar-apt || /bin/true', stdout=devnull, stderr=devnull, shell=True) >>>> +        subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + >>>> '/dev || /bin/true', stdout=devnull, stderr=devnull, shell=True) >>>> +        subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + >>>> '/proc || /bin/true', stdout=devnull, stderr=devnull, shell=True) >>>> +        subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + >>>> '/sys || /bin/true', stdout=devnull, stderr=devnull, shell=True) >>>>         devnull.close() >>>>   } >>>> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb >>>> b/meta/recipes-devtools/buildchroot/buildchroot.bb >>>> index 0044a71..b8aaf28 100644 >>>> --- a/meta/recipes-devtools/buildchroot/buildchroot.bb >>>> +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb >>>> @@ -12,7 +12,6 @@ FILESPATH =. >>>> "${LAYERDIR_core}/recipes-devtools/buildchroot/files:" >>>>   SRC_URI = "file://multistrap.conf.in \ >>>>              file://configscript.sh \ >>>>              file://setup.sh \ >>>> -           file://download_dev-random \ >>>>              file://build.sh" >>>>   PV = "1.0" >>>>   @@ -32,16 +31,21 @@ BUILDCHROOT_PREINSTALL ?= "gcc \ >>>>   WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" >>>>     do_prepare[nostamp] = "1" >>>> -do_prepare[dirs] = "${BUILDCHROOT_DIR}/isar-apt" >>>> +do_prepare[dirs] = "${BUILDCHROOT_DIR}/isar-apt \ >>>> +                    ${BUILDCHROOT_DIR}/dev \ >>>> +                    ${BUILDCHROOT_DIR}/proc \ >>>> +                    ${BUILDCHROOT_DIR}/sys" >>>>     do_prepare() { >>>>       sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} >>>> ${BUILDCHROOT_DIR}/isar-apt >>>> +    sudo mount --bind /dev ${BUILDCHROOT_DIR}/dev >>>> +    sudo mount -t proc none ${BUILDCHROOT_DIR}/proc >>>> +    sudo mount -t sysfs none ${BUILDCHROOT_DIR}/sys >>>>   } >>>>     addtask prepare before do_build after do_unpack >>>>     do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" >>>> -do_build[dirs] = "${WORKDIR}/hooks_multistrap" >>>>   do_build[depends] = "isar-apt:do_cache_config" >>>>     do_build() { >>>> @@ -49,7 +53,6 @@ do_build() { >>>>         chmod +x "${WORKDIR}/setup.sh" >>>>       chmod +x "${WORKDIR}/configscript.sh" >>>> -    install -m 755 "${WORKDIR}/download_dev-random" >>>> "${WORKDIR}/hooks_multistrap/" >>>>         # Multistrap accepts only relative path in configuration >>>> files, so get it: >>>>       cd ${TOPDIR} >>>> @@ -68,15 +71,6 @@ do_build() { >>>>           -e 's|##DIR_HOOKS##|./'"$WORKDIR_REL"'/hooks_multistrap|g' \ >>>>              "${WORKDIR}/multistrap.conf.in" > >>>> "${WORKDIR}/multistrap.conf" >>>>   -    [ ! -d ${BUILDCHROOT_DIR}/proc ] && install -d -m 555 >>>> ${BUILDCHROOT_DIR}/proc >>>> -    sudo mount -t proc none ${BUILDCHROOT_DIR}/proc >>>> -    _do_build_cleanup() { >>>> -        ret=$? >>>> -        sudo umount ${BUILDCHROOT_DIR}/proc 2>/dev/null || true >>>> -        (exit $ret) || bb_exit_handler >>>> -    } >>>> -    trap '_do_build_cleanup' EXIT >>>> - >>>>       # Create root filesystem >>>>       sudo -E multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f >>>> "${WORKDIR}/multistrap.conf" >>>>   @@ -85,5 +79,4 @@ do_build() { >>>>         # Configure root filesystem >>>>       sudo chroot ${BUILDCHROOT_DIR} /configscript.sh >>>> -    _do_build_cleanup >>>>   } >>>> diff --git a/meta/recipes-devtools/buildchroot/files/configscript.sh >>>> b/meta/recipes-devtools/buildchroot/files/configscript.sh >>>> index 458c94b..a5942b5 100644 >>>> --- a/meta/recipes-devtools/buildchroot/files/configscript.sh >>>> +++ b/meta/recipes-devtools/buildchroot/files/configscript.sh >>>> @@ -39,9 +39,5 @@ export LC_ALL=C LANGUAGE=C LANG=C >>>>   #run pre installation script >>>>   /var/lib/dpkg/info/dash.preinst install >>>>   -# apt-get http method, gpg require /dev/null >>>> -mount -t devtmpfs -o mode=0755,nosuid devtmpfs /dev >>>> - >>>>   #configuring packages >>>>   dpkg --configure -a >>>> -umount /dev >>>> diff --git >>>> a/meta/recipes-devtools/buildchroot/files/download_dev-random >>>> b/meta/recipes-devtools/buildchroot/files/download_dev-random >>>> deleted file mode 100644 >>>> index 5b5b96b..0000000 >>>> --- a/meta/recipes-devtools/buildchroot/files/download_dev-random >>>> +++ /dev/null >>>> @@ -1,13 +0,0 @@ >>>> -#!/bin/sh >>>> - >>>> -set -e >>>> - >>>> -readonly ROOTFS="$1" >>>> - >>>> -mknod "${ROOTFS}/dev/random" c 1 8 >>>> -chmod 640 "${ROOTFS}/dev/random" >>>> -chown 0:0 "${ROOTFS}/dev/random" >>>> - >>>> -mknod "${ROOTFS}/dev/urandom" c 1 9 >>>> -chmod 640 "${ROOTFS}/dev/urandom" >>>> -chown 0:0 "${ROOTFS}/dev/urandom" >>>> >>> >>> That should finally obsolete my /dev/null fix. But after the problem >>> with my bind-mount attempt for /dev, I'd like to validate. What is the >>> baseline this patch should go upon? >>> >> >> Rebased patch to the latest 'next', please try 'asmirnov/devel' branch. >> Also it would be helpful if you could test double ^C and broken build. >> >> It would be perfect if it works :-) >> >> NOTE: umounts are done within next 2-3 seconds after your build stopped >> It seems this time is needed to stop bitbake server context. > > Will run a couple of tests (I'm particularly good generating broken one) > and let you know. On first glance, it works as designed. Even ^C^C > followed by an immediate restart work fine (the second run waits for the > first to finish and does not complain about any dangling mounts). > OK, something that was not yet addressed: Unmounting of the workdir from the buildchroot on ^C^C. I suppose that is doable in an analogous way, right? Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux