From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6664521764891000832 X-Received: by 2002:aa7:df88:: with SMTP id b8mr612479edy.7.1552402563896; Tue, 12 Mar 2019 07:56:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:f182:: with SMTP id gs2ls4107941ejb.5.gmail; Tue, 12 Mar 2019 07:56:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzQUUU2E1IvOjjtQpAJz5M3EWUpzf96r0ka99tkkG8iA7/6l5ka6re2VqO2IowIUkB9DQFi X-Received: by 2002:a17:906:6dce:: with SMTP id j14mr4432844ejt.4.1552402563349; Tue, 12 Mar 2019 07:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552402563; cv=none; d=google.com; s=arc-20160816; b=kL4noGH/ldw15XVJyTHk2JKN7dNARQKssr0GAFCrEH1oqlIolJ6DaCeXS+2Um8FGUl LUmETkyTt5mrZVPYOb9QeOfKDKUAgIMjdYz+iinC5D8PycxMi2/6wmOfuchnhYKLF98g 3oR/oPYDf0kjnp4GoI/2M/lz758egKomCVrmNMYXfOIFo3R9dD/uj4SVXOI394Bv4xcQ CTxMHuE7MvciRNk1vivP8/upyvpB1OjqF7KtffBn5mLJednZ5kaZ+lIHEwUXf4px2Xx1 yf4jnDIps7CP7iQvwLByktT0rNtoe+DPq1SlcuKnUoRfgaN+kGsuFq7ulJVmTiFLJDRo sU3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id; bh=1NWLMul/Y/3FBETNHWvHuvkjiDd8YDZnkoXAV2b0zC4=; b=dG8l5dvXHNdBEdTN4onJqc6muGvWvYMTfu3npgnsZilcojVn9j3sed/EksCegAFI1U H6tADJCt8R3YStR9qfuN28YoY+272e3+A2KLWKRACrJjLHJ906wXq694JM/EdNIazKBZ iUhhbxOJggH7lS69xJOZY8aMwt7DqI7A+SBAZpXurSzk68wyaDU78JiJF+/J/M0JomF/ Jwxee5vjHg5II+DNktmGTObTXC5TFDPFnzO8l1atSFUKP1SyGIauQ0FoTkhwLqOG88hq IrYXZPdGoCgUaX4FAVrZ9eop1+WCFQtEulqsDQe3TkYbw5vSKjnGYtWYWQHwOozwiIA5 /PIw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id i10si420368edr.3.2019.03.12.07.56.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 07:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x2CEu26V025766 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Mar 2019 15:56:02 +0100 Received: from linux-ses-ext02.ppmd.siemens.net (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x2CEu134010863; Tue, 12 Mar 2019 15:56:02 +0100 Message-ID: Subject: Re: [PATCH v4 0/6] Python refactoring From: Claudius Heine To: isar-users@googlegroups.com Cc: Claudius Heine Date: Tue, 12 Mar 2019 15:56:01 +0100 In-Reply-To: <20190304130801.20628-1-claudius.heine.ext@siemens.com> References: <20190304130801.20628-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: lDSWMJe8SmFu This should probaly also be part of the isar release. It should fix those 'ResourceWarning: unclosed file <_io.BufferedReader name=32>' bitbake warnings. On Mon, 2019-03-04 at 14:07 +0100, [ext] claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Hi, > > I just took Haralds patchset + Maxims rebase and fixed it up. > > There was just a tiny change necessary, I added that in an additional > patch. > It builds on my machine (qemuamd64) and I am currently testing it on > isar-ci. > > If that is successful and review is ok, my patch can be merged into > the > 'Remove all uses of subprocess.call(shell=True)' or left separately. > > regards, > Claudius > > Claudius Heine (1): > isar-bootstrap-helper: get_deb_host_arch: fix decoding > > Harald Seiler (5): > Remove all uses of subprocess.call(shell=True) > Use modern python formatting > image: Remove recursion in get_image_name > wic: Refactor fakeroot script > Fix python style > > .../example-module/example-module.bb | 8 ++- > meta/classes/base.bbclass | 70 ++++++++++++----- > -- > meta/classes/image.bbclass | 22 ++++-- > meta/classes/isar-bootstrap-helper.bbclass | 8 +-- > meta/classes/isar-events.bbclass | 14 ++-- > meta/classes/patch.bbclass | 13 ++-- > meta/classes/wic-img.bbclass | 21 ++++-- > .../isar-bootstrap/isar-bootstrap-host.bb | 9 ++- > .../isar-bootstrap/isar-bootstrap-target.bb | 5 +- > .../isar-bootstrap/isar-bootstrap.inc | 12 ++-- > scripts/wic_fakeroot | 9 +-- > 11 files changed, 120 insertions(+), 71 deletions(-) > > -- > 2.20.1 >