public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: benbrenson89@googlemail.com
To: isar-users <isar-users@googlegroups.com>
Subject: WIC doesn't touch fstab for partition /boot
Date: Thu, 19 Sep 2019 04:48:53 -0700 (PDT)	[thread overview]
Message-ID: <e17f2f53-cacc-45b7-8522-d3df0b8a53d3@googlegroups.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 677 bytes --]

Hi guys,

is there any particular reason why WIC doesn't touch the fstab file if  a 
partition with the mountpoint "/boot" is specified?


I created a *.wks file with:

part /boot --source bootimg-partition --ondisk mmcblk0 --fstype=vfat 
--label boot --active --align 4 --size 200

The --ondisk parameter should trigger the fstab update but in the direct.py 
plugin the following snippet indicates that in this case
the update is skipped.

def _update_fstab(self, fstab_lines, parts):
"""Assume partition order same as in wks"""
updated = False
for part in parts:
if not part.realnum or not part.mountpoint \
or part.mountpoint in ("/", "/boot"):
  continue


Any ideas?






[-- Attachment #1.2: Type: text/html, Size: 3501 bytes --]

             reply	other threads:[~2019-09-19 11:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 11:48 benbrenson89 [this message]
2019-09-19 12:32 ` Quirin Gylstorff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e17f2f53-cacc-45b7-8522-d3df0b8a53d3@googlegroups.com \
    --to=benbrenson89@googlemail.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox