From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6605577273814810624 X-Received: by 2002:a2e:760e:: with SMTP id r14-v6mr302910ljc.37.1538033965758; Thu, 27 Sep 2018 00:39:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:ca19:: with SMTP id a25-v6ls346900lfg.15.gmail; Thu, 27 Sep 2018 00:39:25 -0700 (PDT) X-Google-Smtp-Source: ACcGV6390Wz8LZykYCLiu2ThYPdWJu1ZBA32vuy4SG+HaCgnKQwpzfgfJcC8RfpVlKhe0I04EW0W X-Received: by 2002:a19:1285:: with SMTP id 5-v6mr286796lfs.11.1538033965194; Thu, 27 Sep 2018 00:39:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538033965; cv=none; d=google.com; s=arc-20160816; b=IG/61gw0MOtb8F6Tp4o32PImcnkwP1euqA0Ym5JWLZReu6cmpcPl9Y4suyldABATWo bt6QRSWB+0/eEkyAOoxiAI3u74Z7Rqxb2BcxxhGbmgpPvLcMdjyA69wxHRLuVhOi3JR3 ovHJ9jr84SOSoWZ2Zx1rEz9grBs3PkIexbQecWmAJnQ87zZvz4Q4P1zCMAJS7Ugnv7Wg XDBz0ueOMSQ4dKh48Y6cz5NnFiOmyaAeWm8EOO+js2k1+VwLA/eFTDlE7xrRCSYgSeUR YVkYFcZzuFhiiM35rZ0/LRnxvPYzMTtXZO2aL+jm4nVDnvOJVEDadjoEPXHr2NK/I9Jx F5Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=LtuiFMUeeSgqAW3iggX4EXYUfcO7NUxVuuF4ETsH5J8=; b=YS4yLS0EwsLYxsHb+16kSbz3SVmsRcnbGheNRKgEkXsLPD/uZ6oqV6+5ipnG9YNvkT CtOqbyqk/HIvbb7fEadXquf1dzGvbe5TX1Dt1o6bLAGLOjkyXq9eIuXe/mubxKzexlME sF89PVqcDC2z40foE38NE6QUg35ueyYsJY8q8iI0v4mwAu11WmC3L+zK9QZcpuhw9+b2 bief/GGYoJ6Z1T09/0ORiKdqc5ExOkvufgxn6KJxDcTdlIoxpdn9/LA9SiSzRmiZGX9c cp8JpRKQ+X7wrfTTtxVBnektI4mhz6J0esADSzLbvvOqgzXw1kkhVnNqqCx1sYsznfsg 0kug== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id l17-v6si42640lfc.2.2018.09.27.00.39.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Sep 2018 00:39:25 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w8R7dOik025853 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Sep 2018 09:39:24 +0200 Received: from [167.87.42.189] ([167.87.42.189]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w8R7dNKJ009597; Thu, 27 Sep 2018 09:39:23 +0200 Subject: Re: [PATCH] linux-custom: Add kmod to build dependencies To: Henning Schild , Maksim Osipov Cc: isar-users References: <2a829727-34c0-4207-9d26-7489eb977b6e@siemens.com> <8955f5c1-5ad5-4221-6309-1e088affa036@siemens.com> <20180927093605.578a2e80@md1pvb1c.ad001.siemens.net> From: Jan Kiszka Message-ID: Date: Thu, 27 Sep 2018 09:39:23 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180927093605.578a2e80@md1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ttkUUwog2Bb9 On 27.09.18 09:36, Henning Schild wrote: > Am Wed, 26 Sep 2018 19:04:03 +0200 > schrieb "[ext] Jan Kiszka" : > >> On 26.09.18 18:53, [ext] Jan Kiszka wrote: >>> Recent kernels check if depmod is available and fail if not. >>> >> >> Just found out that it should be just "certain recent kernels": Our >> current CIP kernel 4.4.154-cip28 carries the commit that introduced >> that behavior while a later commit (part of 4.4.156) changes that >> into a warning again. We could live without this patch from that POV, >> but it should also cause no harm. The for us relevant depmod run >> continues to happen during installation of the generated package. > > I think we should add that, given there are releases that do need it. > It could be added in a separate += line, together with a comment. I don't think there is a need for a separate line. I can tune the commit log to explain that only some kernels are affected. Maxim, this is a candidate for the upcoming release. > > And how about bumping the cip kernel in Isar along with this patch? That would be a separate patch. Simple to write, give me a minute. Jan > > Henning > >> Jan >> >>> Signed-off-by: Jan Kiszka >>> --- >>> meta/recipes-kernel/linux/linux-custom.inc | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-kernel/linux/linux-custom.inc >>> b/meta/recipes-kernel/linux/linux-custom.inc index 10a50c3..d7595e4 >>> 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc >>> +++ b/meta/recipes-kernel/linux/linux-custom.inc >>> @@ -22,7 +22,7 @@ inherit dpkg-base >>> >>> SRC_URI += "file://build-kernel.sh" >>> >>> -KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git" >>> +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git kmod" >>> KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, >>> kmod, linux-base (>= 4.3~)" KERNEL_HEADERS_DEBIAN_DEPENDS ?= >>> "libc6, libssl1.1" >>> >> > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux