Re: [PATCH v1 3/5] dpkg: Remove unmount loop

[Jan Kiszka <jan.kiszka@siemens.com>]

On 08.07.21 16:35, Anton Mikanovich wrote:
> 08.07.2021 15:21, Jan Kiszka wrote:
>> This is very likely wrong: We know from the past (should be in the git
>> history, e.g 17d0842d) that not all subprocesses started inside the
>> chroot may have been terminated when we left it. That can cause
>> significant delays between returning from chroot and finding non-busy
>> mount points to complete all umounts. Now, if you silently fail umounts,
>> you may find inconsistently mounted chroots on the next recipe that
>> tries to remount them. Big fat warning sign...!
>>
>> Jan
> 
> Is that really correct to left background processes running from chroot?
> Even if it is, we need to control it not to let it run forever.
> Not sure how to deal with that. Set maximum run time maybe?
> 

See the commit I cited on how these issues were reproducible. The only
way to get rid of all pending processes - besides waiting for them - was
and likely still is putting them in containers.

If you can confirm that those issues are gone and explain, why, we can
obviously change the umounting scheme. But none of the patches so far
acknowledge these issues, thus have a high potential to kicking us back
to the point before the current lazy umounting scheme.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux