Re: [PATCH 1/1] Fix ZeroDivisionError for kernels without modules

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 17.04.26 11:34, Stefan Koch wrote:
> Ensure that `num_pkgs` is at least 1 to avoid division by zero.
> 
> Fixes: 88656cc9 ("generate_initramfs: fix progress reporting on dracut")
> 

I think that commit just armed the bug. It was rather introduced by
938dab363006529f0b5296dfbc09ef306fc8c3d7.

> Signed-off-by: Stefan Koch <stefan-koch@siemens.com>
> ---
>  meta/lib/rootfs_progress.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/rootfs_progress.py b/meta/lib/rootfs_progress.py
> index 6feed9df..58d16574 100644
> --- a/meta/lib/rootfs_progress.py
> +++ b/meta/lib/rootfs_progress.py
> @@ -77,7 +77,7 @@ class InitrdProgressHandler(PkgsProgressHandler):
>          m = re.search(r'^Total number of modules: ([0-9]+)', line)
>          if m:
>              # in MODULES=most mode, we install ~half of all modules
> -            self._num_pkgs = int(m.group(1)) // 2
> +            self._num_pkgs = max(1, int(m.group(1)) // 2)
>              self._stage = 'post-prepare'
>  
>      def process_line(self, line):

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e2051cb4-cc88-43bc-8582-c3a401ac5155%40siemens.com.