public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: Ulrich Teichert <ulrich.teichert@ebs-group.io>,
	Isar <isar-users@googlegroups.com>
Cc: "krypton@ulrich-teichert.org" <krypton@ulrich-teichert.org>
Subject: Re: [PATCH 1/1] Feature: Allow customization inside the schroot-run
Date: Wed, 15 Jul 2026 08:14:57 +0000	[thread overview]
Message-ID: <e21a41a788c815b9f93499ff50137775cecb9c6d.camel@siemens.com> (raw)
In-Reply-To: <DB9PR08MB7448EC13E6E04CC71C9A0D0CC3F82@DB9PR08MB7448.eurprd08.prod.outlook.com>

On Wed, 2026-07-15 at 06:54 +0000, 'Ulrich Teichert' via isar-users
wrote:
> Allow customization inside the schroot-run of image-tools-extension
> by introducing the variables IMAGER_SCHROOT_CMD (useful to inject
> a local apt-repository into the schroot), IMAGER_SCHROOT_UPDATE_OPTS
> (to add the sources list) and IMAGER_SCHROOT_INSTALL_OPTS (to inject
> options during install).

Hi,

I would like to postpone this patch until "add support to build isar
unprivileged" is merged, as this splits the imager_run path into
schroot and unshare.

Apart from that, I'm wondering if the change is really needed, as the
custom repo could also be injected into the whole build and by that
should also be accessible during imaging.

Felix

>  
> Signed-off-by: Ulrich Teichert <ulrich.teichert@ebs-group.io>
> ---
>  meta/classes-recipe/image-tools-extension.bbclass | 3 +++
>  1 file changed, 3 insertions(+)
>  
> diff --git a/meta/classes-recipe/image-tools-extension.bbclass b/meta/classes-recipe/image-tools-extension.bbclass
> index ab616b7e..5e8a8719 100644
> --- a/meta/classes-recipe/image-tools-extension.bbclass
> +++ b/meta/classes-recipe/image-tools-extension.bbclass
> @@ -49,14 +49,17 @@ imager_run() {
>  
>          E="${@ isar_export_proxies(d)}"
>          deb_dl_dir_import ${schroot_dir} ${distro}
> +        if [ ! -z "${IMAGER_SCHROOT_CMD}" ]; then ${IMAGER_SCHROOT_CMD}; fi
>          ${SCRIPTSDIR}/lockrun.py -r -f "${REPO_ISAR_DIR}/isar.lock" -s <<EOAPT
>          schroot -r -c ${session_id} -d / -u root -- sh -c " \
>              apt-get update \
>                  -o Dir::Etc::SourceList='sources.list.d/isar-apt.list' \
> +                ${IMAGER_SCHROOT_UPDATE_OPTS} \
>                  -o Dir::Etc::SourceParts='-' \
>                  -o APT::Get::List-Cleanup='0'
>              apt-get -o Debug::pkgProblemResolver=yes --no-install-recommends -y \
>                  --allow-unauthenticated --allow-downgrades --download-only install \
> +                ${IMAGER_SCHROOT_INSTALL_OPTS} \
>                  ${local_install}"
>  EOAPT
>  
> -- 
> 2.47.3
>  
> Mit
> besten Grüßen / Best regards 
> 
> Dipl.-Inform.
> Ulrich
> Teichert
> Senior
> Software Engineer
> 
> 
> T
> → +49 431 375938-0
> 
> ebs-group.io
> 
> ____________________________________
> 
> e.bs kumkeo
> GmbH
> 
> Am
> Kiel-Kanal 1 
> 
> 24106
> Kiel, Deutschland
> Geschäftsführer
> → Michael Leitner, Günter Hagspiel
> 
> Registergericht →
> Amtsgericht Hamburg
> 
> Registernummer → HRB 187712
> 
> USt-Idnr.
> → DE449906070
> 
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/DB9PR08MB7448EC13E6E04CC71C9A0D0CC3F82%40DB9PR08MB7448.eurprd08.prod.outlook.com.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e21a41a788c815b9f93499ff50137775cecb9c6d.camel%40siemens.com.

  reply	other threads:[~2026-07-15  8:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15  6:54 'Ulrich Teichert' via isar-users
2026-07-15  8:14 ` 'MOESSBAUER, Felix' via isar-users [this message]
2026-07-15  9:19   ` 'Ulrich Teichert' via isar-users
2026-07-15 10:25     ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e21a41a788c815b9f93499ff50137775cecb9c6d.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=krypton@ulrich-teichert.org \
    --cc=ulrich.teichert@ebs-group.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox