Re: [PATCH v5 1/5] meta/image.bbclass: add image_do_mounts for image specific mounts

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Cedric,

On 11/02/2019 11.49, chombourger@gmail.com wrote:
> Hi Claudius,
> 
> So the idea is that platform developers wanting to add their own mounts
> would use a bbappend to do something like?

No that is not something I envisioned here and currently I also cannot 
think of an additional mount that should be available for an image 
recipe. Do you have something in mind?

> image_do_mounts_append() {
>      sudo mount <foo> <bar>
> }
> 
> is this something we would want to add to the documentation?

That pattern follows the 'dpkg_do_mounts' patterns from the dpkg-base 
class. There is no documentation about extending mounts for that. That 
is not really an argument, but since dpkg_do_mounts is not officially 
build to be extended that way, I don't want to officially support it 
here either.

If extending available mounts more easily is a feature we need and have 
a use-case for, then I could think of ways to make build a better 
interface for this. As the patch stands now though, this is not an 
interface to be extended by other layers.

Thanks for the idea though :)

Claudius

> 
> Cedric
> 
> On Monday, February 11, 2019 at 10:09:24 AM UTC+1, claudius....@siemens.com
> wrote:
>>
>> From: Claudius Heine <c...@denx.de <javascript:>>
>>
>> Signed-off-by: Claudius Heine <c...@denx.de <javascript:>>
>> ---
>>   meta/classes/image.bbclass | 21 +++++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index d8fbfd5..bec62cd 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -14,6 +14,27 @@ IMAGE_FULLNAME = "${PN}-${DISTRO}-${MACHINE}"
>>   KERNEL_IMAGE ?= "${@get_image_name(d, 'vmlinuz')[1]}"
>>   INITRD_IMAGE ?= "${@get_image_name(d, 'initrd.img')[1]}"
>>    
>> +# Useful variables for imager implementations:
>> +PP = "/home/builder/${PN}"
>> +PP_DEPLOY = "${PP}/deploy"
>> +PP_ROOTFS = "${PP}/rootfs"
>> +PP_WORK = "${PP}/work"
>> +
>> +BUILDROOT = "${BUILDCHROOT_DIR}${PP}"
>> +BUILDROOT_DEPLOY = "${BUILDCHROOT_DIR}${PP_DEPLOY}"
>> +BUILDROOT_ROOTFS = "${BUILDCHROOT_DIR}${PP_ROOTFS}"
>> +BUILDROOT_WORK = "${BUILDCHROOT_DIR}${PP_WORK}"
>> +
>> +image_do_mounts() {
>> +    sudo flock ${MOUNT_LOCKFILE} -c ' \
>> +        mkdir -p "${BUILDROOT_DEPLOY}" "${BUILDROOT_ROOTFS}"
>> "${BUILDROOT_WORK}"
>> +        mount --bind "${DEPLOY_DIR_IMAGE}" "${BUILDROOT_DEPLOY}"
>> +        mount --bind "${IMAGE_ROOTFS}" "${BUILDROOT_ROOTFS}"
>> +        mount --bind "${WORKDIR}" "${BUILDROOT_WORK}"
>> +    '
>> +    buildchroot_do_mounts
>> +}
>> +
>>   inherit ${IMAGE_TYPE}
>>    
>>   # Extra space for rootfs in MB
>> -- 
>> 2.20.1
>>
>>
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de