public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
To: "Adithya.Balakumar@toshiba-tsip.com"
	<Adithya.Balakumar@toshiba-tsip.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"amikan@ilbers.de" <amikan@ilbers.de>
Cc: "shivanand.kunijadar@toshiba-tsip.com"
	<shivanand.kunijadar@toshiba-tsip.com>,
	"sai.sathujoda@toshiba-tsip.com" <sai.sathujoda@toshiba-tsip.com>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>,
	"kazuhiro3.hayashi@toshiba.co.jp"
	<kazuhiro3.hayashi@toshiba.co.jp>,
	"dinesh.kumar@toshiba-tsip.com" <dinesh.kumar@toshiba-tsip.com>
Subject: Re: [PATCH 0/2] Fix reproducibility of /etc/shadow file when image built on different days
Date: Mon, 4 Mar 2024 14:34:03 +0000	[thread overview]
Message-ID: <e2bd32ef32460500bcf856154ea506cf7f34d448.camel@siemens.com> (raw)
In-Reply-To: <20240304103716.1100116-1-Adithya.Balakumar@toshiba-tsip.com>

On Mon, 2024-03-04 at 16:07 +0530, Adithya Balakumar wrote:
> The third field in the /etc/shadow file (sp_lstchg) contains the date
> of
> the last password change expressed as the number of days since Jan 1,
> 1970.
> As this is a relative time, creating a user today will result in:
> 
> username:17238:0:99999:7:::
> whilst creating the same user tomorrow will result in:
> 
> username:17239:0:99999:7:::
> 
> This impacts reproducibility of images when built on different days.
> 
> Since /etc/shadow honours SOURCE_DATE_EPOCH, this patchset makes the
> SOURCE_DATE_EPOCH variable available when the /etc/shadow file is
> created/modified.

Good catch! Thanks for finding and fixing.

Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>

Felix

> 
> Adithya Balakumar (2):
>   isar-bootstrap.inc: Export SOURCE_DATE_EPOCH variable
>   image-account-extension.bbclass: Export SOURCE_DATE_EPOCH variable
> 
>  meta/classes/image-account-extension.bbclass        | 5 +++++
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 4 ++++
>  2 files changed, 9 insertions(+)
> 
> -- 
> 2.39.2
> 
> 

-- 
Siemens AG, Technology
Linux Expert Center



      parent reply	other threads:[~2024-03-04 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 10:37 Adithya Balakumar
2024-03-04 10:37 ` [PATCH 1/2] isar-bootstrap.inc: Export SOURCE_DATE_EPOCH variable Adithya Balakumar
2024-03-04 16:06   ` Gylstorff Quirin
2024-03-05  4:33     ` Adithya.Balakumar
2024-03-04 10:37 ` [PATCH 2/2] image-account-extension.bbclass: " Adithya Balakumar
2024-03-05  4:19   ` Uladzimir Bely
2024-03-05  4:38     ` Adithya.Balakumar
2024-03-04 14:30 ` [PATCH 0/2] Fix reproducibility of /etc/shadow file when image built on different days Jan Kiszka
2024-03-04 14:34 ` MOESSBAUER, Felix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2bd32ef32460500bcf856154ea506cf7f34d448.camel@siemens.com \
    --to=felix.moessbauer@siemens.com \
    --cc=Adithya.Balakumar@toshiba-tsip.com \
    --cc=amikan@ilbers.de \
    --cc=dinesh.kumar@toshiba-tsip.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kazuhiro3.hayashi@toshiba.co.jp \
    --cc=sai.sathujoda@toshiba-tsip.com \
    --cc=shivanand.kunijadar@toshiba-tsip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox