public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: srinuvasan.a@siemens.com, isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: Re: [PATCH] Drop redundant expand=True parameter from getVar
Date: Fri, 24 May 2024 11:38:39 +0300	[thread overview]
Message-ID: <e2ca4ce6-7546-4de3-9da0-483cdf1ca597@ilbers.de> (raw)
In-Reply-To: <20240524065241.1393937-1-srinuvasan.a@siemens.com>

24/05/2024 09:52, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> It is long True by default, but people keep adding new cases of this
> redundancy, hence fix this one.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>   meta/recipes-kernel/linux/linux-custom.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
> index 0d222332..433ed057 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ d.getVar('BPN').partition('linux-')[2]}"
>   
>   # Determine cross-profile override
>   python() {
> -    if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in d.getVar("OVERRIDES", True).split(":"):
> +    if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in d.getVar("OVERRIDES").split(":"):
>           d.appendVar("OVERRIDES", ":cross-profile")
>   }
>   

Hello Srinuvasan,

This was already fixed in next by:
7505bd07 ("linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE")


  parent reply	other threads:[~2024-05-24  8:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24  6:52 srinuvasan.a
2024-05-24  7:27 ` MOESSBAUER, Felix
2024-05-24  8:38 ` Anton Mikanovich [this message]
2024-05-27  5:38   ` Srinuvasan Arjunan
2024-05-28  6:20   ` [PATCH v1] " srinuvasan.a
2024-06-03  6:37 ` [PATCH] " Uladzimir Bely
  -- strict thread matches above, loose matches on Subject: below --
2023-02-28  7:24 Jan Kiszka
2023-03-06  6:03 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2ca4ce6-7546-4de3-9da0-483cdf1ca597@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=srinuvasan.a@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox