RE: [PATCH] isar-bootstrap: preserve environment in sudo'ed debootstrap call

["Hombourger, Cedric" <Cedric_Hombourger@mentor.com>]

Hi Henning,

I was also curious about this export_proxies() thing and looked at its implementation as I was not understanding how the E variable was being used
export_proxies() expands to True if it succeeded. It is a python function that puts http_proxy and friends into the environment. When we execute
the shell block passed to sudo, the Python code will evidently have no effect. If unsure, take a look at the generated run.do_bootstrap script.

I missed the export_proxies() call we have towards the end of the sudo block. That's a good catch. Will update my patch

Cedric

-----Original Message-----
From: Henning Schild [mailto:henning.schild@siemens.com] 
Sent: Thursday, September 13, 2018 2:36 PM
To: Hombourger, Cedric <Cedric_Hombourger@mentor.com>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH] isar-bootstrap: preserve environment in sudo'ed debootstrap call

Am Thu, 13 Sep 2018 14:20:58 +0200
schrieb Cedric Hombourger <Cedric_Hombourger@mentor.com>:

> Make bitbake add proxy environment variables and preserve them when 
> calling debootstrap under sudo. This is required to get user-defined 
> proxies used while bootstraping Isar.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index 
> 4010307..a936e7f 100644 --- 
> a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ 
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -171,7
> +171,8 @@ isar_bootstrap() { esac
>          shift
>      done
> -    sudo flock "${ISAR_BOOTSTRAP_LOCK}" -c "\
> +    E="${@bb.utils.export_proxies(d)}"
> +    sudo -E flock "${ISAR_BOOTSTRAP_LOCK}" -c "\
>          set -e
>          if [ ! -e "${DEPLOY_ISAR_BOOTSTRAP}" ]; then
>              if [ -e "${ROOTFSDIR}" ]; then @@ -179,7 +180,6 @@ 
> isar_bootstrap() {
>                 umount -l "${ROOTFSDIR}/proc" || true
>                 rm -rf "${ROOTFSDIR}"
>              fi
> -            E="${@bb.utils.export_proxies(d)}"
>              if [ ${IS_HOST} ]; then
>                  ${DEBOOTSTRAP} --verbose \
>                                 --variant=minbase \

So you are pulling that thing out of the sudo? How does that change what is happening? One way or the other, the environment should be as expected.

The other thing i was wondering, why is this export_proxies expression in the flock-block twice?

If there is a difference in doing the export_proxies before "sudo flock", please explain why it should be outside. And remove the second inner export_proxies if possible.

Henning