From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6724322178273116160 X-Received: by 2002:adf:f30e:: with SMTP id i14mr13791182wro.288.1565683277825; Tue, 13 Aug 2019 01:01:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7018:: with SMTP id l24ls266357wmc.3.canary-gmail; Tue, 13 Aug 2019 01:01:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtKVdc2SYjQlfB/PlnayMV1HDOJ8Oh5BNr8ZRoUQX4MZcNdgImsWwa4aiUX4MNtZ0HK+wg X-Received: by 2002:a05:600c:2111:: with SMTP id u17mr1676567wml.64.1565683277291; Tue, 13 Aug 2019 01:01:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565683277; cv=none; d=google.com; s=arc-20160816; b=sh4yJldsPTW5ohni5x4iJLsNMt5oAlFiZDDGo4GRXtbqOvLuxZ+gf2uHNfcSzj9zWF fAT/K9SU1Jpjq3lr2fqX7AR2fgLg4WIiVeo4IRKFzd5gHCUpo0OjOT28BylDN2QznpoU EksZxbmfAmXckhAdNA4i7vPCxdEkgocLvUIAkbs1jjt52JNpEIu9XLXQTOa7ETg0+xDh OurSqA96MglYGTRtzvVAOu5x7i9Xoarace7dPPHFSFeQ4DlfS8+GsojzmDRWz78Ls1ME SdmqgJF+5g37DlTYEJjFCfNsMm5xjRVwbvtRyNmg5NvCPjKLUQtUZr8nhuN3Cx4J3Ik2 2WKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=wXE/6gxjNlZ6YnXOh0EsL9Dw9wVvQwcJADL/+ctnznM=; b=eVs3637eawZwfvHiLFhP0/40FIxZJ38Zn7damARPDWMDPd4kwSw2hsK2i3Gkaxs6TK Gwz4K6JmROUmmAVGgub97dzYmUiAs21eIVoKuU7mal16n2vBCbclGaScRa1sgfDYnZ4n E9LFHrejh/RwHF5sXtxhVKZst0D7Wcg+fQWmekvJ5VJ80hB/kV+DH3R94XpONnFBMi2Z D4R1wZWpZEOiv8VhuDeTkyHULEgoHBIpQYJ/Hma0LwFfoHshZx4frxjWK98O3zL2qtNF 4Romjy4l//8lLouU842MGaHqZ7wI7v31FHNTX/wd87UB+O+8+cDP2kEQ+CfIRSSk/6fx LvyA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id y4si2456507wrp.0.2019.08.13.01.01.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 01:01:17 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x7D81GFY027718 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Aug 2019 10:01:16 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7D81FT0012088; Tue, 13 Aug 2019 10:01:15 +0200 Subject: Re: [PATCH v2] Set STAMPCLEAN variable To: Claudius Heine , isar-users Cc: Claudius Heine References: <4b5f25df-8a9d-fa99-59e0-1a2730f12654@siemens.com> <81fcc2f2-341e-4730-abeb-58b4d8bc06de@siemens.com> From: Jan Kiszka Message-ID: Date: Tue, 13 Aug 2019 10:01:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <81fcc2f2-341e-4730-abeb-58b4d8bc06de@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: 6SuUtnT0oXaH On 13.08.19 09:27, Claudius Heine wrote: > Hi Jan, > > On 12/08/2019 19.15, [ext] Jan Kiszka wrote: >> From: Jan Kiszka >> >> This ensures that stamp files are cleaned when a task is rebuilt. Not >> providing this pattern likely caused a lot of failures when doing >> partial rebuilds. >> >> As we are at it, switch do_clean to STAMPCLEAN as well. >> >> Signed-off-by: Jan Kiszka >> --- >>   meta/classes/base.bbclass | 4 ++-- >>   meta/conf/bitbake.conf    | 1 + >>   2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >> index ca80bf8..b6638ca 100644 >> --- a/meta/classes/base.bbclass >> +++ b/meta/classes/base.bbclass >> @@ -206,8 +206,8 @@ python do_clean() { >>       workdir = d.expand("${WORKDIR}") >>       subprocess.check_call(["sudo", "rm", "-rf", workdir]) >> -    stamppath = bb.data.expand(d.getVar('STAMP', False), d) >> -    stampdirs = glob.glob(stamppath + ".*") >> +    stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d) >> +    stampdirs = glob.glob(stampclean) >>       subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs) >>   } >> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> index 3d18223..003fb01 100644 >> --- a/meta/conf/bitbake.conf >> +++ b/meta/conf/bitbake.conf >> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}" >>   AUTOREV = "${@bb.fetch2.get_autorev(d)}" >>   SRC_URI = "file://${FILE}" >>   STAMP = "${TMPDIR}/stamps/${PF}" >> +STAMPCLEAN = "${STAMP}*" > > I would rather go with "${TMPDIR}/stamps/${PN}-*". > > OE/YP remove the stamps of other recipe versions as well. > > This is what OE/YP does: > >   STAMPS_DIR ?= "${TMPDIR}/stamps" >   STAMP = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${EXTENDPE}${PV}-${PR}" >   STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*" What would be the scenario where this helps? Just trying to understand. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux