Re: [PATCH 1/2 v3] fix premature success dialog in installer script

["'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>]

On Wed, 2025-08-20 at 15:04 +0530, 'Kasturi Shekar' via isar-users
wrote:
> The 'Installation successful' message was displayed before the
> progress bar completed. Fixed by tracking the dialog --gauge PID
> and terminating it after bmaptool finishes. This ensures
> the progress bar runs to 100% before showing the final message.

Hi,

I really have a hard time following this series. There are at least 3
"v3" series on the ML, whereby only the first patch is tagged with v3.
Please generate the patches with git format-patch --subject-
prefix="PATCH v3" and send them with git send-email.

Please also add the whole changelog from the initial version on to the
cover letter. This helps to get an overview what changed over time.

I'll do a review on the v4, if there will be any.

Best regards,
Felix

> 
> Changes:
> - Tracked the PID of the dialog --gauge process.
> - Killed gauge process after bmaptool completed.
> - Ensured success message is shown only after the progress bar ends.
> 
> Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
> ---
>  .../deploy-image/files/usr/bin/deploy-image-wic.sh            | 4
> ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta-isar/recipes-installer/deploy-
> image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-
> installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> index aba81c84..fa1061c1 100755
> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-
> image-wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-
> image-wic.sh
> @@ -183,12 +183,16 @@ if version_ge "$bmap_version" "3.6"; then
>          done
>      ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
>  
> +    gauge_pid=$!
>  fi
>  
>  if ! bmaptool ${quiet_flag} copy ${bmap_options}
> "$installer_image_uri" "${installer_target_dev}"; then
> +    kill "$gauge_pid"
>      exit 1
>  fi
>  
> +kill "$gauge_pid" 2>/dev/null
> +
>  if ! $installer_unattended; then
>      dialog --title "Reboot" \
>             --msgbox "Installation was successful. System will be
> rebooted. Please remove the USB stick." 6 60
> -- 
> 2.39.5

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e3c59c2c37a9a9661576aeb57a1bf8d6781ef526.camel%40siemens.com.