Re: [PATCH] dracut: quote DRACUT_EXTRA_MODULES/DRIVERS for --add

["'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>]

On Tue, 2026-06-30 at 07:43 -0400, 'Rakesh Kumar' via isar-users wrote:
> extend_dracut_cmdline() joined multiple modules/drivers into the
> --add / --add-drivers arguments without quoting. With more than one
> entry the shell split the list, so dracut consumed only the first
> module and treated the rest as positional arguments (the output image
> path), breaking initramfs generation. Quote the lists so they are
> passed as a single argument.

+ CC Quirin

Hi, good catch, but please also add a fixes tag.

> 
> Signed-off-by: Rakesh Kumar <kumar.rakesh@siemens.com>
> ---
>  meta/classes-recipe/initrd-dracut.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes-recipe/initrd-dracut.bbclass b/meta/classes-recipe/initrd-dracut.bbclass
> index bb4b50b7..542b1fbe 100644
> --- a/meta/classes-recipe/initrd-dracut.bbclass
> +++ b/meta/classes-recipe/initrd-dracut.bbclass
> @@ -48,9 +48,9 @@ def extend_dracut_cmdline(d):
>      if config_path:
>          cmdline.append(f"--conf {config_path}")
>      if extra_drivers:
> -        cmdline.append(f"--add-drivers {extra_drivers}")
> +        cmdline.append(f'--add-drivers "{extra_drivers}"')

Nit: Wouldn't it be better to use single quotes around {extra_drivers}
to ensure shell variables are not expanded within the quote?

Felix

>      if extra_modules:
> -        cmdline.append(f"--add {extra_modules}")
> +        cmdline.append(f'--add "{extra_modules}"')
>      return ' '.join(cmdline)
>  
>  ROOTFS_INITRAMFS_GENERATOR_CMDLINE:append = " ${@ extend_dracut_cmdline(d)}"
> -- 
> 2.39.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260630114346.14229-1-kumar.rakesh%40siemens.com.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e476705159572054515bfee28cdfac2f27441ef5.camel%40siemens.com.