From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6724322178273116160 X-Received: by 2002:a2e:144f:: with SMTP id 15mr864lju.226.1565791866448; Wed, 14 Aug 2019 07:11:06 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:91d9:: with SMTP id u25ls279387ljg.15.gmail; Wed, 14 Aug 2019 07:11:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzuamIYMv3IjTKTKvyO7CNCb+eLrVcmXWjJl6ytnCiAVlubNqSBn3+H1/Gc1vburno5SOoa X-Received: by 2002:a2e:b0c6:: with SMTP id g6mr18266ljl.60.1565791865831; Wed, 14 Aug 2019 07:11:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565791865; cv=none; d=google.com; s=arc-20160816; b=fMp6BWxoe+WrWcwkJ2E1FvugNexJ/6Y+irgfhep4wB58JmLAxR4G+oSUtt23x0WSL/ bdwSGr2oO+E6OpZyfMQleHscqiA6wl5bFR61oLv4s4Ht85stWZeGUcWCrPDdVOTVNauN JpS3C5TscMV9i3jJ/v62I4IKosQ7UuSK0K9lbcsFunnlHvD2+LanICsPTh4hFcvfLI30 cKA0eSHr8u1nWBzaVxGnolUWTVEQIUK4odPNYM9mZPcrRaTSKTlxlj6uJxzYBTphlQ8L APsdSHNB5prjd2/TrtH1IxLy1YIlUQKV2oZGO4a5RBLUoGZTKZo62QbjmBcKKh5v3r88 uwQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:organization :openpgp:from:references:to:subject; bh=U1uJE+atsTk0wRwLOjplnPAXAC+Ues3dc4sEs9X47lQ=; b=XoMg6euJ9by6tYjhzb2YXh2RHuxspRMp6pLJMu+0F8xBacmNXRUVBR/qMbm34KaUfl krASfPhKfCFlIc8jTeXPLhrGdPVtYbSekmJcpWsSufvd1YzIwsi0URzi2bRe5oyyLz3x pUf4R84tIcWBIFhoeJ36xPMCpc6uRPP3GWZlUUVdhDRHuXKHa9eO16ib4w+nGpZ+4u+c nej3sANqxWs1AYofmQ8Bt9Fac1bkJZRpfr5vVVZlC2tJIipX0x/w6L6Wbll1m3u7xLE+ Sr37s0s+bN8HMZ6XwIPjt64MeldLWJs6qTxl5C3O7zhaWNvuTGEL/x9qZVnSPaHUW1TA 4PWg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id t23si1618095lfk.2.2019.08.14.07.11.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 07:11:05 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 467s211NPFz1rKJC; Wed, 14 Aug 2019 16:11:05 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 467s2119XFz1qqkX; Wed, 14 Aug 2019 16:11:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 9GOgdTxTaUHI; Wed, 14 Aug 2019 16:11:04 +0200 (CEST) X-Auth-Info: 8pZVQymGYYhVZQOgd0/RT5DNY+rI7dEtd7V5sNkKfys= Received: from [10.0.201.101] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 14 Aug 2019 16:11:04 +0200 (CEST) Subject: Re: [PATCH v2] Set STAMPCLEAN variable To: Jan Kiszka , isar-users References: <52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com> From: Claudius Heine Openpgp: preference=signencrypt Organization: Denx Software Engineering Message-ID: Date: Wed, 14 Aug 2019 16:10:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="W1FDms2HwRu0DsOFhc6zA9Gq7AXo1N5Fb" X-TUID: LzjRfrETQzAJ This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W1FDms2HwRu0DsOFhc6zA9Gq7AXo1N5Fb Content-Type: multipart/mixed; boundary="F6jQrADDHWgL3ieVwKJX715GfMJv0oTxL"; protected-headers="v1" From: Claudius Heine To: Jan Kiszka , isar-users Message-ID: Subject: Re: [PATCH v2] Set STAMPCLEAN variable References: <52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com> In-Reply-To: <52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com> --F6jQrADDHWgL3ieVwKJX715GfMJv0oTxL Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Jan, you probably mean v3. On 14/08/2019 14.39, Jan Kiszka wrote: > This ensures that stamp files are cleaned when a task is rebuilt. Not > providing this pattern likely caused a lot of failures when doing > partial rebuilds. >=20 > As we are at it, switch do_clean to STAMPCLEAN as well. >=20 > Signed-off-by: Jan Kiszka > --- > meta/classes/base.bbclass | 4 ++-- > meta/conf/bitbake.conf | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index ca80bf8..b6638ca 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -206,8 +206,8 @@ python do_clean() { > workdir =3D d.expand("${WORKDIR}") > subprocess.check_call(["sudo", "rm", "-rf", workdir]) > =20 > - stamppath =3D bb.data.expand(d.getVar('STAMP', False), d) > - stampdirs =3D glob.glob(stamppath + ".*") > + stampclean =3D bb.data.expand(d.getVar('STAMPCLEAN', False), d) > + stampdirs =3D glob.glob(stampclean) > subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs) > } > =20 > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 3d18223..ee86ee0 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -36,6 +36,7 @@ S =3D "${WORKDIR}/${P}" > AUTOREV =3D "${@bb.fetch2.get_autorev(d)}" > SRC_URI =3D "file://${FILE}" > STAMP =3D "${TMPDIR}/stamps/${PF}" > +STAMPCLEAN =3D "${TMPDIR}/stamps/${PN}-*" What I did come across when looking at the commit messages of OE was, that they used to have all stamps in just one directory. They changed that, because they and problems when a recipe name 'recipe-1.2.3' removing stamps from a recipe named 'recipe-name-4.5.6'. Maybe we should really copy what current OE upstream does. Like this: STAMPS_DIR ?=3D "${TMPDIR}/stamps" STAMP =3D "${STAMPS_DIR}/${PN}/${PV}-${PR}" STAMPCLEAN =3D "${STAMPS_DIR}/${PN}/*-*" kind regards, Claudius > SVNDIR =3D "${DL_DIR}/svn" > T =3D "${WORKDIR}/temp" > TMPDIR =3D "${TOPDIR}/tmp" >=20 --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --F6jQrADDHWgL3ieVwKJX715GfMJv0oTxL-- --W1FDms2HwRu0DsOFhc6zA9Gq7AXo1N5Fb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQI/BAEBCgApFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAl1UFncLHGNoQGRlbngu ZGUACgkQEXPLGZgIsVOJmxAAoF5GENnv2uFqcqOeQ7cH3NKeXTySpWyg0MmoJb3A QInBIE1QQckzJ7/dC1Xnr3FI10Ff8+SUJoCH8XDQYJUmAwvvSw5TR5Eo7jcRA98i P0wZ8ypZTrtrdg8O2w6HiWF2K9hxKQBk1Vb4VyuLzNEKY1GV0WAwxz3J43pog/hv lKqXdC0KmighdKuNJP+BRWpg+Zz83WRSfNZN4EaERAq6kvxH0ixR9PPgSM14kTef r8+qrSolu2HysPbTYOvZlCsRzCPJ1Viegf9NkSID43v4DM9FBqWktHvGwEBe/7kA MFq8UzimUZDx5hOPBaBIlhLROtY3vVQeEEM2fGvfi2dm6aoWzWuztj8yTqeZIEN9 JdZA/dmfdK/aSHCd5qpBckee41+K241HtM5miW6IkcgPJMIMRNBbw5ZTE5UUmgm1 jLVjv9Ttd9aOsPcq8qjszkzNttRcsVPbI0maxOGYt+s0IT0+uEf03O1gDbdD5iAG EmrHEP9+IZQcE/tqxM77oR2AGmT5Xb2+77Ljkinv/b2Eps5KhFUTy8p+Vq73SOBm Z/uZe6kddLf55VFUcPyXWrg/UxpHN9Yb4HdtId/Sf0PaidTvWuehPIsGUMPf/Swx X71P29UHrRD5Oo+SWEhPJ2zNOPK1oBmFHANVI7dms4gCZbgmKXeBzW1Cp0i6rxIW aDQ= =7ol8 -----END PGP SIGNATURE----- --W1FDms2HwRu0DsOFhc6zA9Gq7AXo1N5Fb--