Re: [PATCH 05/10] linux-mainline: fix stripping of .0 from the kernel version

[Jan Kiszka <jan.kiszka@siemens.com>]

On 24.10.19 11:02, Cedric Hombourger wrote:
> The strip() function was used to strip the trailing .0 from the kernel
> version since it is omitted in the upstream archive file names. That
> function is actually taking a character set as argument not a substring.
> This was causing ARCHIVE_VERSION to expand to "4.19.8" when the user
> provided version was "4.19.80". The inline python code was changed to
> check if the version ends with ".0" and only then remove the last two
> characters.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta-isar/recipes-kernel/linux/linux-mainline_4.19.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-isar/recipes-kernel/linux/linux-mainline_4.19.0.bb b/meta-isar/recipes-kernel/linux/linux-mainline_4.19.0.bb
> index e50e149..127f6e2 100644
> --- a/meta-isar/recipes-kernel/linux/linux-mainline_4.19.0.bb
> +++ b/meta-isar/recipes-kernel/linux/linux-mainline_4.19.0.bb
> @@ -7,7 +7,7 @@
>  
>  require recipes-kernel/linux/linux-custom.inc
>  
> -ARCHIVE_VERSION = "${@d.getVar('PV').strip('.0')}"
> +ARCHIVE_VERSION = "${@ d.getVar('PV')[:-2] if d.getVar('PV').endswith('.0') else d.getVar('PV') }"
>  
>  SRC_URI += " \
>      https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-${ARCHIVE_VERSION}.tar.xz \
> 

Oh, yeah... good one.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux