From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7325384040194768896 X-Received: by 2002:a92:d30c:0:b0:360:95e8:e6e4 with SMTP id x12-20020a92d30c000000b0036095e8e6e4mr831173ila.24.1705574065405; Thu, 18 Jan 2024 02:34:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a92:c6d1:0:b0:361:9a15:d538 with SMTP id v17-20020a92c6d1000000b003619a15d538ls439604ilm.0.-pod-prod-06-us; Thu, 18 Jan 2024 02:34:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwpbWl0fSW6hLV6UrO+XDaBQ8/ukvbN7WdHsFvzITxq152zP2t/F6TtI7XXQm3sKJyNgAH X-Received: by 2002:a6b:4917:0:b0:7bf:34a8:3d86 with SMTP id u23-20020a6b4917000000b007bf34a83d86mr705265iob.23.1705574064337; Thu, 18 Jan 2024 02:34:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705574064; cv=pass; d=google.com; s=arc-20160816; b=ETNjSyJ89IAe53xTEv3ZNTANHQ4tqT2p9/R10+CUeS5PZwlnEHC10TP2vekq/LDa6q 8DZ0yKGSmHHmMbC2uVhkhZZQIPVdAV0ALzs1Z0njU8e6mAD+J6jnwyLPRoB+32cZZwpk kTYQAh5xuf+1mdWp54+hccOgQbpoY0EZ/K9in7WDMbfEyrLZJ/rl87H7Q/GetU0zo39s Tf4avltFruhM+iWMIc7QkLYhJFq4wf2+9VeVrbjFbjbEWwM3u1DSRHV++de1IzYvI1Rf HNafDNDXw+oGarNPmhXln/N8E1nU3fxyimAFjLa/vzgiqWX0RVcOrQGQL5xllA8wEfdU uD2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=z6/Xe3ITUfsrHc85Nvvy/TxaIUXd55Kq5UT97o/mqg4=; fh=ez+yYIN2+t1/A1KtVD1essDQ6+anTTnZTbSXjuK9WaU=; b=qbhBz37jMjQVZq7LpZhcPsK25jLadTCmsGff/JrkC5GXG1KAb9j9W87GQwEp3OQmIE xjhWGPR1IQgy4vvFzof690sT9kepZxcySkb4fpzkpkYNFnEOWleFCEZQo/T+bgTW8f5n dwQs+67rW2G1AGiM2DxvQN3eawFV8pplNgoZ13LKdXkj9P1j9Ar85hHeSV++Fp/0FcR2 alRYCvHIkOk6Ml7MlQ4/2NNyqxcga0qtTlLNlxfGshT8mJKOMZVpEY0o5PgSTYOOiFQ+ Jfnd/pls05l9ahagaLDm/6LcjdhJ2BcRdYpe61n2AfxAdaiUS2PB+Uc3x2qibe7rjjiP Sh5A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=r94gv9nl; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:260d::600 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20600.outbound.protection.outlook.com. [2a01:111:f403:260d::600]) by gmr-mx.google.com with ESMTPS id z13-20020a6bc90d000000b007bef819c955si1936485iof.1.2024.01.18.02.34.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2024 02:34:24 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:260d::600 as permitted sender) client-ip=2a01:111:f403:260d::600; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=r94gv9nl; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:260d::600 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHHnwE7LegnFcGsPdOBl6bJTlwFz7Bb14U/9HGagGPOlencrTMRciswDUbVRqucwL6xgQJzZJYsakahv0CQ+MAxoKvXCTItyaLPfB+rlKgMfsRb8bfMHxRZJsb2lksv5P3aeOrNBokA9KRcW8uv7kf+iiLCh8Z1Bx2hSZejqaDeJUpRzWhyk7jQVPoS0ngLzyeuMW1+8SsYBpTw9Fy7ul1L8RReMTXSEvhbryGSCgPtAv2PdfPh8WrgxNWEj7oMmfVNgKul0MbxJadCi98L/EWIyEBcLYGLyJj3fDZDRS9Yj7VVmYqeRjCxHZFkhTHqfWNMsiH0LUavVdljBuLBzFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6/Xe3ITUfsrHc85Nvvy/TxaIUXd55Kq5UT97o/mqg4=; b=azyQosU0ApACiEprhis7+A8pYiPjJcyGUjS1vIRl7A8DP1UQs39a45eFbnJzAxGOG0LZ+thBKgEKhowFRzWKtPd/8fp7XBxBATLfhJiJim+Kji9kKEUuERvO2FySkrJlpTE7YtnN5Q7aK7KlsJZTgtjFunCiQMtARp/RksDtT15y+wL6JlioKAkBqQPfa0ka4Bf2FY8ccf8qblABlMXsimULASElV1BJwNAay/k87fKEDaWTG0Mprc1TKbIoPtM1sZoZOI2jtmYLU/BSAwhEzECvnDVi1/YRowkezaYN7mCSP+quvkDaXE8i8o6pG5hsTgZLKFC0LF1OeW+sy9bajg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6/Xe3ITUfsrHc85Nvvy/TxaIUXd55Kq5UT97o/mqg4=; b=r94gv9nliVjM1CYR2NukWSJ/jDE71OFxqnsfLPj6A39adCFDEitzPHjJpFGydGzzRW0w+Fh4vczvci/AAVTTyT+T4E8aRzFPLiwHP5aUkwXl4rY5L1WzlmraetjSVYI/N/hgnHHDpr2vUdv243kvqIyIT15aCycoHFPOBl+ozjBlGq3uC2OPPKCwolj49P7nHMp++kRsXZHb1l3MNNszKi4HWAGcWhmmRNDuCUG1nT5ANsKNehecS8pFfi+jAEqh4D5w2SK8lCwAPVDC9QkbtSAhF3iPA3uqTZF1Q6RDZm2U2z3RMaC5H6ri4K9qbAUrj9BXltd7hOgkc7le9DVPQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DBAPR10MB4073.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:1ca::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Thu, 18 Jan 2024 10:34:22 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe%3]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 10:34:22 +0000 Message-ID: Date: Thu, 18 Jan 2024 11:34:20 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] auto disable cross for kmod build against distro kernels Content-Language: en-US To: Felix Moessbauer , isar-users@googlegroups.com References: <20240118103102.658035-1-felix.moessbauer@siemens.com> From: Jan Kiszka In-Reply-To: <20240118103102.658035-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::21) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DBAPR10MB4073:EE_ X-MS-Office365-Filtering-Correlation-Id: 728c1016-5c80-489d-df2b-08dc181108ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cZnagDcUizIveoyCp3qoCNztm2kJBsShV/dHo58v/VThMUsGytA9Pwgtc1TZ7V6NJNlyqXEEruI/YkHOAwX+n1mM1nKB/5+rgOfjKHC0G+lQj9UsFzC6jdeweQiTHBD+ByqlOM53+lJo3WK03s9A3alYIUIcWjXTG4eYmL313xOQlakCMNFvIXizWenY/KLqI0qvGGMBdmHOyBapTacfK7P1jpVRYG35gAqPMsN7+aCRkgrdDPyt7SVuOjTaV3BRE4qZCv3o5WtI+JzTauxyOjmgY4jUSn4h0YpZI8yX2t0C9Ld4QdGE5ULYHrowEHKy73q9UMWXd5Wu3k6OaBscP3qoLy0DoICeVVs0JmNI6TzWVK1s8Urfn8FW08I9UOjWv1rv2kvOY4Sghk/oPFGKBJHEIYDJj5J/bzh1VtzKUxH5P9rWVeeheCS/+LxmSIwAe6SUdGor/tSqxHfDfkvCFe5Z/dWWH+g1zakkoByGUKprz0lUiFo7ykKU9MxxfVQQx1ZJC9HsJBnd2oy0fQ4tzEyCO0LmHyLwLsanM6jwtoPezZpHVdvdIJI/MQOplP3ADLNGU7G+sEDp2T2WLElYQTHowStkYVy096zCKSZ7CuSn7EKzyRErx4tK+ZIn1XQKUqTZrVH95e5VIHfgHVcTTHKIB/CuvG1I6bWgmnbQZplHeGMjfoxiQArOtKJUZNgW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(396003)(366004)(376002)(39860400002)(230922051799003)(230173577357003)(230273577357003)(451199024)(1800799012)(64100799003)(186009)(53546011)(26005)(83380400001)(6506007)(6512007)(2616005)(66476007)(38100700002)(44832011)(8676002)(41300700001)(2906002)(8936002)(6486002)(66556008)(316002)(66946007)(478600001)(5660300002)(31696002)(36756003)(86362001)(82960400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGVkSnhUN0t1WVpUWXBsWjltSmJXN2d6R05oVWpUdTJ6NTZYNTZSVkhUMFJ6?= =?utf-8?B?QW5OZ2tXY2x5QjV5bFZIazVPdzhCLzlSbksyT2dPQ3NpMmo1YjVtM3cxV1Q1?= =?utf-8?B?NUJKU1hwSjE5ZTkzTERUbTFrN3lVNnJaTmhBYUR3VE5UUys4SllTNHJaSFdS?= =?utf-8?B?UmxmeUxNYXQyWHYxYTNpWFFpQ1l2T0ZvNVR2cUZmb0tOSkRheWFSaGJ4MkhJ?= =?utf-8?B?cVBoRE55cUp6bktVbFJuR0ZOUWZtWG9DNHJmSGw0V3Y4b21NVVB2SUdSKzNK?= =?utf-8?B?U2hMUGRwa3ZHVmZjZXVTUGhvV2JFZlhyQldDY2JPVVN1d0hNM1RLTUowYlZs?= =?utf-8?B?bkpFZGJOMmhYQ1dPOUxHbXN0aitTQlNrc0p6SjJxSGhBdDIyRmdyMnJ6NHV1?= =?utf-8?B?Y2dvZmpzbG1yZVZmT1Q0S2g4UEJieXlyZFBOY1d0WGJqaW1iUlNpZEtiekJa?= =?utf-8?B?N0U0V3UrRStHL0hxZXRuVFhlRllENHhMdkJsWGxCNjZFN0NYN1kxTHBhVXkx?= =?utf-8?B?ZFNyUmx0RFBWUkNZVVhhMEIvYWRHSjBHTTIyWlU4Ujc3aWxvSkpkSHVuWVU3?= =?utf-8?B?TDF3YWxsY1ZxVUJFd2ZXQ3NTV1dHYmtjTEVNNG9XU3Zrb2lpSVhzYXRBL2F6?= =?utf-8?B?ZnVWa0p3UkRrYkFTbHJIek5KeDRqKzA4MkJYSS9zMUZMbllyb3ZsN29ieHEz?= =?utf-8?B?d1ovYlpDcmgvZWUzT0JFa0Mxb2NDallBVUNQbkZtUnIxd1NHeE5BTHBuaXpZ?= =?utf-8?B?TUhxcldFZjdUZTRiV3ZkNWpkbkxISTUvZzdRemx6bmJiWjVNSVFBdXQweVB0?= =?utf-8?B?NXovaUhiZlIveGRsSFg5SmIvaDRsL3N3Q1h4eGFnWFpESzN3YjJ1MllyY3ZO?= =?utf-8?B?VStLMTZkVElYT0ExVVNxbGUxZlEzQ0VZRnlFcUZ4aVJLRUdkZnM3dVFtMGgx?= =?utf-8?B?NzJkSEUwczdTRXFuUUJKNzJsSG9pcGhlNVYxSDRDMVlmM0NnRUw2NXRTOVFh?= =?utf-8?B?aDJlSk8ybU1SNDRqT1hXNkhndTNMSlJXL0xVUWxGdnAySit2bHRlUkNnaVhJ?= =?utf-8?B?T2FnQTVvVWtLaXJLemE0aGtZb0tSOWswVlJkNlJSWmtFaWNiVlZRVG1HNnNC?= =?utf-8?B?MGRsMk01MnhxWEFVUy9qSU5QdVp0UzZnOHpKRDJYQnBmZklJZnVISmZ2bWpP?= =?utf-8?B?dkxJQVlrWXhOcDJhWkhHQ1lIT0dnek12NXU2M2xFbGtuWHFGcGdKRUdwNzZr?= =?utf-8?B?QW5Xc21wc1BrSVRVRENWTDdCNzZVTVhjRUNjTEl5ODVOMllVd3dwM0FTNG9y?= =?utf-8?B?UUZiNWM2bjBPelV0RWVmWGdKRVJ5K2s1VmoxQkZOaXJxcjI0WGduMWF2UTZ3?= =?utf-8?B?VDIwTUxPUFc4ZFF6ZjR6UVFUbmdzbi9HWGh5SUFoalRIVmlKTEsxd1FSY2kr?= =?utf-8?B?Vk1OWktKZ2x2M2N1VGZ6ekZKMDVQZURCcmxENTg1ak5vYWcwbkdBcGdHOUUv?= =?utf-8?B?bzFkN0wxZzFRbzhNUDB4RmlpaW1Lb055a3lVb0ZGZ09UTWxhVTFWWDNPUklu?= =?utf-8?B?RmpwODhndnhoQU9xMkF4V0xPNjZkOVhJcHV2MFNBdks5OEluT1kyOWx6WUV4?= =?utf-8?B?ZGpuY1JHSVViYlpoUk1abE9NUm9hVGxCODhBYnNJRmlyUXFubGtlQ2xMRm4y?= =?utf-8?B?ZTRhM3BvbTRRTk0rSUllRm4xcnhJcitKZitlUERQMWdySGdoZkFIUjdwK01t?= =?utf-8?B?S1hidzQrTE9xVUJyQSt1UVhNZ2NVT2ZzZVZtVk5IZWkzSnZBdDRLaHhaSFRo?= =?utf-8?B?MzRhaWorL2FUMTc5OUdsQWdNQWFMUWN2TTFjUWpRVUlXbXkySWxpRURRRDBG?= =?utf-8?B?S1N3bTNQTjE0QlMyZkZPZDN2OENqSW55Y0I1V1ErV1BrL3dhMjRXTUw0QW4v?= =?utf-8?B?eEE4Qll1aTgyc1ZPN1pxaVVja0FucFVOaVZvVlRDWkFDd2lWODRUaHZ4bHlS?= =?utf-8?B?bm9BRzU0WWY4SzI0Y2xlL3pZVGhEeURKUmNPRHRwYmpsa1JkdXdEeG10VG5R?= =?utf-8?B?ZDFQVzdGNGxZY2tIQXI1Wll1VVZpaDJuZUpIL3FFVnFlaW1iTFFWZHRWa3JH?= =?utf-8?B?THMvaFMwN1RnelZGSlRtTnJrd2dYTWxTRXFVRjNKcjIvWjNuL1ZRL2g4VnZq?= =?utf-8?B?OVE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 728c1016-5c80-489d-df2b-08dc181108ae X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 10:34:21.9932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VBD7F0+DUQz2Mel5fVYBtrBR9SfcNo3Ay75qTPKQIdXxDe+saWjqjaHPB7oXaDPL/MQjeWuy3ytgiZ+yMH8Xig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR10MB4073 X-TUID: IwJUM5QfQyTw On 18.01.24 11:31, Felix Moessbauer wrote: > Cross compiling kernel modules for distro kernels is not supported in debian. > To simplify downstream kernel module builds, we automatically turn off cross > compilation for a user-provided module when building it for a distro kernel. > > This patch further replaces the hard-coded list of distro kernels with > the DISTRO_KERNELS variable to avoid code duplication. > > Signed-off-by: Felix Moessbauer > --- > RECIPE-API-CHANGELOG.md | 6 +++++ > .../example-module/example-module.bb | 22 ------------------- > meta/recipes-kernel/linux-module/module.inc | 10 +++++++++ > 3 files changed, 16 insertions(+), 22 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index bea12871..b1e5a5ab 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -566,3 +566,9 @@ supported, but a warning is issued when it is used. Future versions will drop > When building a custom kernel module, the `KBuild` file might be located in > a subdirectory. To support this use-case, set `MODULE_DIR=$(PWD)/subdir` in > the module build recipe. > + > +### Automatically disable cross for kmod builds against distro kernels > + > +Cross compiling kernel modules for distro kernels is not supported in debian. > +To simplify downstream kernel module builds, we automatically turn of cross > +compilation for a user-provided module when building it for a distro kernel. > diff --git a/meta-isar/recipes-kernel/example-module/example-module.bb b/meta-isar/recipes-kernel/example-module/example-module.bb > index 5ebed102..22f3cc47 100644 > --- a/meta-isar/recipes-kernel/example-module/example-module.bb > +++ b/meta-isar/recipes-kernel/example-module/example-module.bb > @@ -5,28 +5,6 @@ > # > # SPDX-License-Identifier: MIT > > -# Cross-compilation is not supported for the default Debian kernels. > -# For example, package with kernel headers for ARM: > -# linux-headers-armmp > -# has hard dependencies from linux-compiler-gcc-4.8-arm, what > -# conflicts with the host binaries. > -python() { > - if d.getVar('KERNEL_NAME') in [ > - 'armmp', > - 'arm64', > - 'rpi-rpfv', > - 'amd64', > - '686-pae', > - '4kc-malta', > - 'riscv64', > - 'kernel', > - 'kernel7', > - 'kernel7l', > - 'kernel8', > - ]: > - d.setVar('ISAR_CROSS_COMPILE', '0') > -} > - > require recipes-kernel/linux-module/module.inc > > SRC_URI += "file://src" > diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc > index 269da6ae..eddbf177 100644 > --- a/meta/recipes-kernel/linux-module/module.inc > +++ b/meta/recipes-kernel/linux-module/module.inc > @@ -28,6 +28,16 @@ SRC_URI += "file://debian/" > > AUTOLOAD ?= "" > > +# Cross-compilation is not supported for the default Debian kernels. > +# For example, package with kernel headers for ARM: > +# linux-headers-armmp > +# has hard dependencies from linux-compiler-gcc-4.8-arm, what > +# conflicts with the host binaries. > +python() { > + if d.getVar('KERNEL_NAME') in d.getVar('DISTRO_KERNELS').split(): > + d.setVar('ISAR_CROSS_COMPILE', '0') > +} > + What do we do if this changes one day, in trixie e.g? Or is even fixed for bookworm? Jan > inherit dpkg > > TEMPLATE_FILES = "debian/control.tmpl \ -- Siemens AG, Technology Linux Expert Center