Re: [PATCH 0/3] Filesystem mounting and machine-id fix

[Claudius Heine <ch@denx.de>]

[-- Attachment #1.1: Type: text/plain, Size: 4705 bytes --]

Hi Maxim,

On 04/06/2019 22.09, Maxim Yu. Osipov wrote:
> Hi Claudius,
> 
> Regarding machine-id patch -
> I may apply it (with adding Reported-by: Matthias Lüscher
> <m.luescher@datacomm.ch>).
> 
> As for the two first ones - could you please provide a feedback on the
> last email from Henning in this thread (see below):

I just didn't have time to test and investigate that yet.

My work schedule changed a bit starting this month, and as a result I
will probably have less time for Isar upstream.

regards,
Claudius

> 
> Regards,
> Maxim.
> 
> -------- Forwarded Message --------
> Subject: Re: [PATCH 2/3] image.bbclass: remove fstab generation
> Date: Wed, 29 May 2019 13:11:59 +0200
> From: Henning Schild <henning.schild@siemens.com>
> To: Claudius Heine <claudius.heine.ext@siemens.com>
> CC: isar-users@googlegroups.com, Claudius Heine <ch@denx.de>
> 
> Am Wed, 29 May 2019 08:47:39 +0200
> schrieb Claudius Heine <claudius.heine.ext@siemens.com>:
> 
>> On 28/05/2019 19.34, Henning Schild wrote:
>> > Systemd might be default, but is not guaranteed to be installed on a
>> > working and officially supported debian.
>> >
>> > Yes we do kind of need it at the moment (for very few features where
>> > other inits can be enabled as needed). But we would at least see a
>> > conflict. I.e ssh-key-regen is pulling systemd while someone else is
>> > pulling sysvinit.
>> >
>> > With this patch we might create non-bootable images, which is not
>> > OK.
>>
>> I would like to support any init system that debian supports as well,
>> but I currently don't have any project that does not use systemd with
>> isar, so for me there is currently no use case.
>>
>> But if you would implement a test case for SysV in meta-isar, then I
>> could try to find a solution that works with SysV as well as systemd
>> or any other init system we have a test case for (if the workload is
>> at a manageable level). As is currently stands though we only test
>> systemd and therefor officially only support that in isar.
> 
> You are saying it is ok to break a feature because we currently have
> no testcase that would detect the problem?
> 
> The testcase is really simple, but including it into Isar will grow or
> CI even further. For a corner-case. So i would not add a test-case to
> keep CI clean of such a corner-case.
> 
> The compromise is to manually test the corner-case when introducing
> patches that potentially break it. And the test is pretty easy
> 
> IMAGE_PREINSTALL += "sysvinit-core"
> 
> and make sure nothing pulls in systemd to replace that guy again.
> 
> Henning
> 
> On 5/28/19 10:58 AM, claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> here is a small patchset that removes the fstab and the machine-id file.
>>
>> The fstab generation is much to inflexible and in its current form
>> unnecessary.
>> If it comes back in the future, then we should think about a good user
>> API.
>>
>> As a result of the removal, I added a few 'rw' kernel arguments to the
>> meta-isar
>> wks files. I haven't touched the wks files from `scripts` yet, because
>> I don't
>> really know how/if those scripts are used downstream and would like an
>> input
>> from the community about this. When I use wic, I tend to write custom
>> wks files.
>>
>> The machine-id removal is pretty simple and systemd will recreate it
>> on first
>> boot, but that requires a rw /etc directory. (Some exceptions
>> possible, see
>> systemd-machine-id-commit.service(8).)
>>
>> The machine-id patch can be applied without the first two patches.
>>
>> regards,
>> Claudius
>>
>> Claudius Heine (3):
>>    wks: added 'rw' to kernel arguments
>>    image.bbclass: remove fstab generation
>>    image-postproc-extension: add removal of machine-id
>>
>>   .../scripts/lib/wic/canned-wks/bananapi.wks      |  2 +-
>>   .../lib/wic/canned-wks/directdisk-isar.wks       |  2 +-
>>   .../scripts/lib/wic/canned-wks/sdimage-efi.wks   |  2 +-
>>   meta/classes/image-postproc-extension.bbclass    | 11 +++++++++--
>>   meta/classes/image.bbclass                       | 16 ----------------
>>   5 files changed, 12 insertions(+), 21 deletions(-)
>>
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]