From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:a1c:e356:: with SMTP id a83mr9523570wmh.38.1559717159331; Tue, 04 Jun 2019 23:45:59 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:fb4f:: with SMTP id c15ls206942wrs.11.gmail; Tue, 04 Jun 2019 23:45:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxD3xlbjADeVm7Yx50+UM9Bf0ZH/PBRhH66I2Lt9OqxfneYL3fznF/945XSL7004qzot22R X-Received: by 2002:adf:dcd1:: with SMTP id x17mr24070950wrm.98.1559717158937; Tue, 04 Jun 2019 23:45:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559717158; cv=none; d=google.com; s=arc-20160816; b=YSuLVJ83Tp2PyTbnl2oUtSX+LyLO66qRr/TZbVdyoFWVGm9AyAeSdTce9mfsU+P+/F mfpzfU64KAj2gVoswwIVOnw6PglXi9qcYmYeFTVqWdX4VeDrJNy+Gqil5IwRIeJdoh+7 1TzDydInGDofKKHlAKAhsaJZNSCs/18MxZbCo7pUi4ZpZmopf//pdnIFqNOEnC5+86Ic s2tnAqO6qWhiIDZn89sBHCem0RUaQGQmELxIJnJuSAEJLfuqGOrY56XX80eBpA6/Xzlq 0i9h3OwfqLGfFdpnO/VFuvew6uvH1KYbdtNdB7zgvWMmmXh9fpiNSz1vNwg+YExv0Jrz Oikg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:openpgp:from :references:to:subject; bh=9EQ8HaxgdpUEUsO/gUGwvsTw9WTJfOh23OQkOQbZHX8=; b=qYmZ8Oyy10P0t/LivP+kg6vkPidYHD54q0eDMZgaWP290atMJHXZNh31KH/m3urIGC PbMq8JI+f0X98xKBF2xidsDPk0NVkPIVQgKG8yhojFt930wXJOfUiutu5ntybiUobuVc GuaVU7nguGvEeXuOonoItbLZQN/IUdYT+FyF0l8Tc+bedxCMrw4SGVE7JkXJiCjRMeSz uuAm0514GLds2JKcGr/Fr4SvDdre5XRGGIoUR3LCMicdJ0KyzM/6w5ede1+p8weSc5tf l3/khND05xEvdr+txwEBK8DA610eu7dkaSRKDmra5yzqu6/aMzKYHm0wfJbTaUQewjC5 uG2Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id y139si874731wmd.0.2019.06.04.23.45.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 23:45:57 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 45JfSj4btYz1rHD4; Wed, 5 Jun 2019 08:45:57 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 45JfSj4Hd1z1qqkp; Wed, 5 Jun 2019 08:45:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Vi_-VRXLdlTy; Wed, 5 Jun 2019 08:45:56 +0200 (CEST) X-Auth-Info: oL24BHpdz3R+/ATKjk7S/2y50TUwsdXXmuH6TiIPIHY= Received: from deneb.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 5 Jun 2019 08:45:56 +0200 (CEST) Subject: Re: [PATCH 0/3] Filesystem mounting and machine-id fix To: "Maxim Yu. Osipov" , claudius.heine.ext@siemens.com, isar-users@googlegroups.com References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> From: Claudius Heine Openpgp: id=6FF2E59F00C6BC2831D864C11173CB199808B153; url=http://pool.sks-keyservers.net/pks/lookup?op=get&search=0x1173CB199808B153 Message-ID: Date: Wed, 5 Jun 2019 08:45:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DorsoaFuIbXAzJjF2GcpMaLJ1BvljEAyU" X-TUID: wpn294sMBiPe This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DorsoaFuIbXAzJjF2GcpMaLJ1BvljEAyU Content-Type: multipart/mixed; boundary="7bx7SaFyyuYEz2BWkDqInRTcP3DHbPKZd"; protected-headers="v1" From: Claudius Heine To: "Maxim Yu. Osipov" , claudius.heine.ext@siemens.com, isar-users@googlegroups.com Message-ID: Subject: Re: [PATCH 0/3] Filesystem mounting and machine-id fix References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> In-Reply-To: --7bx7SaFyyuYEz2BWkDqInRTcP3DHbPKZd Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: quoted-printable Hi Maxim, On 04/06/2019 22.09, Maxim Yu. Osipov wrote: > Hi Claudius, >=20 > Regarding machine-id patch - > I may apply it (with adding Reported-by: Matthias L=C3=BCscher > ). >=20 > As for the two first ones - could you please provide a feedback on the > last email from Henning in this thread (see below): I just didn't have time to test and investigate that yet. My work schedule changed a bit starting this month, and as a result I will probably have less time for Isar upstream. regards, Claudius >=20 > Regards, > Maxim. >=20 > -------- Forwarded Message -------- > Subject: Re: [PATCH 2/3] image.bbclass: remove fstab generation > Date: Wed, 29 May 2019 13:11:59 +0200 > From: Henning Schild > To: Claudius Heine > CC: isar-users@googlegroups.com, Claudius Heine >=20 > Am Wed, 29 May 2019 08:47:39 +0200 > schrieb Claudius Heine : >=20 >> On 28/05/2019 19.34, Henning Schild wrote: >> > Systemd might be default, but is not guaranteed to be installed on a= >> > working and officially supported debian. >> > >> > Yes we do kind of need it at the moment (for very few features where= >> > other inits can be enabled as needed). But we would at least see a >> > conflict. I.e ssh-key-regen is pulling systemd while someone else is= >> > pulling sysvinit. >> > >> > With this patch we might create non-bootable images, which is not >> > OK. >> >> I would like to support any init system that debian supports as well, >> but I currently don't have any project that does not use systemd with >> isar, so for me there is currently no use case. >> >> But if you would implement a test case for SysV in meta-isar, then I >> could try to find a solution that works with SysV as well as systemd >> or any other init system we have a test case for (if the workload is >> at a manageable level). As is currently stands though we only test >> systemd and therefor officially only support that in isar. >=20 > You are saying it is ok to break a feature because we currently have > no testcase that would detect the problem? >=20 > The testcase is really simple, but including it into Isar will grow or > CI even further. For a corner-case. So i would not add a test-case to > keep CI clean of such a corner-case. >=20 > The compromise is to manually test the corner-case when introducing > patches that potentially break it. And the test is pretty easy >=20 > IMAGE_PREINSTALL +=3D "sysvinit-core" >=20 > and make sure nothing pulls in systemd to replace that guy again. >=20 > Henning >=20 > On 5/28/19 10:58 AM, claudius.heine.ext@siemens.com wrote: >> From: Claudius Heine >> >> Hi, >> >> here is a small patchset that removes the fstab and the machine-id fil= e. >> >> The fstab generation is much to inflexible and in its current form >> unnecessary. >> If it comes back in the future, then we should think about a good user= >> API. >> >> As a result of the removal, I added a few 'rw' kernel arguments to the= >> meta-isar >> wks files. I haven't touched the wks files from `scripts` yet, because= >> I don't >> really know how/if those scripts are used downstream and would like an= >> input >> from the community about this. When I use wic, I tend to write custom >> wks files. >> >> The machine-id removal is pretty simple and systemd will recreate it >> on first >> boot, but that requires a rw /etc directory. (Some exceptions >> possible, see >> systemd-machine-id-commit.service(8).) >> >> The machine-id patch can be applied without the first two patches. >> >> regards, >> Claudius >> >> Claudius Heine (3): >> =C2=A0=C2=A0 wks: added 'rw' to kernel arguments >> =C2=A0=C2=A0 image.bbclass: remove fstab generation >> =C2=A0=C2=A0 image-postproc-extension: add removal of machine-id >> >> =C2=A0 .../scripts/lib/wic/canned-wks/bananapi.wks=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 .../lib/wic/canned-wks/directdisk-isar.wks=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 .../scripts/lib/wic/canned-wks/sdimage-efi.wks=C2=A0=C2=A0 |=C2= =A0 2 +- >> =C2=A0 meta/classes/image-postproc-extension.bbclass=C2=A0=C2=A0=C2=A0= | 11 +++++++++-- >> =C2=A0 meta/classes/image.bbclass=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | 16 ---------------- >> =C2=A0 5 files changed, 12 insertions(+), 21 deletions(-) >> >=20 --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --7bx7SaFyyuYEz2BWkDqInRTcP3DHbPKZd-- --DorsoaFuIbXAzJjF2GcpMaLJ1BvljEAyU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlz3ZSMACgkQEXPLGZgI sVP3PBAArO+S5L96ctjTSFykcA+tkobIiJjCd535KFjP9eHXLVkN15Yl4iZaGI7w D/lsNQpoaRsCAslQIEYBOnfdAknmxb/xJWHKDdKPWWFtGl/PybxLUCfaN6zN27Iq Cev/bW4udfybjGUGEiokOXRWMT6fPd/RGQl3guhI0DQ8fz9GnusfMJyGAILhjCDc S8k8vsL9EdyreSaUlrHJNLIbmArNKJjiIVm1VleS8Wj3Od2m5V6iPPWC2syS13cr 0dZuNQHFBbT97IOy61fOJQ2Pkiy7EWxX573VQCL6mslIXJiM7xQPz/GYPkuzSHEW ohzWw2063pB/Y0XpTwnXmNOXc+cApfBmM6WkYHbklqR/PJ5rmu9V7dyyS7XjZbSK Zzn4dViqBHaLJSnfjivkftPO/A+azZ3/fBSDUJefEQPDAONR9RrWPEA5Cqe5agDJ us6TSZ5vI0zK8bt3TPC9zkVQWnePTARNp/XXIi0/+HPWUKlWN1q4uevWV+pqPnzO NTGhn7XN5djmMM621MhVQgr9wFpu/9vdaovCZ/iSxUVEOMIrgiIZJJyG8A6GLPxh 6/An29eeaSxhH13rVFJjU6Gfm29in1/jrByp9jeItOOyHy0fBjZhRGv0z1yO9UD8 sMD+1OiHhGLT09t0wklkwul7pXrG2+ZCCtp3mVklkXIvXhDySCE= =zs0A -----END PGP SIGNATURE----- --DorsoaFuIbXAzJjF2GcpMaLJ1BvljEAyU--