From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7186869599348981760 X-Received: by 2002:a05:600c:4311:b0:3c7:135a:2e4f with SMTP id p17-20020a05600c431100b003c7135a2e4fmr5613209wme.30.1673333981487; Mon, 09 Jan 2023 22:59:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:250:b0:269:604b:a0dd with SMTP id m16-20020a056000025000b00269604ba0ddls10079wrz.0.-pod-prod-gmail; Mon, 09 Jan 2023 22:59:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXuS29jm8Y+PRxv5wpq+aKyM+XSaa/GddZIguuvBmR2vZQVVyGhlDutcZzBg6F48izu7fy9g X-Received: by 2002:a5d:5291:0:b0:289:773c:59ee with SMTP id c17-20020a5d5291000000b00289773c59eemr27828871wrv.6.1673333980120; Mon, 09 Jan 2023 22:59:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673333980; cv=pass; d=google.com; s=arc-20160816; b=J/7NhZksP2k8OkBy17adFuHGHJAfhUwV3RpdzjCD0El35tkPgEppfBn0UWDDwWAlB2 8F2B/DHGaW0iQHr5sJ043GcPqG4gsiY3LmAhBjFseRxjzluBQP5kVgGpiWuImEdQwy1x PMwNgp6dpNCFfPWYu9l7TME1ZDPt92mP8t5vZRoynwTxbjHAMdUNeyfvIMhPjWgxOHNg 2Lz5O6mOuODbtBtG5OUcEpLwUxpEBixDChqskNBDHWlIWoUSa73E3f7Z8L+zHTZVHB+H ITdQ5HbCJ22InmS9JkYorpHNJymCCpkB55vXi4wWKoE6nQD6IUFyFZgVUzczmcigKh4Y CiWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=deBVHTY7BoHH8SZN+ExHyLgyS0VqnFqnfOvucV1jVy4=; b=SSh/l4c/6RXOCCzDU3gojlr2pv6cDX1/q7wL0r7iVa9AGiqgw0n4kzBDpvG2y7wjds sb/Ujz3lEkXufkekTuDg3iTI6WBCRQS44svap5ZgTtzt+Esuqhtr8N0+24naUOoup2EU AF3pBPBpLgSvB3F4orVmkJS8yQoLnXyn2iIF2UsFh1Kh2oPVD7nN1AJTV846JKlo1Pqo NzT2dNEmZhPddlLsruMeHBO4NzTey8bNw/WBSGtFeFd6mIc+/8qLWUWiqw3BEfKfWy+2 KfdZ4l6wMcVOKMb6NjKtJy9na2Mg5KTXNQR+TVvl5Pv0oLsjq6il2QO02M2/MktjVuBv g9sA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=fTl98c7r; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.13.58 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2058.outbound.protection.outlook.com. [40.107.13.58]) by gmr-mx.google.com with ESMTPS id ba30-20020a0560001c1e00b00241d0141fbcsi482623wrb.8.2023.01.09.22.59.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2023 22:59:40 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.13.58 as permitted sender) client-ip=40.107.13.58; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=fTl98c7r; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.13.58 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DImHi4dSyZVhpyNt6sS30Z7BRrq+OthbB7AQJet/tirFILRszbYqmFlT16dTWk9+sQMfYPN6bvhcahA7b5CO8B5CIHRWUrLSxrgHdoEbmEbnN0f2+/IQKIuXmavVgvUs4U5jD3srRjiY7E3wdOiUmLzECLAMTvkwyI20vyKOHhmk4etcNJFVtjy7fM1iL1NnjGpJQ/s4of3PW9M8AgNdc4c+s8wZ27fTdme95EVLU6W76BoDUsmsnBH+ByPXKyScWpek/kXm7sFotdOXdB0ojSVcrZqMAIhiGjHdPEQmq4JGbn9/TKYoAeK2WlNwURhN1lqmjH5Bb8iFFkbb04wigA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=deBVHTY7BoHH8SZN+ExHyLgyS0VqnFqnfOvucV1jVy4=; b=fXmLXDm8Lixd5TTAaPPMxx9EhMd1Pvwdkmd6lgEHkG96TUcqQyGb4Ih3Cp6ZfL3eAXRsedXovA0xjMoXqOKDWQzzijrhyUBovfr4izFbM8Egk8do8hmIJdzNMg+yqXVvfW2pwfhdpI8o0V1M0nFWCd0TS9QT4Z4+PDOcwKGo1zshoBJ6fQfMNpUOie5oCem7UmO8QMRsw9bfA7j9UOJKccQBrvXnUiWic4zutkqV6+Xksu3yRtCPmuVGQH0VP/ahBT2rY2lpRLlTE93en1/b+F/plN6U312BbPH3LFdbS+SsA414ZN3tWifdw1LdV0kfyGiJvWxgy4bQQJqFBCwqhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=deBVHTY7BoHH8SZN+ExHyLgyS0VqnFqnfOvucV1jVy4=; b=fTl98c7r4PuhX+WhAd98a7b1WV1HWn7AqvtbFmpUC7mv8i9QfvF5+jTNJNarmeMIacXxvsSw7XczC/WDOOoJCAWfhpuCUXKUSqkC4YRbiuwYMxOxic79uQoeghxi6nPjMHBinqXVup98LYSyO1rjXJbk2vaFzqGxSv64mwKc18FsVKetbhlY7S+tjAxAvnLUIsKFyUYdFY5s5hEZYFOrEaDKKGf3Sz1degnDLpQoIPORUwAiZGxFQt5pdQzHZ8KP047vhf+a870gDo+efgYAl/xsLjjWWLWhQwVFmPRgbTKeG3PVJkVgcK2/OYBO/BqysFglmbLKAfC5v6gO07sO2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AM7PR10MB3526.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:139::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 06:59:38 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5%6]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 06:59:38 +0000 Message-ID: Date: Tue, 10 Jan 2023 07:59:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] dpkg: schroot migration then buildchroot references removed, v2 Content-Language: en-US To: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com Cc: roberto.foglietta@gmail.com References: <20230110040427.1177958-1-roberto.foglietta@linuxteam.org> From: Jan Kiszka In-Reply-To: <20230110040427.1177958-1-roberto.foglietta@linuxteam.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::19) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AM7PR10MB3526:EE_ X-MS-Office365-Filtering-Correlation-Id: ed60e44e-d536-4f07-ba9c-08daf2d83d97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kX+7aBYKc/gmkEnaXdQYkqlRjG8M4EYBMEv3Saeg0YBfGoIKLTiqYUMs8EiAb4dHrvL17+lad1N2wDObPUfqa9f3NXrQ9M2vlCmWwI7oNptdvH5MWEvXFIQ5wgSBZmJPgIjfZ6n5d92dgLiFLHGlhKKSAQ+cjz+p8M21GCjraN690ytR4R3qZqSsywnVKXMzTo6eHnOclgQ2GaJ7ajyds2TEP1LSe4WR37MAQkJH0dj7pkDOPvgxz17FdW++WMj0NEkw/c+IekZfuUR09Q6ciNRDn/9URhewj+Kq+InR4y7amc2kcakqFDg/TbGYe5YgHuDVt2Cq2h2mEngVbr4Y9jhxpvPCJ5EOQJFr4Aeol2AywnlRofmZ0DK/A7fVAJpoWNtbWg/Id9OTP+TyrFFTMoJZq1iPYXg1TveWw/ZS66c2ZZBH/x+ItVNRiSMwCeokvOC9sIPtPdGg9JGC2D5UU744fnC3WjYu2LahfuH7ZMTY5CYm/dnWV90BO0xWfA7D753hm4zSB1v3WaHzIJdiaAGkeHz3HhFQrKqAfsNiKkxOXjQ+rgMbFNCoHol/G2nUdq3C/FJl/7FlgoS2/OiC11MmdYyuizOrWJDJe7Clzr9c7/VYub/7pcD4zrjdPeCNeNBr7gmscY3UsIecW820G5ZqRQ+s3DfFv6N/TMywc+veI0sN/1LXg/4IeBMwKm6PhyVNy6+sRowoLe/IFZA9VLy48C+BI9qASlPFzG3kv0AADKeeWF/2jvmzs4X+bcCXEq0c3ZzLY1mYOJuA/RMm3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(4326008)(8676002)(66556008)(316002)(66946007)(66476007)(44832011)(26005)(6512007)(2616005)(38100700002)(31686004)(86362001)(186003)(83380400001)(31696002)(36756003)(966005)(82960400001)(478600001)(6506007)(6486002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWlZeFVQdzUzU3cyQmdDakx2aXptZk9BWmw2T2ltTUQ5YXdQc0oxZmdDenJQ?= =?utf-8?B?REJUSktRSnVwK0lLZmhUNnVNaklybW1RTHA5R3lKZVArQkprdXNXS0RXV2I1?= =?utf-8?B?Uml2OWlaeHhJMDY4UndRYXFJcTZQdkREZUtIYmF6NVVCYk1hSlpFaUZvVWt0?= =?utf-8?B?NFFLZmNaS1l6VitNREVVcnA1b2lHWjVOdDk5b3IrQ2lWYmxGNHRML3dwSHZi?= =?utf-8?B?T1NaNnZXNit1L0lSNWJpRDZMYi9FUjJpQitZZ0h1UU5NMjFYaWNXeXhNKzZo?= =?utf-8?B?aHBKRURvazNZVTRnOU5xMERKQmlPK2RvVitqL1BNM3BFR1g4MEJhNE1FZFBS?= =?utf-8?B?UlIzenkyUHBRVGpnVkRzL3puNzZUQTIwLzBrTUhHdm5nTVFvVTZsUkFzcXhS?= =?utf-8?B?UWJHMk1mUUM2K3pZZERTRStPZHJzb1B1OG5Ta2pYMEFSR053NnJCK0FyWEY4?= =?utf-8?B?YU12QlJrUG91cTliTWNtOVNTZ1BTS1pVMVJTaDFsZ2puQ1pndjg4WVM5U24y?= =?utf-8?B?Z0hjTmRHN3RLZ2o1UWZ6WmkzYi9zQ0FqMmtlZTVsdHh1elE1ZnNlUE9qam11?= =?utf-8?B?K3BMVkRlVGZtQXAwdDdrbVVqQ0EyVmJhMktlbUhvSGZ0ZzZhTHpPZ3VDYmNu?= =?utf-8?B?SzZ6NzVwUmM4bE5oNHN4a25WMXkzMTNGRXlCN3haNlRqQk1DRVN5VnQ4ZWVo?= =?utf-8?B?NG1QTlg4ZDZwVWpTNUtaMWdZQVJaZkowM0ppSmhkR2UzVUtBUmZyRFJ2ampn?= =?utf-8?B?M21nc25DRUpvNTlHdWovUXZCUWdjR3hxNXoxdlpDYXQvNTUzcmVQeVk4VzFV?= =?utf-8?B?K1hnSHZiYTRvMWFiLzY1OHNKWjNKek1ZS3BDdzJMVGZ2eHBKb090VVBuZmtq?= =?utf-8?B?UnUrekFIcE5KMFhiRXhyN0tSYkFaSXNSUFk5dGNaRHlBS0dRS1U2R1E0Undk?= =?utf-8?B?ZStVWHB5b3dkWmNNQjNEQnJrbXRkVFp5QkIzUjNORXdLQ21Nb080VFVIcnBV?= =?utf-8?B?OUZSUzhCZEVHcHQrd3grWVcwd0V2dmE4Yy9jTkFmV2lCaDBJRzVkajREZ3Ur?= =?utf-8?B?STNhR1pLRWUrM0ZJL3pTWFY4UThZR0grMTMvZTlRd2NUS0NFNGNlM3pGT3Bw?= =?utf-8?B?Rlprb3A1aW54d2JoT1NmdlRXQVI1ODZsWU1OWXlMOUh6YUs2b0twUkpmUlM5?= =?utf-8?B?WXhNbml0dWh3cXRmZlFhRGhxcTVNVVZ2MTYvZzJpOWNBRTIzQ3cwd0ZDcXBw?= =?utf-8?B?WXBoMnlmOE9CVWRSVnJZcHlMYi9nbVliMUJDcEdYem1rQWZlQzZBOFVXVDhB?= =?utf-8?B?OGN5WXd2RmhLSHkxbGgrU0FPanpObGl1d1c0bnRudmZwbkN6aC9NVDRRMlFP?= =?utf-8?B?WTFqSW9WNnREVGNkWlVsODhJSEtVN3piOU9Kblg5SklWTDVBL3JjL0s5UW4w?= =?utf-8?B?SCtFSS93a21yVXRkR0NyU1BVb1NUTTdROFRGRWtIeEU0dmtmNFJGSXR5R0F5?= =?utf-8?B?UjJqanFSbFZKYXVldkdmZTFKR24vWkpCL1k0d3hYaCt0K1d6VXRwT1ZBa0pQ?= =?utf-8?B?b2RSaitvT1drYmgvNEROYjBPUGtzY3U4a2FJZXdFbXRYTWY1UmFNUTk0OEdk?= =?utf-8?B?NnV4bkRZYUs1V1ViNGlHb3I0eFIzREY2Zlp4dWZuWjZXUE5nbTBFOU5Seml1?= =?utf-8?B?bzRBSjVPWDk1S2tXZFhqM1YrdXRSVWVUdDJKM3dmQzZjcjdQWUMybU95SmVX?= =?utf-8?B?TCtkR21WOW15czRaRGpQTDRyMmNTYlAvZDlVR0dFQS94OUFsRTlNZFJ0bTZR?= =?utf-8?B?eWdMemxSbHlSODF4aTlvV2Rodm1TbXMwTkN3UTVnVk5IN1FTVTlGVll5YmI1?= =?utf-8?B?RnFwQ3paOHpCQUNVcGtjckt1VHhTZTkyRUUxbFBEcjBDK25yNEdHM2ZmN3Z6?= =?utf-8?B?R0tLQWFva0xyRDRDVlZ2L0ptWVJjQlN3eEx6eVRnOTJZcjBpejhHcm1UL0Yz?= =?utf-8?B?aldURkNUOFY4cUJoRFJScUlxVXljbWFncHNxdXNSdTg2aDl3OWJKNit1eU05?= =?utf-8?B?TG0vQVhWQW9PVXpRYk5jeFFvNU56WEd3RDdiZU9uOUhsZFNiR1JXcWJEUEE4?= =?utf-8?B?YkdGZUVhaFQ5RjFQM21nNDZPU3V3R0VmOVAza3Y4Ti93blg4MGNLVUkybEJP?= =?utf-8?B?L1E9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed60e44e-d536-4f07-ba9c-08daf2d83d97 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 06:59:38.8277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0rje/fkSTeM7xh1707x8mB7KfnvvB9aQ2T8MxWhCAMDAC2KXlNWHmdE7CWgwagrFHCkaSHn+LotdKMo944SWnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3526 X-TUID: 8zjC1xbaRtCd On 10.01.23 05:04, roberto.foglietta@linuxteam.org wrote: > From: "Roberto A. Foglietta" > > dpkg, adding feature: migration to schroot > > The patchset v.2 by Anton Mikanovich to migrate buildchroot to schroot is not > complete because the buildchroot is still used by the dpkg base class which can > be freed by buildchroot with this patch which applies on the top of these four: > > * events: Cleanup lost schroot sessions if any, v2 > * imager: Move image types to schroot, v2 > * imager: Migrate from buildchroot to schroot, v2 > * sbuild: Allow setting custom config paths, v2 > > v2: remove the lines instead of commenting them, better description > > Signed-off-by: Roberto A. Foglietta > --- Patch version changes and dependencies generally go here, not above. > meta/classes/dpkg-base.bbclass | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 260aa73..ce150b3 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -5,7 +5,6 @@ > # SPDX-License-Identifier: MIT > > inherit sbuild > -inherit buildchroot > inherit debianize > inherit terminal > inherit repository > @@ -123,9 +122,6 @@ do_apt_fetch() { > addtask apt_fetch > do_apt_fetch[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > > -# Add dependency from the correct buildchroot: host or target > -do_apt_fetch[depends] += "${BUILDCHROOT_DEP}" > - I've only dropped this bit in https://patchwork.isar-build.org/project/isar/patch/4a89ddd8-5be1-9aff-ab5c-579ecda50b8f@siemens.com/, wasn't sure about the rest. How did you validate your cleanup? > # Add dependency from the correct schroot: host or target > do_apt_fetch[depends] += "${SCHROOT_DEP}" > > @@ -193,8 +189,6 @@ BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" > dpkg_do_mounts() { > mkdir -p ${BUILDROOT} > sudo mount --bind ${WORKDIR} ${BUILDROOT} > - > - buildchroot_do_mounts > } > > dpkg_undo_mounts() { Isn't there is more to clean up then? Are we still using BUILDROOT in the end? In fact: Are we still calling dpkg_do_mounts at all?? I don't find references in the tree, today. And then doc/technical_overview.md will need an update as well, not only because of this here. Jan -- Siemens AG, Technology Competence Center Embedded Linux