From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6516773995002462208 X-Received: by 10.25.26.66 with SMTP id a63mr2979972lfa.19.1517573956564; Fri, 02 Feb 2018 04:19:16 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.219.92 with SMTP id s89ls252138lfg.8.gmail; Fri, 02 Feb 2018 04:19:15 -0800 (PST) X-Google-Smtp-Source: AH8x2260kW6rkY93WZmIuKSnk+e+hom80unQnKKPg6Pf26V3VAiE3UtsL6ryoFSpaekmjTOnHT/f X-Received: by 10.25.208.132 with SMTP id h126mr3150956lfg.33.1517573955670; Fri, 02 Feb 2018 04:19:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517573955; cv=none; d=google.com; s=arc-20160816; b=V9XXsAbvSXy8l+h7/Ba8fAjYZpL0e6rjBwMs7ClMcc0e3N3+v4MT5zwnJ7NbvUlHKX VvFxXC5ISZ7bAYqKLnvsY6naaMMr0359+hBL3Gdsoyp6Zluiz1hUQZ31VSKI5/dnGURl EIv7XlP+w+ug+4i/bkoj5yKQLDNy9ehhupmpsiZ/dU9RtGiSE5qjZB+9p+SRW32giksl OQj64HYhYYipKmF9IxJP1msyoihZJ1D8BDqm/sIMEsTT6FYRjA5cEKgNprA9w5COJQMO oOPbF5nzEF+EEeTEdDRAJ7O6y09wJi3gM4yZvxURi76nY1WhM9EVoNaOpRvZ3aJeRMxL HhAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=7xd+tF4NIBOr1cRsbljyjFbFIJOyFrZIPl31iQI1emg=; b=pqLHm4mupAV/9tuFW8jq5oHQlf8KpJoA9hy/EDX6WLbGmk8iWe/Mr1PguCnRs+wMQj iVYDYt+y+AiAfgkRarx00CSve0s1zHIcD3av/STyI/3f6PHDBTU1/8Suf4j+rx9+lrVb t5RnEK8LgE81G91PAfOLi4M29weGQ0BueHfTyomJzriSYtfbx7fThOsRwrADZ/yK4loE 9EOjOsyPIjS6uzgbHsrJXdSM5ReYtLLLTZGin/Uid8zPhMg3WsHLrE2lcejLdow0U9v8 3UH7ZNHXQQMZQY1xOhLU+quo48nBfM0NtIO1Ij8m3tjNBJNFwYk/uWeOlX9DIV1Pr7zy DvEQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id s11si123588ljs.1.2018.02.02.04.19.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Feb 2018 04:19:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] (client.yota.ru [188.162.65.234] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w12CJACR014936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 2 Feb 2018 13:19:12 +0100 Subject: Re: [PATCH] Install /dev/null in rootfs To: Henning Schild , "[ext] Jan Kiszka" , Baurzhan Ismagulov Cc: isar-users References: <14fbc8f0-b5dd-afd0-bd73-1592f6ee05ca@siemens.com> <20180130124417.130d5b4c@mmd1pvb1c.ad001.siemens.net> From: Alexander Smirnov Message-ID: Date: Fri, 2 Feb 2018 15:19:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180130124417.130d5b4c@mmd1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: rnlY0dltapKm On 01/30/2018 02:44 PM, Henning Schild wrote: > Good catch, > > but that and the other mknods makes we wonder why wo do not just > bind-mount /dev. And while we are at it also /sys. > > /dev /proc and /sys are known to be usually required for a working > system. Is there a reason to not just mount all three of them? > Otherwise it seems like this patch is just another one in a long series > of mknod patches. > I'm also thinking in this way, especially because now we have robust mechanism how to unmount everything after build finished/stopped via events. So I propose the following plan: - Update bitbake - Merge isar-apt with events - Rework /proc,/dev mounting to fix this issue Alex > Henning > > Am Tue, 30 Jan 2018 10:31:21 +0100 > schrieb "[ext] Jan Kiszka" : > >> From: Jan Kiszka >> >> ...or hell breaks loose, at least in the buildchroot: >> >> x86 kernel builds will generate strange modules.order/builtin files. >> That's because drivers/firmware/Makefile does >> $(call as-instr,.arch armv7-a\n.arch_extension sec,-DREQUIRES_SEC=1) >> That tries the above assembly on the x86 gcc which will not understand >> it and complain. It's output is directed to /dev/null, but that does >> not exist, so it will be printed to the above modules.* files. Argh. >> >> Who knows what may happen in the image rootfs, so update it as well. >> Which reminds us that this ugly duplication should be resolved ASAP. >> >> Signed-off-by: Jan Kiszka >> --- >> .../files/{download_dev-random => download_dev-nodes} | 7 >> +++++++ meta-isar/recipes-core/images/isar-image-base.bb >> | 4 ++-- meta/recipes-devtools/buildchroot/buildchroot.bb >> | 4 ++-- .../recipes-devtools/buildchroot/files/download_dev-nodes >> | 7 +++++++ >> meta/recipes-devtools/buildchroot/files/download_dev-random | 13 >> ------------- 5 files changed, 18 insertions(+), 17 deletions(-) copy >> meta-isar/recipes-core/images/files/{download_dev-random => >> download_dev-nodes} (73%) rename >> meta-isar/recipes-core/images/files/download_dev-random => >> meta/recipes-devtools/buildchroot/files/download_dev-nodes (73%) >> delete mode 100644 >> meta/recipes-devtools/buildchroot/files/download_dev-random >> >> diff --git a/meta-isar/recipes-core/images/files/download_dev-random >> b/meta-isar/recipes-core/images/files/download_dev-nodes similarity >> index 73% copy from >> meta-isar/recipes-core/images/files/download_dev-random copy to >> meta-isar/recipes-core/images/files/download_dev-nodes index >> f7f5fe5..3149faa 100644 --- >> a/meta-isar/recipes-core/images/files/download_dev-random +++ >> b/meta-isar/recipes-core/images/files/download_dev-nodes @@ -7,6 >> +7,13 @@ set -e >> readonly ROOTFS="$1" >> >> +if [ ! -c ${ROOTFS}/dev/null ]; then >> + rm -f ${ROOTFS}/dev/null >> + mknod "${ROOTFS}/dev/null" c 1 3 >> + chmod 666 "${ROOTFS}/dev/null" >> + chown 0:0 "${ROOTFS}/dev/null" >> +fi >> + >> if [ ! -c ${ROOTFS}/dev/random ]; then >> rm -f ${ROOTFS}/dev/random >> mknod "${ROOTFS}/dev/random" c 1 8 >> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb >> b/meta-isar/recipes-core/images/isar-image-base.bb index >> 2f03cd1..3954697 100644 --- >> a/meta-isar/recipes-core/images/isar-image-base.bb +++ >> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -12,7 +12,7 @@ >> FILESPATH =. "${LAYERDIR_isar}/recipes-core/images/files:" SRC_URI = >> "file://multistrap.conf.in \ file://${DISTRO_CONFIG_SCRIPT} \ >> file://setup.sh \ >> - file://download_dev-random" >> + file://download_dev-nodes" >> >> PV = "1.0" >> >> @@ -38,7 +38,7 @@ do_rootfs() { >> >> chmod +x "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}" >> chmod +x "${WORKDIR}/setup.sh" >> - install -m 755 "${WORKDIR}/download_dev-random" >> "${WORKDIR}/hooks_multistrap/" >> + install -m 755 "${WORKDIR}/download_dev-nodes" >> "${WORKDIR}/hooks_multistrap/" >> # Multistrap accepts only relative path in configuration files, >> so get it: cd ${TOPDIR} >> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb >> b/meta/recipes-devtools/buildchroot/buildchroot.bb index >> 51f9d5d..8743a02 100644 --- >> a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ >> b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -12,7 +12,7 @@ >> FILESPATH =. "${LAYERDIR_core}/recipes-devtools/buildchroot/files:" >> SRC_URI = "file://multistrap.conf.in \ file://configscript.sh \ >> file://setup.sh \ >> - file://download_dev-random \ >> + file://download_dev-nodes \ >> file://build.sh" >> PV = "1.0" >> >> @@ -39,7 +39,7 @@ do_build() { >> >> chmod +x "${WORKDIR}/setup.sh" >> chmod +x "${WORKDIR}/configscript.sh" >> - install -m 755 "${WORKDIR}/download_dev-random" >> "${WORKDIR}/hooks_multistrap/" >> + install -m 755 "${WORKDIR}/download_dev-nodes" >> "${WORKDIR}/hooks_multistrap/" >> # Multistrap accepts only relative path in configuration files, >> so get it: cd ${TOPDIR} >> diff --git a/meta-isar/recipes-core/images/files/download_dev-random >> b/meta/recipes-devtools/buildchroot/files/download_dev-nodes >> similarity index 73% rename from >> meta-isar/recipes-core/images/files/download_dev-random rename to >> meta/recipes-devtools/buildchroot/files/download_dev-nodes index >> f7f5fe5..3149faa 100644 --- >> a/meta-isar/recipes-core/images/files/download_dev-random +++ >> b/meta/recipes-devtools/buildchroot/files/download_dev-nodes @@ -7,6 >> +7,13 @@ set -e >> readonly ROOTFS="$1" >> >> +if [ ! -c ${ROOTFS}/dev/null ]; then >> + rm -f ${ROOTFS}/dev/null >> + mknod "${ROOTFS}/dev/null" c 1 3 >> + chmod 666 "${ROOTFS}/dev/null" >> + chown 0:0 "${ROOTFS}/dev/null" >> +fi >> + >> if [ ! -c ${ROOTFS}/dev/random ]; then >> rm -f ${ROOTFS}/dev/random >> mknod "${ROOTFS}/dev/random" c 1 8 >> diff --git >> a/meta/recipes-devtools/buildchroot/files/download_dev-random >> b/meta/recipes-devtools/buildchroot/files/download_dev-random deleted >> file mode 100644 index 5b5b96b..0000000 --- >> a/meta/recipes-devtools/buildchroot/files/download_dev-random >> +++ /dev/null @@ -1,13 +0,0 @@ >> -#!/bin/sh >> - >> -set -e >> - >> -readonly ROOTFS="$1" >> - >> -mknod "${ROOTFS}/dev/random" c 1 8 >> -chmod 640 "${ROOTFS}/dev/random" >> -chown 0:0 "${ROOTFS}/dev/random" >> - >> -mknod "${ROOTFS}/dev/urandom" c 1 9 >> -chmod 640 "${ROOTFS}/dev/urandom" >> -chown 0:0 "${ROOTFS}/dev/urandom" >