From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7077563473267261440 X-Received: by 2002:a50:bac3:0:b0:418:edb0:4ae8 with SMTP id x61-20020a50bac3000000b00418edb04ae8mr28083775ede.219.1647960552278; Tue, 22 Mar 2022 07:49:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:c113:b0:6b5:e466:40c7 with SMTP id do19-20020a170906c11300b006b5e46640c7ls9908721ejc.8.gmail; Tue, 22 Mar 2022 07:49:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUqqQ+F2sbekFzGoBicEhfeHxKjqrJ7WrncSedOmjoxL/4B6kX2tH82PZZUEaH7SXLuaF9 X-Received: by 2002:a17:907:9494:b0:6e0:ee8:4b29 with SMTP id dm20-20020a170907949400b006e00ee84b29mr10077225ejc.337.1647960551196; Tue, 22 Mar 2022 07:49:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1647960551; cv=pass; d=google.com; s=arc-20160816; b=hNEEuRel1/WW0IxnS9NeQvyymrMB7aPOmJ9T+hklexVqftfWHeDKvrkwXGY47TPYs5 y2lKNF4YH8lAngGu4JHCBgREuEK2A5aZdwt6XuA942BMN8K8wJN6lwq7gqndgpAn5Qn1 1k3MdbHxVyl9pZMBcpEToqUXDoHyEpLcbpyuFO65OfY2hQQfvUT3HYkJUbc+FtWrfbEF Fnkb03TWXVLr3Aa/MSRjBjNJsRgsnqMvmeXqKh4lRGe4r+KX0sBSExEGvcmmU7D+WXw0 LeVULdWk9qic17U7DpgHEVHvn/44SGozchq6hSr0BWaFfHbIaTzIn46J8P9kDgl0uwCK 2I7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=h8esrygWEm2fC1btXhRq1sUplH1OHS2Pgz238nRgx6Y=; b=QEFAqm1h0guE9TK5FRAammP/cO6A34+tmckokKJXxLMAO2XseSsKa3P/jUoXtiN7iW SsoCA8tDxiq0jXrA3ln1ZY9dbGNoXJrXi41QOq/yiXDkBk2CXWJRHw/JEyURMl0Idvc2 wW+PWvz+ryzroqv0lVzzITF1T7Y7N0P3xmMGSOdFtH6aaTJNPqZGeFwNBKdC6KeyT7gz Cbe0AOAsZLpuBjONBvjHa/jSKIgNiyEMJCQdkfNydp8yieEOO70evxJsuzR7+440MrU/ iyEoFGyYiIirKkWBcx3KgcbANloSqgKtejZA+W+/ilYbtRZgih+9b0A0ec1RnXOxtnpl ce6Q== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=VtDYD3lP; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1b::62b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062b.outbound.protection.outlook.com. [2a01:111:f400:7e1b::62b]) by gmr-mx.google.com with ESMTPS id g20-20020aa7dd94000000b0041917ecfe80si670624edv.5.2022.03.22.07.49.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Mar 2022 07:49:11 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1b::62b as permitted sender) client-ip=2a01:111:f400:7e1b::62b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=VtDYD3lP; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1b::62b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PCCrd9J06B5/NOIew8w9c0OmqMmSvwZxOlbTUkMqCtmetH6Fa9Zx0PAzD/WoT6JcmH9dVIFrwIiImfZ/uQNQNXfLl8yBqrhvEcAywrAzxp0XbpQ5767hXWIZpo4fTPeEjpAAYbIEXJ2maoWfRWwF2ovsC4L55qfAlL+fvjLi98sLJ731tQ95hX22e2gqaiPXWV104kKv3hUlTsuSzz+xNxiuO9sFq/iRgWZQYppUFuZJtBw6W2rFmu9KL5RtVQHrQzgCasrlV/K3rvFPRPFmLac1LK+ArnG1RojgiyjI1kRZwyyOA9Bdkzrohn3hNGDVjY9nE7xQvS2oeB2qfpaXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h8esrygWEm2fC1btXhRq1sUplH1OHS2Pgz238nRgx6Y=; b=FcLiDAmeRjA/PFJQcCB+2HE/mDLBj6CkEJyIVgXPoN6gAFGF1zaG/EDRmdimfiPUFk6i+xI+/SpKyIB0OKGr5mAJnXjwpUmhlgRZbBA/7XkrJLg5vYq9Kuoev3SkSj4r4CbK9lXMch/RQEIkfAhG0/YJte073x6UZy8O1eEQ2W+HF/9LnKu892uoJ0o9wv73TJqSjvFluHTwcWEbg3PDc8ZiZ5aNm5yKFTzmRgauDEGNzJbALVQAIR0Mq5DBxs1ADXcPkdmXTDx4kf6yALdJD7rtAsdz959sCPVSA9/KbXqQMPgxZ98LLPwr9fP1nHjno+k9O3sgPBEpWrLQw6iRYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.71) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h8esrygWEm2fC1btXhRq1sUplH1OHS2Pgz238nRgx6Y=; b=VtDYD3lP9HA4nq/yAE9l5gZeH4E9NMkZTniM9fG3+pTmZhLOgv3xPZFSm3/qRO1NnNTXi8fwKuHOSu5JbS8IWrzJsQAeaNcb1ejNHhrDX1TpO9fEp2n25AMbLhX5ZTOlLwhHynPg1W1I3n96GgUVtAU3onFyHh/DvCdMMs7JpaBHdC8ProurDPfcTH/BHPGmoGfZ7jxcdvFS/h2WSO1ST2+WCqkkhNR3s7PbmQ7e2VNf5ucnsxK+U3TLUfD9MSW4LKg/VK7d6FyfYdHKdWEgK1/IVlhuywCwcXvGut5bJRkJbQ0b5Ow9J5bHybqVqo6Q21IF4tKb/dVXjhEusn5DIQ== Received: from SV0P279CA0053.NORP279.PROD.OUTLOOK.COM (2603:10a6:f10:13::22) by DB8PR10MB2939.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.19; Tue, 22 Mar 2022 14:49:10 +0000 Received: from HE1EUR01FT052.eop-EUR01.prod.protection.outlook.com (2603:10a6:f10:13:cafe::5a) by SV0P279CA0053.outlook.office365.com (2603:10a6:f10:13::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.22 via Frontend Transport; Tue, 22 Mar 2022 14:49:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.71) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.71 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.71; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.71) by HE1EUR01FT052.mail.protection.outlook.com (10.152.1.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5081.15 via Frontend Transport; Tue, 22 Mar 2022 14:49:09 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SKA.ad011.siemens.net (194.138.21.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 22 Mar 2022 15:49:08 +0100 Received: from [139.22.133.251] (139.22.133.251) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Tue, 22 Mar 2022 15:49:08 +0100 Message-ID: Date: Tue, 22 Mar 2022 15:49:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/1] add support to set KBUILD_BUILD_TIMESTAMP for custom kernels Content-Language: en-US To: "Moessbauer, Felix (T CED SES-DE)" CC: "isar-users@googlegroups.com" References: <20220321144017.3684886-1-felix.moessbauer@siemens.com> <33854e3c-f3a6-b667-5e67-18c22b646619@siemens.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [139.22.133.251] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ab53247-ad2b-4462-0fb4-08da0c131f10 X-MS-TrafficTypeDiagnostic: DB8PR10MB2939:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e5ZBw6IyQoIaX5WpX3jI+WY8epTrqcTgCUMCi4wdSJlQefltLnJ5GyW246baIe5AL96fcPeSYYnxemgyNFLMEKLFWDSZHGrtsmtgmlvKFiSBmuPv2A4URahABrQv2sAJxipHiaE+kBtcYRmYma6UgXC6WVEoGfvwmiDpcVBKtm4BBejle1O/J/9/kHlcfBynwpI0Sf4mnfqcfApfe6u/Dp75B1EICjDJo3E6TZQdX1lWJcW/grPx86PxfxwoZ8gHM0d6aGr+UflZKetAshe1650ENJAJyK+hhpw62BQWyESRkO8sePW28NdtDqRmgJMORVc/SY+fFLauPHvVd6ZXzztcEnQ8690Mgja6doc0SSQxhYyrDT1PMxKeIf/QN84K4tEhe/crj9VeuZA/G9lQgcmEejpMry6mHZTZxHjJPM0QUOlJTjkp4v1X9DhNalhhN6houDuz4upxMNW4jqMLsSsz7ifTfv9nydtQnGfK/hKXRwg/P0jpTKaZ8mfYmxVCF54OB++Kr+Bo2o0tZoyE1wmDlKbMRtu/oGKcm8UGP4GA0Pr/AfneSd5eoVl7Wa0eZRUpSTZgVpZmL+HhkHIUSOKu9S1PX//t3etpMAXFpsYKM93yogXRLSW8hadJQrpVZ6pez0Mv6//PrOpTUl5serez39LYtJV7wC0WPdoiHsLpTiZULx9LXosl2/A65GqxKaUyC60bZQrTJWnkptPUM7JUyhP+O8RL5snaCk7nnzBSBVlICpytx6Adq+Mm4bnFFLzet40A4M8gW0Kx3zwmxg== X-Forefront-Antispam-Report: CIP:194.138.21.71;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(53546011)(2616005)(83380400001)(956004)(31686004)(6636002)(6706004)(37006003)(47076005)(186003)(26005)(8936002)(6862004)(4326008)(36756003)(16576012)(5660300002)(336012)(36860700001)(70586007)(70206006)(8676002)(16526019)(44832011)(2906002)(82310400004)(356005)(81166007)(82960400001)(498600001)(31696002)(86362001)(40460700003)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 14:49:09.0623 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab53247-ad2b-4462-0fb4-08da0c131f10 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.71];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT052.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB2939 X-TUID: L1fpVsHW+jEZ On 22.03.22 09:54, Moessbauer, Felix (T CED SES-DE) wrote: >> -----Original Message----- >> From: Kiszka, Jan (T CED) >> Sent: Monday, March 21, 2022 6:52 PM >> To: Moessbauer, Felix (T CED SES-DE) ; isar- >> users@googlegroups.com >> Subject: Re: [PATCH 1/1] add support to set KBUILD_BUILD_TIMESTAMP for >> custom kernels >> >> On 21.03.22 18:33, Moessbauer, Felix (T CED SES-DE) wrote: >>> Hi Jan, >>> >>>> -----Original Message----- >>>> From: Kiszka, Jan (T CED) >>>> Sent: Monday, March 21, 2022 6:18 PM >>>> To: Moessbauer, Felix (T CED SES-DE) ; >>>> isar- users@googlegroups.com >>>> Subject: Re: [PATCH 1/1] add support to set KBUILD_BUILD_TIMESTAMP >>>> for custom kernels >>>> >>>> On 21.03.22 15:40, Felix Moessbauer wrote: >>>>> This patch adds the infrastructure to overwrite the >>>>> KBUILD_BUILD_TIMESTAMP environment variable for custom kernel builds. >>>>> By that, we improve the support for reproducible kernel builds. >>>>> >>>> >>>> Agreed. >>>> >>>>> Setting this to a fixed string further helps to profit from ccache >>>>> caching on repeated builds. >>>> >>>> Hmm, but the practical impact of this variable should have been >>>> limited /wrt ccache. I was seeing significant build-time reduction before the >> commit already. >>> >>> Yes, but of course depends on configuration. >>> >>>> >>>>> >>>>> Signed-off-by: Felix Moessbauer >>>>> --- >>>>> meta/recipes-kernel/linux/files/debian/isar/build.tmpl | 1 + >>>>> meta/recipes-kernel/linux/files/debian/isar/common.tmpl | 2 ++ >>>>> meta/recipes-kernel/linux/linux-custom.inc | 3 +++ >>>>> 3 files changed, 6 insertions(+) >>>>> >>>>> diff --git a/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>>>> b/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>>>> index b7749cec..32d2eb23 100644 >>>>> --- a/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>>>> +++ b/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>>>> @@ -34,6 +34,7 @@ print_settings() { # --------------- # >>>>> ARCH=${ARCH} # CROSS_COMPILE=${CROSS_COMPILE} >>>>> +# KBUILD_BUILD_TIMESTAMP=${KBUILD_BUILD_TIMESTAMP} >>>>> EOF >>>>> } >>>>> >>>>> diff --git a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>>>> b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>>>> index b7752fb6..ffe84745 100644 >>>>> --- a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>>>> +++ b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>>>> @@ -7,6 +7,7 @@ ARCH=${KERNEL_ARCH} >>>>> KERNEL_PKG_IMAGE=linux-image-${KERNEL_NAME_PROVIDED} >>>>> KERNEL_PKG_KERN_HEADERS=linux-headers-${KERNEL_NAME_PROVIDED} >>>>> KERNEL_PKG_LIBC_HEADERS=linux-libc-dev >>>>> +KBUILD_BUILD_TIMESTAMP="${KBUILD_BUILD_TIMESTAMP}" >>>>> >>>>> # Constants >>>>> KCONF=.config >>>>> @@ -36,6 +37,7 @@ main() { >>>>> >>>>> # variables to be exported >>>>> export ARCH >>>>> + export KBUILD_BUILD_TIMESTAMP >>>>> >>>>> # are we cross-compiling? >>>>> BUILD_ARCH=$(dpkg-architecture -qDEB_BUILD_ARCH) diff --git >>>>> a/meta/recipes-kernel/linux/linux-custom.inc >>>>> b/meta/recipes-kernel/linux/linux-custom.inc >>>>> index 8a5dbf82..f8e87453 100644 >>>>> --- a/meta/recipes-kernel/linux/linux-custom.inc >>>>> +++ b/meta/recipes-kernel/linux/linux-custom.inc >>>>> @@ -33,6 +33,8 @@ KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, \ >>>>> >>>>> KERNEL_LIBC_DEV_DEPLOY ?= "0" >>>>> >>>>> +KBUILD_BUILD_TIMESTAMP ??= "LANG=C $(date)" >>>> >>>> Can't we use SOURCE_DATE_EPOCH like the rest? >>> >>> This variable is still not honored by the kernel (AFAIK). >>> Also the kernel documentation only mentions KBUILD_BUILD_TIMESTAMP. >>> There is a patch from 2015 which has not been applied [1]. >>> >>> We could do the mapping in ISAR, but I prefer to have it explicit. >>> >>> >> >> Then how does the regular Debian kernel set a stable date? We should align to >> that and surely not force the user to set anything manually (that is my >> interpretation of the behavior of the current patch). > > They set it in the rules file to "$(SOURCE_DATE)" [1], which itself is computed from the changelog: > SOURCE_DATE := $(shell dpkg-parsechangelog -SDate) > > Unfortunately, this is not possible for us because we generate the changelog on the fly. > Setting "KBUILD_BUILD_TIMESTAMP" to the current build time (as default) should be reasonable, > Simply because we do not have better information. That's also how it was previously. > The only addition here is do give the user support to set it to something different. > There must be more information in the build env because other packages that do evaluate SOURCE_DATE_EPOCH find that properly set, automatically. Jan -- Siemens AG, Technology Competence Center Embedded Linux