From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7004754512489480192 X-Received: by 2002:a2e:530b:: with SMTP id h11mr15260740ljb.260.1633341348994; Mon, 04 Oct 2021 02:55:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3a83:: with SMTP id q3ls393156lfu.2.gmail; Mon, 04 Oct 2021 02:55:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9KDXIbKfuzajFg0LqpgzVT5JLikOIoIgaPpOwR4OQsghqE34tXXNqp8J6tCIiWKFSOqyc X-Received: by 2002:ac2:544f:: with SMTP id d15mr13671878lfn.221.1633341347836; Mon, 04 Oct 2021 02:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633341347; cv=none; d=google.com; s=arc-20160816; b=yZi1LbhfEXSVdPAxl/kArCwOe7BrZGsyWfl45S9BQTQGe+QCf16OdBbdZixsX6+W0W nY6X1rLuXCV2AaWK748NyuOuXqEQ3r9b9PK3Lsuq+V1pTtlGohYTbyFT3UXMlkLNbpM1 gDcjm9SN3VXjApx5x7CaVhkrDx11DYJr8KZGcmRc5sSJ2ttPfmeGampF/jqyn0QqXr2D IhZfWYP+6WxRNJYJlrqJQ16RD0cGcl4UEMgGJK3mIPz5HNpD5TgIuPpWDRRkBov930OS 5mKBSBLCcUwOf6gQPJvZENGMcDN57ddCsd4hBQTHaItCvY0OCiOLVUbtn3tiBWigcUrO 0EEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=si3wdNhIIHuO1pflsppPLB17tgGmDLWmQ9oJFYoEZrc=; b=cuQG7OVppHi3g+6Zqqj/9bEVSgd/nvIoFCtMq9JAsJDLWH3VKSWveN9vDdk/e3gWa/ V8BUKkoQlqWsCHKwl0xe5VZLFDUo03v3Z/VQO3cWYOGfHT6gl7UR86Kfhn2I2GxI+OrM Ncp0Yrhf/jeBqxIV6MxLv543jVk7POG3YG8QY9uFjwPLIzumq5ZOWIhNR+bq/bK7qTRV PwV2/jmePjp49mXOPMCr5lnS8DkZSJ14UrIxw2qw7RD14+Zrr/kNlsjJTx2YU3ESSnnv 4uRKfe7Jpb8O4T8KFSkKExKx/9c89K0RGGUffnURDnel6VXDJ7WoqGI1sKrgibyWaUM3 w3uA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id a3si908879lji.6.2021.10.04.02.55.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Oct 2021 02:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 1949tl3I004943 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Oct 2021 11:55:47 +0200 Received: from [167.87.3.213] ([167.87.3.213]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1949tkX4019145; Mon, 4 Oct 2021 11:55:46 +0200 Subject: Re: [PATCH v2] rootfs: clean package log files that are not owned by packages To: venkata.pyla@toshiba-tsip.com, isar-users@googlegroups.com Cc: henning.schild@siemens.com References: <20210906124831.202ce22f@md1za8fc.ad001.siemens.net> <20211001143748.8711-1-venkata.pyla@toshiba-tsip.com> From: Jan Kiszka Message-ID: Date: Mon, 4 Oct 2021 11:55:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211001143748.8711-1-venkata.pyla@toshiba-tsip.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: GiAm92jKaALd On 01.10.21 16:37, venkata.pyla@toshiba-tsip.com wrote: > From: venkata pyla > > /var/log/* files that are created during build stage and not owned > by any package are not neccessary to be present in rootfs image, as > these log files adds additional size to rootfs image, and also it > create problems for reproducible build functionality. > > so this ROOTFS feature 'clean-log-files' should help to clean the log > files when it is enalbed, disable it if we need the log files for > debugging purpose. > > ROOTFS_FEATURE += clean-log-files > Style: Do not indent the commit body. I think this will survive "git am" and will make the result look inconsistent. > Signed-off-by: venkata pyla > --- > meta/classes/rootfs.bbclass | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index f9151c5..ff0ecad 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -12,6 +12,7 @@ ROOTFS_PACKAGES ?= "" > # 'clean-package-cache' - delete package cache from rootfs > # 'generate-manifest' - generate a package manifest of the rootfs into ${ROOTFS_MANIFEST_DEPLOY_DIR} > # 'export-dpkg-status' - exports /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR} > +# 'clean-log-files' - delete log files that are not owned by packages > ROOTFS_FEATURES ?= "" > > ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" > @@ -213,6 +214,15 @@ rootfs_postprocess_clean_package_cache() { > sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* > } > > +ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-log-files', 'rootfs_postprocess_clean_log_files', '', d)}" > +rootfs_postprocess_clean_log_files() { > + # Delete log files that are not owned by packages > + sudo -E chroot '${ROOTFSDIR}' \ > + /usr/bin/find /var/log/ \ > + -exec sh -c '! dpkg -S {} > /dev/null 2>&1' ';' \ > + -exec rm -rf {} ';' > +} > + > ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', 'rootfs_generate_manifest', '', d)}" > rootfs_generate_manifest () { > mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR} > Is there any reason why this feature should be default-off? If not, I would also add it to image.bbclass, ROOTFS_FEATURES. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux